)]}'
{
  "commit": "7697c31e84946a85f09ea1fb5e05565f668e597b",
  "tree": "48bf0855f5825c73d56824bcb46829365a65aa74",
  "parents": [
    "3604e80321820bd2a7db8cfbedf413ac457bbc88"
  ],
  "author": {
    "name": "James Price",
    "email": "jrprice@google.com",
    "time": "Fri Jun 04 14:40:28 2021 +0000"
  },
  "committer": {
    "name": "Tint LUCI CQ",
    "email": "tint-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Jun 04 14:40:28 2021 +0000"
  },
  "message": "writer/msl: Emit builtins as parameters\n\nAdd a config parameter for the CanonicalizeEntryPoint transform that\nselects between emitting builtins as parameters (for MSL) or struct\nmembers (for HLSL).\n\nThis fixes all of the shader IO issues in Tint\u0027s E2E tests for MSL.\n\nFixed: tint:817\nChange-Id: Ieb31cdbd2e4d96ac41f8d8515fd07ead8241d770\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/53282\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nReviewed-by: Ben Clayton \u003cbclayton@google.com\u003e\nCommit-Queue: James Price \u003cjrprice@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "09bd511d2cf4ad620d028e183631585bd4f9f45a",
      "old_mode": 33188,
      "old_path": "src/transform/canonicalize_entry_point_io.cc",
      "new_id": "d0ac744710d8fc2c1513831263d4e19814b85e05",
      "new_mode": 33188,
      "new_path": "src/transform/canonicalize_entry_point_io.cc"
    },
    {
      "type": "modify",
      "old_id": "4298459046a8e41e4f7040e7a3ba5e50e98deda8",
      "old_mode": 33188,
      "old_path": "src/transform/canonicalize_entry_point_io.h",
      "new_id": "3cde21770be2c667df9c77e88efde6ad7c110a29",
      "new_mode": 33188,
      "new_path": "src/transform/canonicalize_entry_point_io.h"
    },
    {
      "type": "modify",
      "old_id": "e1f32c7db8886b0b5c108ca20545de57508870d8",
      "old_mode": 33188,
      "old_path": "src/transform/canonicalize_entry_point_io_test.cc",
      "new_id": "9d2c50df1458b6493a0b0d580c354aa86125448f",
      "new_mode": 33188,
      "new_path": "src/transform/canonicalize_entry_point_io_test.cc"
    },
    {
      "type": "modify",
      "old_id": "407e6b0d6ac8d6890be0f8b367c640efc283b0df",
      "old_mode": 33188,
      "old_path": "src/transform/hlsl.cc",
      "new_id": "8579e4907dcff61b2acbfcc0ffd3ee4667033c72",
      "new_mode": 33188,
      "new_path": "src/transform/hlsl.cc"
    },
    {
      "type": "modify",
      "old_id": "e8ae718cc29445d9a7d26a6318b0c20f4b532f2a",
      "old_mode": 33188,
      "old_path": "src/transform/msl.cc",
      "new_id": "1d793b54453d4a698c4f715e527ea555b6b37b9a",
      "new_mode": 33188,
      "new_path": "src/transform/msl.cc"
    },
    {
      "type": "modify",
      "old_id": "038caf64a3e727501ad4266d580ac7e9d18948b4",
      "old_mode": 33188,
      "old_path": "src/writer/msl/generator_impl_function_test.cc",
      "new_id": "d3641f10f6e9473923d30130d76dc3a526a261e5",
      "new_mode": 33188,
      "new_path": "src/writer/msl/generator_impl_function_test.cc"
    },
    {
      "type": "modify",
      "old_id": "6c0a282e50556bbb8ad55134be452f00979d6c2d",
      "old_mode": 33188,
      "old_path": "test/bug/tint/744.wgsl.expected.msl",
      "new_id": "66a945bf426260a35b075bbde6f898b2e90c1861",
      "new_mode": 33188,
      "new_path": "test/bug/tint/744.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "44d220578744b942781da928c970e98026b8624c",
      "old_mode": 33188,
      "old_path": "test/bug/tint/824.wgsl.expected.msl",
      "new_id": "3489d64a3c2f582ba76af7ba84626e072adc2f8b",
      "new_mode": 33188,
      "new_path": "test/bug/tint/824.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "23298d46889b126279d179349c5a7687c76b4ae8",
      "old_mode": 33188,
      "old_path": "test/samples/compute_boids.wgsl.expected.msl",
      "new_id": "22cc5da6ffd25a5ed10b2f3a9cb14d49b6c69723",
      "new_mode": 33188,
      "new_path": "test/samples/compute_boids.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "3d108db7b77ff3d896afccf3db0858b36617a7a6",
      "old_mode": 33188,
      "old_path": "test/samples/triangle.wgsl.expected.msl",
      "new_id": "7f4a0addd7851aaec191b64ad81e713c5eba5736",
      "new_mode": 33188,
      "new_path": "test/samples/triangle.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "71d62fb75324bbf2302899b356d4ff43bfa99f30",
      "old_mode": 33188,
      "old_path": "test/shader_io/compute_input_builtins.wgsl.expected.msl",
      "new_id": "2774a3d73338e0515404a8cc4602434cbf907d49",
      "new_mode": 33188,
      "new_path": "test/shader_io/compute_input_builtins.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "71d62fb75324bbf2302899b356d4ff43bfa99f30",
      "old_mode": 33188,
      "old_path": "test/shader_io/compute_input_builtins_struct.wgsl.expected.msl",
      "new_id": "9a16f1bd642a8127b77eda319a0351d92c41ec03",
      "new_mode": 33188,
      "new_path": "test/shader_io/compute_input_builtins_struct.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "71d62fb75324bbf2302899b356d4ff43bfa99f30",
      "old_mode": 33188,
      "old_path": "test/shader_io/compute_input_mixed.wgsl.expected.msl",
      "new_id": "fe6293b350c2342c47072f3016629fc93b97e535",
      "new_mode": 33188,
      "new_path": "test/shader_io/compute_input_mixed.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "3e46c6f5704442a0da3eb7fb72cb08277041f8c3",
      "old_mode": 33188,
      "old_path": "test/shader_io/fragment_input_builtins.wgsl.expected.msl",
      "new_id": "4204e5ea8d1e6706af380f55ca224228f221e5b1",
      "new_mode": 33188,
      "new_path": "test/shader_io/fragment_input_builtins.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "7f05ccfecb77aeb994589b9c2927a73ca59a00dd",
      "old_mode": 33188,
      "old_path": "test/shader_io/fragment_input_builtins_struct.wgsl.expected.msl",
      "new_id": "284dbe564ed16590049bbe414871b167fb7e0f07",
      "new_mode": 33188,
      "new_path": "test/shader_io/fragment_input_builtins_struct.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "4e7aa7fe867a9f2c153de5a3d10f3cef6c153113",
      "old_mode": 33188,
      "old_path": "test/shader_io/fragment_input_mixed.wgsl.expected.msl",
      "new_id": "9b3a13a5ba5dce43e5193d281b13c1435f5e7f99",
      "new_mode": 33188,
      "new_path": "test/shader_io/fragment_input_mixed.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "7183f0a8f666a560086a231a27383c157d44968e",
      "old_mode": 33188,
      "old_path": "test/shader_io/shared_struct_different_stages.wgsl.expected.msl",
      "new_id": "f51829c1e54f2359fc911a8fc8a26dda25f26142",
      "new_mode": 33188,
      "new_path": "test/shader_io/shared_struct_different_stages.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "63eeabf7f121445232379afa4b2922f96748c979",
      "old_mode": 33188,
      "old_path": "test/shader_io/shared_struct_storage_buffer.wgsl.expected.msl",
      "new_id": "63fe3383b7c75160d3c372db452f8baea5345311",
      "new_mode": 33188,
      "new_path": "test/shader_io/shared_struct_storage_buffer.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "71d62fb75324bbf2302899b356d4ff43bfa99f30",
      "old_mode": 33188,
      "old_path": "test/shader_io/vertex_input_builtins.wgsl.expected.msl",
      "new_id": "f3cff193009fc736ea759d8889d63aea503a069c",
      "new_mode": 33188,
      "new_path": "test/shader_io/vertex_input_builtins.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "71d62fb75324bbf2302899b356d4ff43bfa99f30",
      "old_mode": 33188,
      "old_path": "test/shader_io/vertex_input_builtins_struct.wgsl.expected.msl",
      "new_id": "c973c83b1bdb61142da5ea3afd2f7c2f53f79482",
      "new_mode": 33188,
      "new_path": "test/shader_io/vertex_input_builtins_struct.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "71d62fb75324bbf2302899b356d4ff43bfa99f30",
      "old_mode": 33188,
      "old_path": "test/shader_io/vertex_input_mixed.wgsl.expected.msl",
      "new_id": "9c1e8138b7f17ed056595bd3b6baf7b2fd7a8830",
      "new_mode": 33188,
      "new_path": "test/shader_io/vertex_input_mixed.wgsl.expected.msl"
    }
  ]
}