commit 7a0b7348647bd9aa6b5e84edeebb8bb86a3204e8
author Ryan Harrison <rharrison@chromium.org> Wed Jul 22 20:41:12 2020 +0000
committer dan sinclair <dsinclair@chromium.org> Wed Jul 22 20:41:12 2020 +0000
tree 88aebf854f3d41c500e07ceae26aa805beec37c2
parent b522fb343a018f850fbdb00b627b2a1c468e35b0

Fix BUILD.gn builds

Change-Id: I4e54b30497e064061baff2dcc205b68db87bee2c
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/25540
Reviewed-by: dan sinclair <dsinclair@chromium.org>

src/reader/spirv/function.cc

diff --git a/src/reader/spirv/function.cc b/src/reader/spirv/function.cc
index 3e547f9..cfd830e 100644
--- a/src/reader/spirv/function.cc
+++ b/src/reader/spirv/function.cc
@@ -3397,7 +3397,7 @@
   }
   auto call_expr = std::make_unique<ast::CallExpression>(std::move(function),
                                                          std::move(params));
-  auto result_type = parser_impl_.ConvertType(inst.type_id());
+  auto* result_type = parser_impl_.ConvertType(inst.type_id());
   if (!result_type) {
     return Fail() << "internal error: no mapped type result of call: "
                   << inst.PrettyPrint();

src/reader/spirv/function_call_test.cc

diff --git a/src/reader/spirv/function_call_test.cc b/src/reader/spirv/function_call_test.cc
index c38f136..c3581a5 100644
--- a/src/reader/spirv/function_call_test.cc
+++ b/src/reader/spirv/function_call_test.cc
@@ -31,7 +31,7 @@
 using ::testing::HasSubstr;
 
 TEST_F(SpvParserTest, EmitStatement_VoidCallNoParams) {
-  auto p = parser(test::Assemble(R"(
+  auto* p = parser(test::Assemble(R"(
      %void = OpTypeVoid
      %voidfn = OpTypeFunction %void
 
@@ -69,7 +69,7 @@
 }
 
 TEST_F(SpvParserTest, EmitStatement_ScalarCallNoParams) {
-  auto p = parser(test::Assemble(R"(
+  auto* p = parser(test::Assemble(R"(
      %void = OpTypeVoid
      %voidfn = OpTypeFunction %void
      %uint = OpTypeInt 32 0
@@ -121,7 +121,7 @@
 }
 
 TEST_F(SpvParserTest, EmitStatement_ScalarCallNoParamsUsedTwice) {
-  auto p = parser(test::Assemble(R"(
+  auto* p = parser(test::Assemble(R"(
      %void = OpTypeVoid
      %voidfn = OpTypeFunction %void
      %uint = OpTypeInt 32 0
@@ -191,7 +191,7 @@
 }
 
 TEST_F(SpvParserTest, EmitStatement_CallWithParams) {
-  auto p = parser(test::Assemble(R"(
+  auto* p = parser(test::Assemble(R"(
      %void = OpTypeVoid
      %voidfn = OpTypeFunction %void
      %uint = OpTypeInt 32 0

tint_overrides_with_defaults.gni

diff --git a/tint_overrides_with_defaults.gni b/tint_overrides_with_defaults.gni
index eaad186..22e698b 100644
--- a/tint_overrides_with_defaults.gni
+++ b/tint_overrides_with_defaults.gni
@@ -61,4 +61,9 @@
   if (!defined(tint_build_msl_writer)) {
     tint_build_msl_writer = false
   }
+
+  # Build the HLSL output writer
+  if (!defined(tint_build_hlsl_writer)) {
+    tint_build_hlsl_writer = false
+  }
 }