)]}'
{
  "commit": "7a47fa8495801c99c9b8b6e5efbaebf63ef8339e",
  "tree": "922a1670680c6c2999fb7432df1186bd02c67283",
  "parents": [
    "61e573663d084d1502236d75006f8857e4a3edf5"
  ],
  "author": {
    "name": "James Price",
    "email": "jrprice@google.com",
    "time": "Wed May 26 15:41:02 2021 +0000"
  },
  "committer": {
    "name": "Tint LUCI CQ",
    "email": "tint-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed May 26 15:41:02 2021 +0000"
  },
  "message": "writer/msl: Handle private and workgroup variables\n\nAdd a transform that pushes these into the entry point and then passes\nthem by pointer to any functions that need them.\n\nSince WGSL does not allow non-function storage class at\nfunction-scope, add a DisableValidation attribute to bypass this\ncheck.\n\nFixed: tint/726\nChange-Id: Ic1f4cd691a54c19e77a60e8ba178508e4249bfd9\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/51962\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nCommit-Queue: James Price \u003cjrprice@google.com\u003e\nAuto-Submit: James Price \u003cjrprice@google.com\u003e\nReviewed-by: Ben Clayton \u003cbclayton@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ef93c0fc6b73df5b6cd714055ce5f4bda3223c0d",
      "old_mode": 33188,
      "old_path": "src/ast/disable_validation_decoration.cc",
      "new_id": "59eb291c272984681cbc7491b54aedf73f74e8de",
      "new_mode": 33188,
      "new_path": "src/ast/disable_validation_decoration.cc"
    },
    {
      "type": "modify",
      "old_id": "a825230317c46f04c132744a2afe597f17f42a3b",
      "old_mode": 33188,
      "old_path": "src/ast/disable_validation_decoration.h",
      "new_id": "c94f166b8f9d13e6cc30322a44ec4c23002ea589",
      "new_mode": 33188,
      "new_path": "src/ast/disable_validation_decoration.h"
    },
    {
      "type": "modify",
      "old_id": "8058ab0936a2bcb0162b9d90bb4daf73a4ab5bdd",
      "old_mode": 33188,
      "old_path": "src/resolver/resolver.cc",
      "new_id": "15e7f3ea7ac4bb30aa9705599ebeba7ff5e4744a",
      "new_mode": 33188,
      "new_path": "src/resolver/resolver.cc"
    },
    {
      "type": "modify",
      "old_id": "764287dc1f19a8383fe8a4c61f1c012e9e5ba5c7",
      "old_mode": 33188,
      "old_path": "src/transform/msl.cc",
      "new_id": "a19b1556427b37504511a004b3ba30bbec693625",
      "new_mode": 33188,
      "new_path": "src/transform/msl.cc"
    },
    {
      "type": "modify",
      "old_id": "3121b67bcaa9404aed41861276152f93ff59fa59",
      "old_mode": 33188,
      "old_path": "src/transform/msl.h",
      "new_id": "7e83032ee24609edbe990804f574bccb44dcac5f",
      "new_mode": 33188,
      "new_path": "src/transform/msl.h"
    },
    {
      "type": "modify",
      "old_id": "d257b2bddd49dfb51a1cb8c640d18588021e299a",
      "old_mode": 33188,
      "old_path": "src/transform/msl_test.cc",
      "new_id": "70f50d8510eae6d16b08158e732ec0d2211fe43e",
      "new_mode": 33188,
      "new_path": "src/transform/msl_test.cc"
    },
    {
      "type": "modify",
      "old_id": "ed64bf92a5847406e695262fc942ee141d51d82f",
      "old_mode": 33188,
      "old_path": "src/writer/msl/generator_impl.cc",
      "new_id": "11ee9a1a146788506693505b91b0cecb6741b543",
      "new_mode": 33188,
      "new_path": "src/writer/msl/generator_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "8054ebdd47bc6f1a4549d32043ab6e0dd70b14a9",
      "old_mode": 33188,
      "old_path": "src/writer/msl/generator_impl_type_test.cc",
      "new_id": "9c682a615d4ea76abe26b93c6c726970768b9dc2",
      "new_mode": 33188,
      "new_path": "src/writer/msl/generator_impl_type_test.cc"
    },
    {
      "type": "modify",
      "old_id": "487a5a8bcf20bdaa05fe59ab6cb55fcdddd8eb5e",
      "old_mode": 33188,
      "old_path": "src/writer/msl/generator_impl_variable_decl_statement_test.cc",
      "new_id": "f4030972ba05a2d092aaee77b5a37c90c9e17f8a",
      "new_mode": 33188,
      "new_path": "src/writer/msl/generator_impl_variable_decl_statement_test.cc"
    },
    {
      "type": "modify",
      "old_id": "1b2d3db8ae2b08103871e91df445a02fa35806c0",
      "old_mode": 33188,
      "old_path": "test/bug/tint/749.spvasm.expected.msl",
      "new_id": "5a7c08c2b5ee45d23075b1ead2fff2ef5a9ce179",
      "new_mode": 33188,
      "new_path": "test/bug/tint/749.spvasm.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "1b2d3db8ae2b08103871e91df445a02fa35806c0",
      "old_mode": 33188,
      "old_path": "test/ptr_ref/load/global/i32.spvasm.expected.msl",
      "new_id": "c59e28e708a24774ae54301d1efb8339cb07a0e1",
      "new_mode": 33188,
      "new_path": "test/ptr_ref/load/global/i32.spvasm.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "1b2d3db8ae2b08103871e91df445a02fa35806c0",
      "old_mode": 33188,
      "old_path": "test/ptr_ref/load/global/i32.wgsl.expected.msl",
      "new_id": "943148857c096fea38a47e06ec5d9a8d4791968c",
      "new_mode": 33188,
      "new_path": "test/ptr_ref/load/global/i32.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "1b2d3db8ae2b08103871e91df445a02fa35806c0",
      "old_mode": 33188,
      "old_path": "test/ptr_ref/load/global/struct_field.spvasm.expected.msl",
      "new_id": "5a7c08c2b5ee45d23075b1ead2fff2ef5a9ce179",
      "new_mode": 33188,
      "new_path": "test/ptr_ref/load/global/struct_field.spvasm.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "1b2d3db8ae2b08103871e91df445a02fa35806c0",
      "old_mode": 33188,
      "old_path": "test/ptr_ref/load/global/struct_field.wgsl.expected.msl",
      "new_id": "5a7c08c2b5ee45d23075b1ead2fff2ef5a9ce179",
      "new_mode": 33188,
      "new_path": "test/ptr_ref/load/global/struct_field.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "1b2d3db8ae2b08103871e91df445a02fa35806c0",
      "old_mode": 33188,
      "old_path": "test/ptr_ref/load/local/ptr_private.wgsl.expected.msl",
      "new_id": "b41e14212ad724d50af9f9d47cea82c8744b3963",
      "new_mode": 33188,
      "new_path": "test/ptr_ref/load/local/ptr_private.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "1b2d3db8ae2b08103871e91df445a02fa35806c0",
      "old_mode": 33188,
      "old_path": "test/ptr_ref/load/local/ptr_workgroup.wgsl.expected.msl",
      "new_id": "983ba407ebb1459d3063a4e17d03118b11c8ced6",
      "new_mode": 33188,
      "new_path": "test/ptr_ref/load/local/ptr_workgroup.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "1b2d3db8ae2b08103871e91df445a02fa35806c0",
      "old_mode": 33188,
      "old_path": "test/ptr_ref/store/global/i32.spvasm.expected.msl",
      "new_id": "92fbc80e36284407843b30d57b7d79aa3ecebead",
      "new_mode": 33188,
      "new_path": "test/ptr_ref/store/global/i32.spvasm.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "1b2d3db8ae2b08103871e91df445a02fa35806c0",
      "old_mode": 33188,
      "old_path": "test/ptr_ref/store/global/i32.wgsl.expected.msl",
      "new_id": "92fbc80e36284407843b30d57b7d79aa3ecebead",
      "new_mode": 33188,
      "new_path": "test/ptr_ref/store/global/i32.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "1b2d3db8ae2b08103871e91df445a02fa35806c0",
      "old_mode": 33188,
      "old_path": "test/ptr_ref/store/global/struct_field.spvasm.expected.msl",
      "new_id": "3bde28121ef71bc104f40df5323ad1afd9d7145c",
      "new_mode": 33188,
      "new_path": "test/ptr_ref/store/global/struct_field.spvasm.expected.msl"
    },
    {
      "type": "delete",
      "old_id": "6be0c4afd47c9e39c703fe4a20e7bedccb0887c3",
      "old_mode": 33188,
      "old_path": "test/types/module_scope_declarations.wgsl",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "1b2d3db8ae2b08103871e91df445a02fa35806c0",
      "old_mode": 33188,
      "old_path": "test/types/module_scope_declarations.wgsl.expected.msl",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "9d09d2323d9583ab1922d97f45bebb83f3456988",
      "old_mode": 33188,
      "old_path": "test/types/module_scope_declarations.wgsl.expected.spvasm",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "e6edc6e29c17fb1ee58d4fa760cac5cec64cb0fa",
      "old_mode": 33188,
      "old_path": "test/types/module_scope_declarations.wgsl.expected.wgsl",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "16181dde2f4cb9dc33c77db010d300e61d632f97",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_let.wgsl"
    },
    {
      "type": "rename",
      "old_id": "a0d68163fd3bbd1ccd8f111054492ef7b045ffb4",
      "old_mode": 33188,
      "old_path": "test/types/module_scope_declarations.wgsl.expected.hlsl",
      "new_id": "a0d68163fd3bbd1ccd8f111054492ef7b045ffb4",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_let.wgsl.expected.hlsl",
      "score": 100
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "e3a2d4e9a025eb2d48d8281cebc734962cabb3d7",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_let.wgsl.expected.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "947c62fb9297e2f2e48109634a2512a54e50efd8",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_let.wgsl.expected.spvasm"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "eebe89e4a35bff9d5aee2915a9670a400d5cfed4",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_let.wgsl.expected.wgsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "c2442e42ba9d53771ddde132b412426a1c2ff9d8",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_var.wgsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b28e7961cad0f40f0c0519618afde3e5dc819ed8",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_var.wgsl.expected.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "77696bec2b1f3303f6ebdf9e0df5f908412b4b0c",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_var.wgsl.expected.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "2fa75f159ddb6bb1ea27863bc2d6aacf48a453a8",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_var.wgsl.expected.spvasm"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "7e53714c144cd4d5eac8b322a0fb559207e79420",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_var.wgsl.expected.wgsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "3994d12ab948ec79ec20958b40f61555e89597c9",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_var_initializers.wgsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "562a445a77eb748c933866ccbb53aa5313a3db48",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_var_initializers.wgsl.expected.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "77696bec2b1f3303f6ebdf9e0df5f908412b4b0c",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_var_initializers.wgsl.expected.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "0fb29092242763ce3059062b66b2eb89b604858d",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_var_initializers.wgsl.expected.spvasm"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "7b16c09fc37ce1680142c125e11b28615adb5456",
      "new_mode": 33188,
      "new_path": "test/types/module_scope_var_initializers.wgsl.expected.wgsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "e03db87e4d3db03777aa8c288c36c53d5fe4c3ac",
      "new_mode": 33188,
      "new_path": "test/var/private.wgsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "f30875ef84b8035065a708d133acf2d443e449d4",
      "new_mode": 33188,
      "new_path": "test/var/private.wgsl.expected.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "f17afeb8527bad2188fc4d067be72e8d52c18ce9",
      "new_mode": 33188,
      "new_path": "test/var/private.wgsl.expected.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "daa3cfb1b875315b8ac2daa95d3b18f32d7332c8",
      "new_mode": 33188,
      "new_path": "test/var/private.wgsl.expected.spvasm"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "ef20cc20eb53fb7785a3fbb59c35d89af17caa4d",
      "new_mode": 33188,
      "new_path": "test/var/private.wgsl.expected.wgsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "1d0ba40d17e61495ae29943d0941abeea2e75f86",
      "new_mode": 33188,
      "new_path": "test/var/workgroup.wgsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "83c32cae8cafa1d77fb17d0cc5f4703394b9d8fc",
      "new_mode": 33188,
      "new_path": "test/var/workgroup.wgsl.expected.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "3c53df8df871efc423339b91292d3c4ae2fdc7f5",
      "new_mode": 33188,
      "new_path": "test/var/workgroup.wgsl.expected.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "66c1f0ccbf4217dac17b33f48ea362caead7ca00",
      "new_mode": 33188,
      "new_path": "test/var/workgroup.wgsl.expected.spvasm"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "1861fb8832f64d7a5ed5528a85ab757a02f9fc12",
      "new_mode": 33188,
      "new_path": "test/var/workgroup.wgsl.expected.wgsl"
    }
  ]
}