| commit | a0b679668701a9b47732757e5cb8b343c06cbd76 | [log] [tgz] |
|---|---|---|
| author | David Neto <dneto@google.com> | Mon Nov 16 17:35:57 2020 +0000 |
| committer | Commit Bot service account <commit-bot@chromium.org> | Mon Nov 16 17:35:57 2020 +0000 |
| tree | 27e7d8a9ca813b01ab7db275022197c5a3126d61 | |
| parent | df2d92d5bb06f1358d7d514c5a8f8dc8a3f0ecea [diff] |
spirv-reader: better message for unknown SPIR-V type Change-Id: I56a314d0c4eb1f1dfdb8804024a5824e5456356c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32940 Commit-Queue: David Neto <dneto@google.com> Commit-Queue: dan sinclair <dsinclair@chromium.org> Auto-Submit: David Neto <dneto@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org>
diff --git a/src/reader/spirv/parser_impl.cc b/src/reader/spirv/parser_impl.cc index 7cc274d..7068857 100644 --- a/src/reader/spirv/parser_impl.cc +++ b/src/reader/spirv/parser_impl.cc
@@ -309,7 +309,8 @@ break; } - Fail() << "unknown SPIR-V type: " << type_id; + Fail() << "unknown SPIR-V type with ID " << type_id << ": " + << def_use_mgr_->GetDef(type_id)->PrettyPrint(); return nullptr; }
diff --git a/src/reader/spirv/parser_impl_convert_type_test.cc b/src/reader/spirv/parser_impl_convert_type_test.cc index 3f18da7..5674465 100644 --- a/src/reader/spirv/parser_impl_convert_type_test.cc +++ b/src/reader/spirv/parser_impl_convert_type_test.cc
@@ -79,7 +79,8 @@ auto* type = p->ConvertType(70); EXPECT_EQ(nullptr, type); - EXPECT_THAT(p->error(), Eq("unknown SPIR-V type: 70")); + EXPECT_THAT(p->error(), + Eq("unknown SPIR-V type with ID 70: %70 = OpTypePipe WriteOnly")); } TEST_F(SpvParserTest, ConvertType_Void) {