)]}'
{
  "commit": "bbbb0edec2d92a20bc104982b5565c2fd4949678",
  "tree": "a43a6e218226bfecc7a0abdcf58a5462368c6e3f",
  "parents": [
    "4f154a839d92624b3fbe1f519c66981ddc8f14a3"
  ],
  "author": {
    "name": "Antonio Maiorano",
    "email": "amaiorano@google.com",
    "time": "Tue Apr 06 20:18:57 2021 +0000"
  },
  "committer": {
    "name": "Commit Bot service account",
    "email": "commit-bot@chromium.org",
    "time": "Tue Apr 06 20:18:57 2021 +0000"
  },
  "message": "Move global var validation from Validator to Resolver\n\n* Moved global variable resolving logic to new function Resolver::GlobalVariable, and moved validation logic there.\n* Moved global variable-related tests to resolver tests.\n* Fixed many tests that started failing after this change, mainly because many globals were declared with no storage class. I set most of these to \"Input\".\n\nBug: tint:642\nChange-Id: I0f8ea2091ed2bb3faa358f9497cd884b2994a40f\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/46940\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nReviewed-by: Ben Clayton \u003cbclayton@google.com\u003e\nCommit-Queue: Antonio Maiorano \u003camaiorano@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "4decb9297ad2cccb7183246ca268a187bb88f070",
      "old_mode": 33188,
      "old_path": "src/ast/module_clone_test.cc",
      "new_id": "1fc36c189ac4a486ba85605f2d3b781599231e4c",
      "new_mode": 33188,
      "new_path": "src/ast/module_clone_test.cc"
    },
    {
      "type": "modify",
      "old_id": "39f8f8d891521fc34551db816c46116aad28bf7a",
      "old_mode": 33188,
      "old_path": "src/resolver/decoration_validation_test.cc",
      "new_id": "1669a502d67a4a32a5c2b16ee68e1a52c8c8b919",
      "new_mode": 33188,
      "new_path": "src/resolver/decoration_validation_test.cc"
    },
    {
      "type": "modify",
      "old_id": "aaac6a3384b25800310186e8104c10770fd71a26",
      "old_mode": 33188,
      "old_path": "src/resolver/host_shareable_validation_test.cc",
      "new_id": "82fecda85d2d26c398347139a9c310ca000c72fc",
      "new_mode": 33188,
      "new_path": "src/resolver/host_shareable_validation_test.cc"
    },
    {
      "type": "modify",
      "old_id": "22bb0eef80060d040bdeff046bfdd6b2cfc85583",
      "old_mode": 33188,
      "old_path": "src/resolver/intrinsic_test.cc",
      "new_id": "1ec20a94c8d1c9982f85cea9aa1d8038ff2a0416",
      "new_mode": 33188,
      "new_path": "src/resolver/intrinsic_test.cc"
    },
    {
      "type": "modify",
      "old_id": "5c54e4867f2c45217054c2530b39f28ae52a658a",
      "old_mode": 33188,
      "old_path": "src/resolver/resolver.cc",
      "new_id": "d09ea623cd7bdf1bad4023c199dbdc6134ac9206",
      "new_mode": 33188,
      "new_path": "src/resolver/resolver.cc"
    },
    {
      "type": "modify",
      "old_id": "d74e826374d9ad19dbed042579c82ffa55945543",
      "old_mode": 33188,
      "old_path": "src/resolver/resolver.h",
      "new_id": "e3d7edf2b1ab9ef94108a74211547a79d26edcce",
      "new_mode": 33188,
      "new_path": "src/resolver/resolver.h"
    },
    {
      "type": "modify",
      "old_id": "7ee58c6ceb02986ee66b281dbd2f57f9cf02bae7",
      "old_mode": 33188,
      "old_path": "src/resolver/resolver_test.cc",
      "new_id": "fd2c15185f00e26e949a4bd857c4f52a03e819de",
      "new_mode": 33188,
      "new_path": "src/resolver/resolver_test.cc"
    },
    {
      "type": "modify",
      "old_id": "a7c239420e35bb80404531c0658ea4ca1b8b7429",
      "old_mode": 33188,
      "old_path": "src/resolver/type_validation_test.cc",
      "new_id": "ee4144cadee513d5a71e06c8d30916ae2a52e76a",
      "new_mode": 33188,
      "new_path": "src/resolver/type_validation_test.cc"
    },
    {
      "type": "modify",
      "old_id": "11266c4d4ae42342230e41697e51f271e4a3bc57",
      "old_mode": 33188,
      "old_path": "src/resolver/validation_test.cc",
      "new_id": "408f0b209f9ba6cb49fb28c41b34e894a44b002f",
      "new_mode": 33188,
      "new_path": "src/resolver/validation_test.cc"
    },
    {
      "type": "modify",
      "old_id": "4f82af464ba0d477fa33e9a518eda9630cc8735a",
      "old_mode": 33188,
      "old_path": "src/transform/bound_array_accessors_test.cc",
      "new_id": "fc9b87ebc2493325428251bb7b5ec0b4ac406f45",
      "new_mode": 33188,
      "new_path": "src/transform/bound_array_accessors_test.cc"
    },
    {
      "type": "modify",
      "old_id": "a48ff9f1077d89db12b7ed8ff751a60a7e9c765b",
      "old_mode": 33188,
      "old_path": "src/validator/validator_decoration_test.cc",
      "new_id": "069eb8a933f1a56db99d5d9919edc1940a30238f",
      "new_mode": 33188,
      "new_path": "src/validator/validator_decoration_test.cc"
    },
    {
      "type": "modify",
      "old_id": "49529950c4cfd7591e4e8899aa0c7dfbbcee4775",
      "old_mode": 33188,
      "old_path": "src/validator/validator_impl.cc",
      "new_id": "1e4558a674d858098b3755f1ecd0285c2600f1d4",
      "new_mode": 33188,
      "new_path": "src/validator/validator_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "d496233abaeedbbd5440db0af00f8203208f4561",
      "old_mode": 33188,
      "old_path": "src/validator/validator_test.cc",
      "new_id": "c13a8f7eedc3faed366e3eefc23809ae184b3066",
      "new_mode": 33188,
      "new_path": "src/validator/validator_test.cc"
    },
    {
      "type": "modify",
      "old_id": "f5941f0e0b55beed14cd82474b6caad725603dfb",
      "old_mode": 33188,
      "old_path": "src/writer/hlsl/generator_impl_binary_test.cc",
      "new_id": "deb76a0cd1784d3666e8294aefc9496e2ee5b6e2",
      "new_mode": 33188,
      "new_path": "src/writer/hlsl/generator_impl_binary_test.cc"
    },
    {
      "type": "modify",
      "old_id": "ea505ee470fffdc8082a59c4a599989065fda165",
      "old_mode": 33188,
      "old_path": "src/writer/hlsl/generator_impl_call_test.cc",
      "new_id": "189e44eb35615ff18ad03b2a2e50c9f45c0ddad8",
      "new_mode": 33188,
      "new_path": "src/writer/hlsl/generator_impl_call_test.cc"
    },
    {
      "type": "modify",
      "old_id": "ff387204bc3813792f5884b6b42223fe46c6305f",
      "old_mode": 33188,
      "old_path": "src/writer/hlsl/generator_impl_loop_test.cc",
      "new_id": "62b5278b6e57abd0fd1121e8cf7d32794477589d",
      "new_mode": 33188,
      "new_path": "src/writer/hlsl/generator_impl_loop_test.cc"
    },
    {
      "type": "modify",
      "old_id": "495763d0963d507e0ef97feb370dafa0e39f407e",
      "old_mode": 33188,
      "old_path": "src/writer/hlsl/generator_impl_variable_decl_statement_test.cc",
      "new_id": "b5aacb33d3408075efa82031fa31bb55d7f7e371",
      "new_mode": 33188,
      "new_path": "src/writer/hlsl/generator_impl_variable_decl_statement_test.cc"
    },
    {
      "type": "modify",
      "old_id": "03780ded4e55c07d8e8c48e46be232e5e107c57a",
      "old_mode": 33188,
      "old_path": "src/writer/msl/generator_impl_call_test.cc",
      "new_id": "bd015b67e0253d1f1a3ea18f8b697a56e4938581",
      "new_mode": 33188,
      "new_path": "src/writer/msl/generator_impl_call_test.cc"
    },
    {
      "type": "modify",
      "old_id": "da4e36d4e29f33c00c18d7b5447348e50933a721",
      "old_mode": 33188,
      "old_path": "src/writer/msl/generator_impl_loop_test.cc",
      "new_id": "a7c638b28683a8ab30a212eaf6212c919dfdf25c",
      "new_mode": 33188,
      "new_path": "src/writer/msl/generator_impl_loop_test.cc"
    },
    {
      "type": "modify",
      "old_id": "2540a8f37bf691d32d465c90b20b3b57eec021c8",
      "old_mode": 33188,
      "old_path": "src/writer/msl/generator_impl_type_test.cc",
      "new_id": "51b0325c075e6cf6a7cc1c9a0a12d0b9f3459363",
      "new_mode": 33188,
      "new_path": "src/writer/msl/generator_impl_type_test.cc"
    },
    {
      "type": "modify",
      "old_id": "e67fcdb8d01f3dfa517824f7be2c96f515e8ccd0",
      "old_mode": 33188,
      "old_path": "src/writer/msl/generator_impl_variable_decl_statement_test.cc",
      "new_id": "799555adb16426670323ee1853f1583adeddc9c1",
      "new_mode": 33188,
      "new_path": "src/writer/msl/generator_impl_variable_decl_statement_test.cc"
    },
    {
      "type": "modify",
      "old_id": "18c12272d5da62319a34c2d7b893dc18311045d4",
      "old_mode": 33188,
      "old_path": "src/writer/spirv/builder_function_variable_test.cc",
      "new_id": "8d87df3c77ed3e558b55e8c07d1f7825f21dfd63",
      "new_mode": 33188,
      "new_path": "src/writer/spirv/builder_function_variable_test.cc"
    },
    {
      "type": "modify",
      "old_id": "bc782e1fb2becebe019f003671b0422f26e226f2",
      "old_mode": 33188,
      "old_path": "src/writer/spirv/builder_global_variable_test.cc",
      "new_id": "f3f321753bf28baaaf9be2b2d641d34d25e78643",
      "new_mode": 33188,
      "new_path": "src/writer/spirv/builder_global_variable_test.cc"
    },
    {
      "type": "modify",
      "old_id": "ba07575d1495a6448b10db58fab318c56ab1329b",
      "old_mode": 33188,
      "old_path": "src/writer/spirv/builder_intrinsic_test.cc",
      "new_id": "47fd65b00f0d4e5af32491cc8e8c73443352303a",
      "new_mode": 33188,
      "new_path": "src/writer/spirv/builder_intrinsic_test.cc"
    },
    {
      "type": "modify",
      "old_id": "328de289a54434297a98747008479ac50e853ecf",
      "old_mode": 33188,
      "old_path": "src/writer/spirv/builder_intrinsic_texture_test.cc",
      "new_id": "ea779387713917abdf972973bfe329e8da87279f",
      "new_mode": 33188,
      "new_path": "src/writer/spirv/builder_intrinsic_texture_test.cc"
    },
    {
      "type": "modify",
      "old_id": "6ebb64d5881299d8913d38d6d1c894a10fc33fe5",
      "old_mode": 33188,
      "old_path": "src/writer/spirv/builder_type_test.cc",
      "new_id": "09541b5e97a49432e0545264b52805e40d331b04",
      "new_mode": 33188,
      "new_path": "src/writer/spirv/builder_type_test.cc"
    },
    {
      "type": "modify",
      "old_id": "77c5a1a6149960c4d30a6d16d98b6c03c644d84b",
      "old_mode": 33188,
      "old_path": "src/writer/wgsl/generator_impl_test.cc",
      "new_id": "54645142beacd66b12f93b46b11340047e325c3b",
      "new_mode": 33188,
      "new_path": "src/writer/wgsl/generator_impl_test.cc"
    },
    {
      "type": "modify",
      "old_id": "a91c5e1485910c4e3a735a1783c1384b984ca06b",
      "old_mode": 33188,
      "old_path": "src/writer/wgsl/generator_impl_variable_decl_statement_test.cc",
      "new_id": "545de83bb70ba07001d0375d667072fa79769ee4",
      "new_mode": 33188,
      "new_path": "src/writer/wgsl/generator_impl_variable_decl_statement_test.cc"
    },
    {
      "type": "modify",
      "old_id": "87660fd7273177e107aa9ef8b4d2f9bb7121632d",
      "old_mode": 33188,
      "old_path": "src/writer/wgsl/generator_impl_variable_test.cc",
      "new_id": "d0912918096522a86f4acb15ccb75f1b4332d502",
      "new_mode": 33188,
      "new_path": "src/writer/wgsl/generator_impl_variable_test.cc"
    }
  ]
}