commit f0756e347ad786ed3ec22b1b8ab3122a55b9fea5
author Ben Clayton <bclayton@google.com> Thu Apr 29 20:57:55 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Thu Apr 29 20:57:55 2021 +0000
tree 7004e05caf0ebdf7da9f331134888a9f5e69c075
parent 52456c69c8216ca8c06af41a021236aae191a5e8

resolver: Improve the ICE msg about nodes

Include the pointer - helps debugging

Change-Id: I50058095710eb528446bbd8d8e3069dd657c75c8
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/49521
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>

src/resolver/resolver.cc

diff --git a/src/resolver/resolver.cc b/src/resolver/resolver.cc
index c4588cd..3e21014 100644
--- a/src/resolver/resolver.cc
+++ b/src/resolver/resolver.cc
@@ -266,7 +266,8 @@
       TINT_ICE(diagnostics_) << "AST node '" << node->TypeInfo().name
                              << "' was not reached by the resolver\n"
                              << "At: " << node->source() << "\n"
-                             << "Content: " << builder_->str(node);
+                             << "Content: " << builder_->str(node) << "\n"
+                             << "Pointer: " << node;
     }
   }
 
@@ -2774,7 +2775,9 @@
   TINT_ICE(diagnostics_)
       << "AST node '" << node->TypeInfo().name
       << "' was encountered twice in the same AST of a Program\n"
-      << "At: " << node->source();
+      << "At: " << node->source() << "\n"
+      << "Content: " << builder_->str(node) << "\n"
+      << "Pointer: " << node;
 }
 
 Resolver::VariableInfo::VariableInfo(const ast::Variable* decl,