commit f4434cd40344a20ddc20e8d2c629d134c869cb3c
author Dan Sinclair <dsinclair@google.com> Tue Mar 17 03:54:38 2020 +0000
committer Sarah Mashayekhi <sarahmashay@google.com> Tue Mar 17 03:54:38 2020 +0000
tree cb207460b9379d871c63b6581808dc93453e2c61
parent 5ced2178a604511e01ff1b9afff649126c0b72a0

Add UnaryDerivativeExpression tests

This CL adds tests for the UnaryDerivativeExpression AST element.

Bug: tint:11
Change-Id: Ieabfdcb7940aedc58a3455b74c0ddb508b4859ff
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/16673
Reviewed-by: Sarah Mashayekhi <sarahmashay@google.com>

src/ast/unary_derivative_expression.cc

diff --git a/src/ast/unary_derivative_expression.cc b/src/ast/unary_derivative_expression.cc
index 1ae9a86..b2416f3 100644
--- a/src/ast/unary_derivative_expression.cc
+++ b/src/ast/unary_derivative_expression.cc
@@ -17,6 +17,8 @@
 namespace tint {
 namespace ast {
 
+UnaryDerivativeExpression::UnaryDerivativeExpression() : Expression() {}
+
 UnaryDerivativeExpression::UnaryDerivativeExpression(
     UnaryDerivative op,
     DerivativeModifier mod,
@@ -33,6 +35,9 @@
 UnaryDerivativeExpression::~UnaryDerivativeExpression() = default;
 
 bool UnaryDerivativeExpression::IsValid() const {
+  if (param_ == nullptr || !param_->IsValid()) {
+    return false;
+  }
   return true;
 }
 
@@ -43,9 +48,9 @@
   out << op_ << std::endl;
   make_indent(out, indent + 2);
   out << modifier_ << std::endl;
-  param_->to_str(out, indent);
+  param_->to_str(out, indent + 2);
   make_indent(out, indent);
-  out << "}";
+  out << "}" << std::endl;
 }
 
 }  // namespace ast