commit f70065f6222776f60738099b1c1319c9fbc36627
author Sarah Mashayekhi <sarahmashay@google.com> Mon Aug 24 16:03:36 2020 +0000
committer Commit Bot service account <commit-bot@chromium.org> Mon Aug 24 16:03:36 2020 +0000
tree c7d8951b253ecca3cb5f7e497656865fe7a36ec9
parent c3038ddfa6eb68872b7d1c0328c859481a7f5eb3

[validation] Validate if entry point functions accept parameters

Bug: tint: 6
Change-Id: I7e9f50759e65ed6ef3dc25a6c004bec3dfbd4648
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/27122
Commit-Queue: Sarah Mashayekhi <sarahmashay@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>

src/validator_function_test.cc

diff --git a/src/validator_function_test.cc b/src/validator_function_test.cc
index 70684d1..e8e4eee 100644
--- a/src/validator_function_test.cc
+++ b/src/validator_function_test.cc
@@ -312,7 +312,7 @@
             "12:34: v-0024: Entry point function must return void: 'vtx_main'");
 }
 
-TEST_F(ValidateFunctionTest, DISABLED_EntryPointFunctionWithParams_Fail) {
+TEST_F(ValidateFunctionTest, EntryPointFunctionWithParams_Fail) {
   // entry_point vertex as "func" = vtx_func
   // fn vtx_func(a : i32) -> void { return; }
   ast::type::I32Type i32;

src/validator_impl.cc

diff --git a/src/validator_impl.cc b/src/validator_impl.cc
index 9f36feb..48fd7d2 100644
--- a/src/validator_impl.cc
+++ b/src/validator_impl.cc
@@ -76,6 +76,12 @@
                     ep_ptr->function_name() + "'");
       return false;
     }
+    if (func->params().size() != 0) {
+      set_error(ep_ptr->source(),
+                "v-0023: Entry point function must accept no parameters: '" +
+                    ep_ptr->function_name() + "'");
+      return false;
+    }
   }
   return true;
 }