)]}'
{
  "commit": "faca02d438c5789999c6a35cab3fdfb87f5c5c73",
  "tree": "d6f546a4f3acf8121cbe95cba618e416b78da3b6",
  "parents": [
    "2101c35f3bbfae6c673ac7dd90fb9e5b057186a4"
  ],
  "author": {
    "name": "Ben Clayton",
    "email": "bclayton@google.com",
    "time": "Wed Feb 10 21:34:25 2021 +0000"
  },
  "committer": {
    "name": "Commit Bot service account",
    "email": "commit-bot@chromium.org",
    "time": "Wed Feb 10 21:34:25 2021 +0000"
  },
  "message": "IntrinsicTable: Fix a number of TODOs\n\nAnd add tests for IntrinsicTable.\n\nDrop all the type unwrapping - be precise:\n* Display the actual argument types in the signature mismatch message\n* Only dereference pointer arguments if the parameter does not expect a pointer\n\nCorrectly match access control on storage types\n\nNote that I was mistaken in tint:486 - the TypeDeterminer is resolving identifiers to variables correctly as pointer types. The confustion here was probably due to all the UnwrapAll() calls, which have now all gone.\n\nFixed: tint:486\nChange-Id: I239eabd1fedfc082566c4af616ccfc58786cae25\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/41280\nCommit-Queue: Ben Clayton \u003cbclayton@google.com\u003e\nAuto-Submit: Ben Clayton \u003cbclayton@google.com\u003e\nReviewed-by: dan sinclair \u003cdsinclair@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "4147124dd6dec98f8431493a6ce52449b5462f70",
      "old_mode": 33188,
      "old_path": "BUILD.gn",
      "new_id": "d2b263755c015226accb3dfc6c75eebf4ee10d21",
      "new_mode": 33188,
      "new_path": "BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "4026aac8376d7ffc6f938813c40fd7c43e7073be",
      "old_mode": 33188,
      "old_path": "src/CMakeLists.txt",
      "new_id": "e4b81d4a2a067dfb583f0d6aa0ceac0c71009f60",
      "new_mode": 33188,
      "new_path": "src/CMakeLists.txt"
    },
    {
      "type": "modify",
      "old_id": "a0f3cc2a0b56677f4f0a86f067ebf105ea656296",
      "old_mode": 33188,
      "old_path": "src/intrinsic_table.cc",
      "new_id": "74c22426a9599dd2d2a88de53b58289f34b50ba8",
      "new_mode": 33188,
      "new_path": "src/intrinsic_table.cc"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "fc75e0c9144c86da9b4cee853c942bbd30dda1f4",
      "new_mode": 33188,
      "new_path": "src/intrinsic_table_test.cc"
    },
    {
      "type": "modify",
      "old_id": "16cae05ca58af81070e4909eddea36c7b5dee27c",
      "old_mode": 33188,
      "old_path": "src/semantic/call_target.h",
      "new_id": "ce0587e4e3e52b355a8ebfa950028b021586dd83",
      "new_mode": 33188,
      "new_path": "src/semantic/call_target.h"
    },
    {
      "type": "modify",
      "old_id": "2ae9ad1e96b8158cabd48899b7f3dc65bd61b363",
      "old_mode": 33188,
      "old_path": "src/semantic/sem_call_target.cc",
      "new_id": "5c8011de8a0afef666b82bd10d8647f004430568",
      "new_mode": 33188,
      "new_path": "src/semantic/sem_call_target.cc"
    },
    {
      "type": "modify",
      "old_id": "fc46468fc830e25f8e3e73274c0ace71684f7c3d",
      "old_mode": 33188,
      "old_path": "src/type_determiner_test.cc",
      "new_id": "f6e88596a5cc901d21b81a84382a2c3097747534",
      "new_mode": 33188,
      "new_path": "src/type_determiner_test.cc"
    }
  ]
}