)]}'
{
  "commit": "11d09f2fe7c006b78f7319e876e4ced43f0c1a60",
  "tree": "72f1248e6382d14aa2404a5e4a74f0dbfe0a60ec",
  "parents": [
    "1704fe53f59ac719a52cd0c2b7f897dba92907c5"
  ],
  "author": {
    "name": "Antonio Maiorano",
    "email": "amaiorano@google.com",
    "time": "Thu Nov 18 13:50:12 2021 +0000"
  },
  "committer": {
    "name": "Tint LUCI CQ",
    "email": "tint-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Nov 18 13:50:12 2021 +0000"
  },
  "message": "HLSL: force FXC to never unroll loops\n\nEmit the \"[loop]\" attribute on \"for\" and \"while\" so that FXC does not\nattempt to unroll them. This is to work around an FXC bug where it fails\nto unroll loops with gradient operations.\n\nFXC ostensibly unrolls such loops because gradient operations require\nuniform control flow, and loops that have varying iterations may\npossibly not be uniform. Tint will eventually validate that control flow\nis indeed uniform, so forcing FXC to avoid unrolling in these cases\nshould be fine.\n\nBug: tint:1112\nChange-Id: I10077f8b62fbbb230a0003f3864c75a8fe0e1d18\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/69880\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nReviewed-by: Ben Clayton \u003cbclayton@google.com\u003e\nCommit-Queue: Antonio Maiorano \u003camaiorano@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b8352c7d6f19f73e59870ed479654082266f9986",
      "old_mode": 33188,
      "old_path": "src/writer/hlsl/generator_impl.cc",
      "new_id": "3d3895a56e480fece3cf05fb4c255ee2a21f6f0b",
      "new_mode": 33188,
      "new_path": "src/writer/hlsl/generator_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "e312b826ed72b1a8726c106b321a1442f5ee320f",
      "old_mode": 33188,
      "old_path": "src/writer/hlsl/generator_impl_continue_test.cc",
      "new_id": "80baf57e42e05b543b8ca2354b0bf06b3989b31d",
      "new_mode": 33188,
      "new_path": "src/writer/hlsl/generator_impl_continue_test.cc"
    },
    {
      "type": "modify",
      "old_id": "a66782e96050ceb37990a1b7b22d0f54beb30ad7",
      "old_mode": 33188,
      "old_path": "src/writer/hlsl/generator_impl_loop_test.cc",
      "new_id": "c6a919f76809f357d5065fcdc456fb232f6fe1a8",
      "new_mode": 33188,
      "new_path": "src/writer/hlsl/generator_impl_loop_test.cc"
    },
    {
      "type": "modify",
      "old_id": "5b15fc12562f2bc25feb2d6bb258d6e50cb70acc",
      "old_mode": 33188,
      "old_path": "test/array/assign_to_function_var.wgsl.expected.hlsl",
      "new_id": "f5c4ff0a76877f2267d2ede30860e418c7710592",
      "new_mode": 33188,
      "new_path": "test/array/assign_to_function_var.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "8cd8ee1b62af51e2f519ace117bd2123cdb37f70",
      "old_mode": 33188,
      "old_path": "test/array/assign_to_private_var.wgsl.expected.hlsl",
      "new_id": "4fd9d453dda072834e29747006a26d8a55d8d66f",
      "new_mode": 33188,
      "new_path": "test/array/assign_to_private_var.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "8825ef39d78007d74cd3857d30c765d2d17cd776",
      "old_mode": 33188,
      "old_path": "test/array/assign_to_storage_var.wgsl.expected.hlsl",
      "new_id": "8e9d0b6e04e9fd2358f29179f163e663d2f2e455",
      "new_mode": 33188,
      "new_path": "test/array/assign_to_storage_var.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "43a8a1cb296d5c9f01759a512d1f45c5febbe4fb",
      "old_mode": 33188,
      "old_path": "test/array/assign_to_workgroup_var.wgsl.expected.hlsl",
      "new_id": "b60b9741ba0287913036b3e8bb747c35f5551a76",
      "new_mode": 33188,
      "new_path": "test/array/assign_to_workgroup_var.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "789126bf81927899c2bbe0950a42b022d056df9a",
      "old_mode": 33188,
      "old_path": "test/buffer/storage/dynamic_index/read.wgsl.expected.hlsl",
      "new_id": "25056c12eb60a9f5bcac8841b6d04fe420e98504",
      "new_mode": 33188,
      "new_path": "test/buffer/storage/dynamic_index/read.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "d267673c0e7f2f1ed8f4346a701520df7b804570",
      "old_mode": 33188,
      "old_path": "test/buffer/storage/dynamic_index/write.wgsl.expected.hlsl",
      "new_id": "3fb60a25d52efafbe52ed4c6d00fa488210409f6",
      "new_mode": 33188,
      "new_path": "test/buffer/storage/dynamic_index/write.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "42a6a71d42b96d45ea303803757c8d54c6721c1f",
      "old_mode": 33188,
      "old_path": "test/buffer/storage/static_index/read.wgsl.expected.hlsl",
      "new_id": "667739be6a0e1f102d7ba1f6f1417ee2c6c50a9d",
      "new_mode": 33188,
      "new_path": "test/buffer/storage/static_index/read.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "8c9b7ea6c5f177738bd976d3531968678dd3d397",
      "old_mode": 33188,
      "old_path": "test/buffer/storage/static_index/write.wgsl.expected.hlsl",
      "new_id": "8a2e683a06d89ad5ef008d757b9668d262132e73",
      "new_mode": 33188,
      "new_path": "test/buffer/storage/static_index/write.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "b110fb71d873c16db343a67cb4913cf3af492b43",
      "old_mode": 33188,
      "old_path": "test/buffer/uniform/dynamic_index/read.wgsl.expected.hlsl",
      "new_id": "0d7bd06a72b82504cc99b58a10ddffe7cacd98b2",
      "new_mode": 33188,
      "new_path": "test/buffer/uniform/dynamic_index/read.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "f66c81b288adaaa4c8f352f350eba54e5ebe74d0",
      "old_mode": 33188,
      "old_path": "test/buffer/uniform/static_index/read.wgsl.expected.hlsl",
      "new_id": "9fa1d0393aa4557e86a4bd48e79dc0f4911cad32",
      "new_mode": 33188,
      "new_path": "test/buffer/uniform/static_index/read.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "0ea2ad60c6bbb3370570fc04935a934093096ac6",
      "old_mode": 33188,
      "old_path": "test/bug/fxc/dyn_array_idx/read/workgroup.wgsl.expected.hlsl",
      "new_id": "0c590e46bc5695766c3f09458b7aaa426394dd05",
      "new_mode": 33188,
      "new_path": "test/bug/fxc/dyn_array_idx/read/workgroup.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "1098254f3a4d791ed18d29d3e3758a8d95f9973c",
      "old_mode": 33188,
      "old_path": "test/bug/fxc/dyn_array_idx/write/workgroup.wgsl.expected.hlsl",
      "new_id": "5080be8b9502037f26fab870b3a09f97a653d6a5",
      "new_mode": 33188,
      "new_path": "test/bug/fxc/dyn_array_idx/write/workgroup.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "7b10259dba97fb191b8854e336621e4e44a3414f",
      "old_mode": 33188,
      "old_path": "test/bug/fxc/vector_assignment_in_loop/loop_call_with_loop.wgsl.expected.hlsl",
      "new_id": "00000e97cdfb042d5da726163086ef31ca7cd39e",
      "new_mode": 33188,
      "new_path": "test/bug/fxc/vector_assignment_in_loop/loop_call_with_loop.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "64b4feaaa8f5d212e3b9641b215ddc320fe4284a",
      "old_mode": 33188,
      "old_path": "test/bug/fxc/vector_assignment_in_loop/loop_call_with_no_loop.wgsl.expected.hlsl",
      "new_id": "cc096ac700254f5b02fb1476385280593a0c899b",
      "new_mode": 33188,
      "new_path": "test/bug/fxc/vector_assignment_in_loop/loop_call_with_no_loop.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "158e0e15b4d04fa65e459c23e12a1990471ee703",
      "old_mode": 33188,
      "old_path": "test/bug/fxc/vector_assignment_in_loop/loop_types_all.wgsl.expected.hlsl",
      "new_id": "13dd87cfd244bf10a1154360244df51f60807127",
      "new_mode": 33188,
      "new_path": "test/bug/fxc/vector_assignment_in_loop/loop_types_all.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "6cabffe8ba76cfcaf8c25b6ace2b3a3923b77418",
      "old_mode": 33188,
      "old_path": "test/bug/fxc/vector_assignment_in_loop/loop_types_repeated.wgsl.expected.hlsl",
      "new_id": "0c3db0779010fe1f56db4cfae4d83a4a51d59528",
      "new_mode": 33188,
      "new_path": "test/bug/fxc/vector_assignment_in_loop/loop_types_repeated.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "1461d03c1a12138413bbdc322ab2a88e0496276f",
      "old_mode": 33188,
      "old_path": "test/bug/fxc/vector_assignment_in_loop/loop_types_some.wgsl.expected.hlsl",
      "new_id": "0740864c6ca123be4c9c0f403c39d446bb6685a1",
      "new_mode": 33188,
      "new_path": "test/bug/fxc/vector_assignment_in_loop/loop_types_some.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "56911a4b81de25288fbafaef05368cf040792834",
      "old_mode": 33188,
      "old_path": "test/bug/tint/1064.wgsl.expected.hlsl",
      "new_id": "ed00540a4b35a411ae7bd136e2239892ce475cf5",
      "new_mode": 33188,
      "new_path": "test/bug/tint/1064.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "056c225261af70fbe194b0c3936d3c20495332a2",
      "old_mode": 33188,
      "old_path": "test/bug/tint/1081.wgsl.expected.hlsl",
      "new_id": "1aba907086b9f8c2da80b2b89c13f4251d471a03",
      "new_mode": 33188,
      "new_path": "test/bug/tint/1081.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "12d88657724ce35c957987aa09d6d9628fd96876",
      "old_mode": 33188,
      "old_path": "test/bug/tint/1121.wgsl.expected.hlsl",
      "new_id": "a5ab12d742d5a5c5c5c688797bb7f853c5f3f417",
      "new_mode": 33188,
      "new_path": "test/bug/tint/1121.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "ea467eae49d0dd439c12cf48854d5871555b4b70",
      "old_mode": 33188,
      "old_path": "test/bug/tint/221.wgsl.expected.hlsl",
      "new_id": "04406bba529c638bc81ebc57d8291ce6afd18a1f",
      "new_mode": 33188,
      "new_path": "test/bug/tint/221.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "03518c791aa775dcdaf471cc2d9b9ead5ddb5614",
      "old_mode": 33188,
      "old_path": "test/bug/tint/534.wgsl.expected.hlsl",
      "new_id": "0bee2d802c77d0a2fa53b73fe3018675b99670cd",
      "new_mode": 33188,
      "new_path": "test/bug/tint/534.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "0b1434e1fe15b2e25e47c33f358e7fae4465abcb",
      "old_mode": 33188,
      "old_path": "test/bug/tint/744.wgsl.expected.hlsl",
      "new_id": "7870d265852aaae4080c03da3ea95e3b722a2eae",
      "new_mode": 33188,
      "new_path": "test/bug/tint/744.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "3fef834a3c95dc5d444cd94439f86f62f5c0bc5d",
      "old_mode": 33188,
      "old_path": "test/bug/tint/749.spvasm.expected.hlsl",
      "new_id": "0b5ecf85ef4431b3de875151a33d9f73e6f52847",
      "new_mode": 33188,
      "new_path": "test/bug/tint/749.spvasm.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "8be66c6ede51356e28a2690e9d310c66b44d56f4",
      "old_mode": 33188,
      "old_path": "test/bug/tint/757.wgsl.expected.hlsl",
      "new_id": "d144aff8e933f4b9217b436d7b8b55a8c2c11461",
      "new_mode": 33188,
      "new_path": "test/bug/tint/757.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "db19a1858695158605ae00bbff0bf7a1f3849deb",
      "old_mode": 33188,
      "old_path": "test/bug/tint/870.spvasm.expected.hlsl",
      "new_id": "69b21b914ed72441195e4ae77242378439c12bff",
      "new_mode": 33188,
      "new_path": "test/bug/tint/870.spvasm.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "b4add28c644248ac0dff46cddf08a664f8f68d7a",
      "old_mode": 33188,
      "old_path": "test/bug/tint/914.wgsl.expected.hlsl",
      "new_id": "4c2e060457cdd19d922e5c5c9c0bc7d64dec2a59",
      "new_mode": 33188,
      "new_path": "test/bug/tint/914.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "2325c62f5ecbc4323f3c1e78fc614c7b64aa5013",
      "old_mode": 33188,
      "old_path": "test/bug/tint/942.wgsl.expected.hlsl",
      "new_id": "7c38bdcd3dd664b2a727639beb652e6d8f15b7e7",
      "new_mode": 33188,
      "new_path": "test/bug/tint/942.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "38e87d39b8fd879cfa2a70544e4d7ff444071d9e",
      "old_mode": 33188,
      "old_path": "test/bug/tint/943.spvasm.expected.hlsl",
      "new_id": "bdf9b12cbf1faf8b506534cc2908ecc09cdc4be8",
      "new_mode": 33188,
      "new_path": "test/bug/tint/943.spvasm.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "869f3e3ea68d3a3d89e3931c82aa0483555ab4b3",
      "old_mode": 33188,
      "old_path": "test/bug/tint/948.wgsl.expected.hlsl",
      "new_id": "5a253ad26772e4a8244f48521bc875d6e749dcb1",
      "new_mode": 33188,
      "new_path": "test/bug/tint/948.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "e875c0dcd940d64a410a73a7ceebc0f18d7f69a1",
      "old_mode": 33188,
      "old_path": "test/bug/tint/949.wgsl.expected.hlsl",
      "new_id": "4869166be86722e20cc9b34939caefca7f977c81",
      "new_mode": 33188,
      "new_path": "test/bug/tint/949.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "80751f801de23ffbf7270f5e03a7138b9373b2e1",
      "old_mode": 33188,
      "old_path": "test/bug/tint/990.wgsl.expected.hlsl",
      "new_id": "49ec198f30a5f81ff0b80732c3a1c069455e57e8",
      "new_mode": 33188,
      "new_path": "test/bug/tint/990.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "f9ad3adefb4be1e92fd16ec82a9c75b720a173f0",
      "old_mode": 33188,
      "old_path": "test/layout/storage/mat2x2/stride/16.spvasm.expected.hlsl",
      "new_id": "18bd54dcf55d184cf5b30970539d4a33042272da",
      "new_mode": 33188,
      "new_path": "test/layout/storage/mat2x2/stride/16.spvasm.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "44b45fd593f9f4f083a6c705b2599053e3c5fd7c",
      "old_mode": 33188,
      "old_path": "test/loops/loop.wgsl.expected.hlsl",
      "new_id": "8eed4b2b9c51ce9c4c2aaeb11a275f792399cde1",
      "new_mode": 33188,
      "new_path": "test/loops/loop.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "0d57d1fc7f28003be6f52b85cb205929e62df926",
      "old_mode": 33188,
      "old_path": "test/loops/loop_with_continuing.wgsl.expected.hlsl",
      "new_id": "440ef883641eab1e298b23fc3ed97599bcd3c97b",
      "new_mode": 33188,
      "new_path": "test/loops/loop_with_continuing.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "793339e9b95fffd7f780699bee4f552a03638f22",
      "old_mode": 33188,
      "old_path": "test/loops/nested_loops.wgsl.expected.hlsl",
      "new_id": "5278d0025615b8aba8ec5d63947b5d40070d6862",
      "new_mode": 33188,
      "new_path": "test/loops/nested_loops.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "9ccdf024470ba851d7655dbebe393ed44c171cc5",
      "old_mode": 33188,
      "old_path": "test/loops/nested_loops_with_continuing.wgsl.expected.hlsl",
      "new_id": "8d795a846d7bdcf179c85a064995b150fc198f1a",
      "new_mode": 33188,
      "new_path": "test/loops/nested_loops_with_continuing.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "a19fa71a12872ac169d0fceead6a5a6df17b23ba",
      "old_mode": 33188,
      "old_path": "test/samples/compute_boids.wgsl.expected.hlsl",
      "new_id": "b94e5e76b4073f2262ecf782ee5925fcf1cf4d9a",
      "new_mode": 33188,
      "new_path": "test/samples/compute_boids.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "f215f4bbce685519a185f51646fb02ebe3a534da",
      "old_mode": 33188,
      "old_path": "test/statements/for/basic.wgsl.expected.hlsl",
      "new_id": "223650392b37a8f094c2a82f1d5a4231584f4c3f",
      "new_mode": 33188,
      "new_path": "test/statements/for/basic.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "b48727f4e727cc24d8042fd62cc9721ed6dc8266",
      "old_mode": 33188,
      "old_path": "test/statements/for/complex.wgsl.expected.hlsl",
      "new_id": "ebc9720860fb8310b8e8c939f1441e8759a2eb20",
      "new_mode": 33188,
      "new_path": "test/statements/for/complex.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "e4456e05cd924b33faeb20f562e94ed77da59a5d",
      "old_mode": 33188,
      "old_path": "test/statements/for/condition.wgsl.expected.hlsl",
      "new_id": "96122e55e1bb3936ea394ebe29e10154656dbb30",
      "new_mode": 33188,
      "new_path": "test/statements/for/condition.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "b3ec736bc6bf2e94ea02eafaf633c73ab94b7d57",
      "old_mode": 33188,
      "old_path": "test/statements/for/continuing.wgsl.expected.hlsl",
      "new_id": "3e2e84783eb23283a16aea96f6d39d295dd7107f",
      "new_mode": 33188,
      "new_path": "test/statements/for/continuing.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "cd85e1a55f5dadea684a7d13603bd1d19be71f24",
      "old_mode": 33188,
      "old_path": "test/statements/for/empty.wgsl.expected.hlsl",
      "new_id": "fe6edeee68e65718c1b024db3a9ef1c0154fe583",
      "new_mode": 33188,
      "new_path": "test/statements/for/empty.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "e614afdf4bcb7905060a8a81f7db0c818aa2fbca",
      "old_mode": 33188,
      "old_path": "test/statements/for/initializer.wgsl.expected.hlsl",
      "new_id": "57b4e10aed58d04b47549ceeb462f36b501e2551",
      "new_mode": 33188,
      "new_path": "test/statements/for/initializer.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "143b1e363ed9ef126bb346ca8041a5b8c2eefa39",
      "old_mode": 33188,
      "old_path": "test/statements/for/scoping.wgsl.expected.hlsl",
      "new_id": "65cfcf79947b9cbf046f2811c9fc5af40f26ef19",
      "new_mode": 33188,
      "new_path": "test/statements/for/scoping.wgsl.expected.hlsl"
    },
    {
      "type": "modify",
      "old_id": "95222e99ed8529302ca765ce6d9ef841c3402a61",
      "old_mode": 33188,
      "old_path": "test/var/initialization/workgroup/array.wgsl.expected.hlsl",
      "new_id": "21c4cabbee43a9452bcb613bdf9b3f0f9873d9ba",
      "new_mode": 33188,
      "new_path": "test/var/initialization/workgroup/array.wgsl.expected.hlsl"
    }
  ]
}