tree c1cbddaf159dc04ad1f8a7efdc34cfa795ec0d8a
parent 2e6a1bb39680baa5e0483d467abefe0009dc1589
author Ben Clayton <bclayton@google.com> 1612198484 +0000
committer Commit Bot service account <commit-bot@chromium.org> 1612198484 +0000

EmitVertexPointSize: Don't share expressions between functions

AST nodes are syntax tree nodes, not semantic tree nodes.

The pointsize IdentifierExpression was being created once and used in multiple functions.
The type determiner assumes that expressions are not shared between functions (otherwise the same IdentifierExpression may end up resolving to two different types / semantic nodes based on scope).

Bug: tint:469
Fixed: tint:468
Change-Id: I4c85d25ee3fd333d14739b519d5ee6cda767d52e
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/39880
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>