commit | 3cbb136b8ae125514670d4df8dcd9316a0e0cc67 | [log] [tgz] |
---|---|---|

author | Ben Clayton <bclayton@google.com> | Thu Jan 06 18:11:01 2022 +0000 |

committer | Tint LUCI CQ <tint-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 06 18:11:01 2022 +0000 |

tree | c51c4b608651c0c6b07f6dc7936026cbe5f95264 | |

parent | 294ce9394f4a8952abe9fb9b58b52f161a55dc24 [diff] |

Re-allow dynamic indexing of 'let' arrays and matrices Spec change: https://github.com/gpuweb/gpuweb/pull/2427 Reverses: tint:867 This reverts and fixes commits: b6fdcc54df6e012578e69550788e2b4b2b611c32 10442eff7db4271d53eed553795e655068488276 Added a bunch of end-to-end tests. Fixed: tint:1352 Change-Id: I34968243bbec1cab838c8ba50a6f027146bbfd06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/75401 Reviewed-by: David Neto <dneto@google.com> Reviewed-by: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>

- docs/origin-trial-changes.md[diff]
- src/BUILD.gn[diff]
- src/CMakeLists.txt[diff]
- src/reader/spirv/function_composite_test.cc[diff]
- src/resolver/array_accessor_test.cc[diff]
- src/resolver/resolver.cc[diff]
- src/sem/constant.h[diff]
- src/transform/var_for_dynamic_index.cc[Added - diff]
- src/transform/var_for_dynamic_index.h[Added - diff]
- src/transform/var_for_dynamic_index_test.cc[Added - diff]
- src/writer/spirv/builder.cc[diff]
- src/writer/spirv/builder_accessor_expression_test.cc[diff]
- test/BUILD.gn[diff]
- test/bug/tint/824.wgsl[diff]
- test/bug/tint/824.wgsl.expected.hlsl[diff]
- test/bug/tint/824.wgsl.expected.msl[diff]
- test/bug/tint/824.wgsl.expected.spvasm[diff]
- test/bug/tint/824.wgsl.expected.wgsl[diff]
- test/bug/tint/825.wgsl[diff]
- test/bug/tint/825.wgsl.expected.hlsl[diff]
- test/bug/tint/825.wgsl.expected.msl[diff]
- test/bug/tint/825.wgsl.expected.spvasm[diff]
- test/bug/tint/825.wgsl.expected.wgsl[diff]
- test/expressions/index/let/let/literal/array.wgsl[Added - diff]
- test/expressions/index/let/let/literal/array.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/let/literal/array.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/let/literal/array.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/let/literal/array.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/let/literal/matrix.wgsl[Added - diff]
- test/expressions/index/let/let/literal/matrix.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/let/literal/matrix.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/let/literal/matrix.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/let/literal/matrix.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/let/literal/vector.wgsl[Added - diff]
- test/expressions/index/let/let/literal/vector.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/let/literal/vector.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/let/literal/vector.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/let/literal/vector.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/let/param/array.wgsl[Added - diff]
- test/expressions/index/let/let/param/array.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/let/param/array.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/let/param/array.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/let/param/array.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/let/param/matrix.wgsl[Added - diff]
- test/expressions/index/let/let/param/matrix.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/let/param/matrix.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/let/param/matrix.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/let/param/matrix.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/let/param/vector.wgsl[Added - diff]
- test/expressions/index/let/let/param/vector.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/let/param/vector.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/let/param/vector.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/let/param/vector.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/literal/array.wgsl[Added - diff]
- test/expressions/index/let/literal/array.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/literal/array.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/literal/array.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/literal/array.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/literal/matrix.wgsl[Added - diff]
- test/expressions/index/let/literal/matrix.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/literal/matrix.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/literal/matrix.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/literal/matrix.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/literal/vector.wgsl[Added - diff]
- test/expressions/index/let/literal/vector.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/literal/vector.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/literal/vector.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/literal/vector.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/param/array.wgsl[Added - diff]
- test/expressions/index/let/param/array.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/param/array.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/param/array.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/param/array.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/param/matrix.wgsl[Added - diff]
- test/expressions/index/let/param/matrix.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/param/matrix.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/param/matrix.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/param/matrix.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/param/vector.wgsl[Added - diff]
- test/expressions/index/let/param/vector.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/param/vector.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/param/vector.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/param/vector.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/var/literal/array.wgsl[Added - diff]
- test/expressions/index/let/var/literal/array.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/var/literal/array.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/var/literal/array.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/var/literal/array.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/var/literal/matrix.wgsl[Added - diff]
- test/expressions/index/let/var/literal/matrix.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/var/literal/matrix.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/var/literal/matrix.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/var/literal/matrix.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/let/var/literal/vector.wgsl[Added - diff]
- test/expressions/index/let/var/literal/vector.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/let/var/literal/vector.wgsl.expected.msl[Added - diff]
- test/expressions/index/let/var/literal/vector.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/let/var/literal/vector.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/var/let/literal/array.wgsl[Added - diff]
- test/expressions/index/var/let/literal/array.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/var/let/literal/array.wgsl.expected.msl[Added - diff]
- test/expressions/index/var/let/literal/array.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/var/let/literal/array.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/var/let/literal/matrix.wgsl[Added - diff]
- test/expressions/index/var/let/literal/matrix.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/var/let/literal/matrix.wgsl.expected.msl[Added - diff]
- test/expressions/index/var/let/literal/matrix.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/var/let/literal/matrix.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/var/let/literal/vector.wgsl[Added - diff]
- test/expressions/index/var/let/literal/vector.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/var/let/literal/vector.wgsl.expected.msl[Added - diff]
- test/expressions/index/var/let/literal/vector.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/var/let/literal/vector.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/var/let/param/array.wgsl[Added - diff]
- test/expressions/index/var/let/param/array.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/var/let/param/array.wgsl.expected.msl[Added - diff]
- test/expressions/index/var/let/param/array.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/var/let/param/array.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/var/let/param/matrix.wgsl[Added - diff]
- test/expressions/index/var/let/param/matrix.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/var/let/param/matrix.wgsl.expected.msl[Added - diff]
- test/expressions/index/var/let/param/matrix.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/var/let/param/matrix.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/var/let/param/vector.wgsl[Added - diff]
- test/expressions/index/var/let/param/vector.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/var/let/param/vector.wgsl.expected.msl[Added - diff]
- test/expressions/index/var/let/param/vector.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/var/let/param/vector.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/var/literal/array.wgsl[Added - diff]
- test/expressions/index/var/literal/array.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/var/literal/array.wgsl.expected.msl[Added - diff]
- test/expressions/index/var/literal/array.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/var/literal/array.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/var/literal/matrix.wgsl[Added - diff]
- test/expressions/index/var/literal/matrix.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/var/literal/matrix.wgsl.expected.msl[Added - diff]
- test/expressions/index/var/literal/matrix.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/var/literal/matrix.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/var/literal/vector.wgsl[Added - diff]
- test/expressions/index/var/literal/vector.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/var/literal/vector.wgsl.expected.msl[Added - diff]
- test/expressions/index/var/literal/vector.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/var/literal/vector.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/var/param/array.wgsl[Added - diff]
- test/expressions/index/var/param/array.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/var/param/array.wgsl.expected.msl[Added - diff]
- test/expressions/index/var/param/array.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/var/param/array.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/var/param/matrix.wgsl[Added - diff]
- test/expressions/index/var/param/matrix.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/var/param/matrix.wgsl.expected.msl[Added - diff]
- test/expressions/index/var/param/matrix.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/var/param/matrix.wgsl.expected.wgsl[Added - diff]
- test/expressions/index/var/param/vector.wgsl[Added - diff]
- test/expressions/index/var/param/vector.wgsl.expected.hlsl[Added - diff]
- test/expressions/index/var/param/vector.wgsl.expected.msl[Added - diff]
- test/expressions/index/var/param/vector.wgsl.expected.spvasm[Added - diff]
- test/expressions/index/var/param/vector.wgsl.expected.wgsl[Added - diff]
- test/samples/triangle.wgsl[diff]
- test/samples/triangle.wgsl.expected.hlsl[diff]
- test/samples/triangle.wgsl.expected.msl[diff]
- test/samples/triangle.wgsl.expected.spvasm[diff]
- test/samples/triangle.wgsl.expected.wgsl[diff]
- test/unittest/reader/spirv/SpvParserTest_VectorExtractDynamic_UnsignedIndex.spvasm[diff]

164 files changed

tree: c51c4b608651c0c6b07f6dc7936026cbe5f95264

- .vscode/
- build_overrides/
- docs/
- fuzzers/
- include/
- infra/
- kokoro/
- samples/
- src/
- test/
- third_party/
- tools/
- .clang-format
- .gitignore
- .gn
- AUTHORS
- BUILD.gn
- CMakeLists.txt
- CMakeSettings.json
- CODE_OF_CONDUCT.md
- CONTRIBUTING.md
- CPPLINT.cfg
- DEPS
- Doxyfile
- LICENSE
- OWNERS
- PRESUBMIT.py
- README.md
- standalone.gclient
- tint_overrides_with_defaults.gni

README.md

Tint is a compiler for the WebGPU Shader Language (WGSL).

This is not an officially supported Google product.

- Git
- CMake (3.10.2 or later)
- Ninja (or other build tool)
- Python, for fetching dependencies
- depot_tools in your path

`TINT_BUILD_SPV_READER`

: enable the SPIR-V input reader (off by default)`TINT_BUILD_WGSL_READER`

: enable the WGSL input reader (on by default)`TINT_BUILD_SPV_WRITER`

: enable the SPIR-V output writer (on by default)`TINT_BUILD_WGSL_WRITER`

: enable the WGSL output writer (on by default)`TINT_BUILD_FUZZERS`

: enable building fuzzzers (off by default)

Tint uses Chromium dependency management so you need to install depot_tools and add it to your PATH.

# Clone the repo as "tint" git clone https://dawn.googlesource.com/tint tint cd tint # Bootstrap the gclient configuration cp standalone.gclient .gclient # Fetch external dependencies and toolchains with gclient gclient sync

mkdir -p out/Debug cd out/Debug cmake -GNinja ../.. ninja # or autoninja

mkdir -p out/Debug cd out/Debug cmake ../.. make # -j N for N-way parallel build

mkdir -p out/Debug gn gen out/Debug autoninja -C out/Debug

If you are attempting fuzz, using `TINT_BUILD_FUZZERS=ON`

, the version of llvm in the XCode SDK does not have the needed libfuzzer functionality included.

The build error that you will see from using the XCode SDK will look something like this:

ld: file not found:/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/11.0.0/lib/darwin/libclang_rt.fuzzer_osx.a

The solution to this problem is to use a full version llvm, like what you would get via homebrew, `brew install llvm`

, and use something like `CC=<path to full clang> cmake ..`

to setup a build using that toolchain.

The gn based work flow uses the Chromium toolchain for building in anticipation of integration of Tint into Chromium based projects. This toolchain has additional plugins for checking for style issues, which are marked with [chromium-style] in log messages. This means that this toolchain is more strict then the default clang toolchain.

In the future we will have a CQ that will build this work flow and flag issues automatically. Until that is in place, to avoid causing breakages you can run the [chromium-style] checks using the CMake based work flows. This requires setting `CC`

to the version of clang checked out by `gclient sync`

and setting the `TINT_CHECK_CHROMIUM_STYLE`

to `ON`

.

mkdir -p out/style cd out/style cmake ../.. CC=../../third_party/llvm-build/Release+Asserts/bin/clang cmake -DTINT_CHECK_CHROMIUM_STYLE=ON ../../ # add -GNinja for ninja builds

Please file any issues or feature requests at https://bugs.chromium.org/p/tint/issues/entry

Please see the CONTRIBUTING and CODE_OF_CONDUCT files on how to contribute to Tint.

Tint has a process for supporting experimental extensions.