)]}' { "commit": "4f10a256d5328cafe45962ddf9759d540ec74a1d", "tree": "ab98a68086a0a261f84799d2e32558668cfa0d41", "parents": [ "b572d53bf26c445798bdf2732d7519af0915a801" ], "author": { "name": "David Neto", "email": "dneto@google.com", "time": "Mon Apr 20 21:06:43 2020 +0000" }, "committer": { "name": "David Neto", "email": "dneto@google.com", "time": "Mon Apr 20 21:06:43 2020 +0000" }, "message": "[spirv-reader] Fix OpSDiv operand and result signedness\n\n(I expect that) the WGSL signed division operator expects both operands\nto be signed and the result will also be signed.\n\nWhen the operands of a SPIR-V OpSDiv is unsigned, then wrap\nthe operand in an as-cast to the corresponding signed type.\n\nWhen the result type of a SPIR-V OpSDiv instruction is unsigned,\nwe have to wrap the generated WGSL operator with an as-cast to\nthat unsigned type.\n\nThis first CL addresses OpSDiv. We\u0027ll address other operations in future CLs.\n\nBug: tint:3\nChange-Id: If3849ceb44b21db87c1efd2c6a2cd63c6d648c88\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/19800\nReviewed-by: dan sinclair \u003cdsinclair@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "0a17fd5b82f134241082bef1e516fb213e47f596", "old_mode": 33188, "old_path": "src/reader/spirv/function.cc", "new_id": "3d42885e7e8c80b20c7ca86108d6fb636250c6d7", "new_mode": 33188, "new_path": "src/reader/spirv/function.cc" }, { "type": "modify", "old_id": "a0ccf6e2b9724806cf74e6a16c02d99ea6e42706", "old_mode": 33188, "old_path": "src/reader/spirv/function_arithmetic_test.cc", "new_id": "31ac7f0250989c870d38feb289cf2f567874d0f8", "new_mode": 33188, "new_path": "src/reader/spirv/function_arithmetic_test.cc" }, { "type": "modify", "old_id": "795dc7d73bc804135b9858f97a17d000dd9e265f", "old_mode": 33188, "old_path": "src/reader/spirv/parser_impl.cc", "new_id": "3139cb9fc867864e6af4e3270e4c8eb66e100d39", "new_mode": 33188, "new_path": "src/reader/spirv/parser_impl.cc" }, { "type": "modify", "old_id": "91c22e01eb1a5fa3169a7f646ebe36034ea3011b", "old_mode": 33188, "old_path": "src/reader/spirv/parser_impl.h", "new_id": "2412398a356dc8e2b597adc8bcd7e2cef400480e", "new_mode": 33188, "new_path": "src/reader/spirv/parser_impl.h" } ] }