tree a6f745d96ff6aae0e176753f6f6415051fdddf1e
parent 40e3ccda33a1baeb5aa78dc32e11a73b2ec57781
author Ben Clayton <bclayton@google.com> 1605728400 +0000
committer Commit Bot service account <commit-bot@chromium.org> 1605728400 +0000

src/reader tests: Have parse() return a unique_ptr

The reason being that some tests called parse() twice, which will silently destruct the first parser.
Once the `Module` owns the AST nodes, the second call will end up deleting all the AST nodes. Tests would then perform use-after-free for the AST nodes belonging to the first parser / module.
There's no reason why the unique_ptr can't be returned, which is cleaner overall.

Bug: tint:335
Change-Id: I7ff2e9777a7ebeb76702f806294fe4c2c49bd7c9
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/33241
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>