commit 6e7d24d36a73aef4bc64a2855cf3a1b0834d6688
author Ben Clayton <bclayton@google.com> Wed Jun 09 14:32:14 2021 +0000
committer Ben Clayton <bclayton@google.com> Wed Jun 09 14:32:14 2021 +0000
tree b72bf8332cb677cc74fef50376914b7fb422d500
parent 3b267173776b333540da587867521b97cdf9e0cd

Add ProgramBuilder::Alias()

Combines the calls to ty.alias() and AST().AddConstructedType()

Change-Id: I84eaf6275d37141cf8973db7e04d25d9cb9c6351
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/53801
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>

src/resolver/storage_class_validation_test.cc

diff --git a/src/resolver/storage_class_validation_test.cc b/src/resolver/storage_class_validation_test.cc
index 29c8945..033e7f6 100644
--- a/src/resolver/storage_class_validation_test.cc
+++ b/src/resolver/storage_class_validation_test.cc
@@ -86,8 +86,7 @@
 TEST_F(ResolverStorageClassValidationTest, StorageBufferBoolAlias) {
   // type a = bool;
   // var<storage, read> g : a;
-  auto* a = ty.alias("a", ty.bool_());
-  AST().AddConstructedType(a);
+  auto* a = Alias("a", ty.bool_());
   Global(Source{{56, 78}}, "g", a, ast::StorageClass::kStorage,
          ast::DecorationList{
              create<ast::BindingDecoration>(0),
@@ -141,10 +140,8 @@
   // var<storage, read> g : a1;
   auto* s = Structure("S", {Member(Source{{12, 34}}, "x", ty.i32())},
                       {create<ast::StructBlockDecoration>()});
-  auto* a1 = ty.alias("a1", s);
-  AST().AddConstructedType(a1);
-  auto* a2 = ty.alias("a2", a1);
-  AST().AddConstructedType(a2);
+  auto* a1 = Alias("a1", s);
+  auto* a2 = Alias("a2", a1);
   Global(Source{{56, 78}}, "g", a2, ast::StorageClass::kStorage,
          ast::Access::kRead,
          ast::DecorationList{
@@ -208,8 +205,7 @@
 TEST_F(ResolverStorageClassValidationTest, UniformBufferBoolAlias) {
   // type a = bool;
   // var<uniform> g : a;
-  auto* a = ty.alias("a", ty.bool_());
-  AST().AddConstructedType(a);
+  auto* a = Alias("a", ty.bool_());
   Global(Source{{56, 78}}, "g", a, ast::StorageClass::kUniform,
          ast::DecorationList{
              create<ast::BindingDecoration>(0),
@@ -261,8 +257,7 @@
   // var<uniform> g : a1;
   auto* s = Structure("S", {Member(Source{{12, 34}}, "x", ty.i32())},
                       {create<ast::StructBlockDecoration>()});
-  auto* a1 = ty.alias("a1", s);
-  AST().AddConstructedType(a1);
+  auto* a1 = Alias("a1", s);
   Global(Source{{56, 78}}, "g", a1, ast::StorageClass::kUniform,
          ast::DecorationList{
              create<ast::BindingDecoration>(0),