)]}' { "commit": "933d44a2c8b9148c7a052b7555765f4a115f80aa", "tree": "6cfdfc88f50aa0490451a3b0aac80b2457333133", "parents": [ "8f42be3f60bb5284f94c77383d08802225529090" ], "author": { "name": "Ben Clayton", "email": "bclayton@google.com", "time": "Wed Apr 07 17:29:31 2021 +0000" }, "committer": { "name": "Commit Bot service account", "email": "commit-bot@chromium.org", "time": "Wed Apr 07 17:29:31 2021 +0000" }, "message": "transform/hlsl: Hoist structure constructors to new var\n\nHLSL has some pecular rules around structure constructors.\n`S s \u003d S(1,2,3)` is not valid, but `S s \u003d {1,2,3}` is.\n\nThis matches the quirkiness with array initializers, so adjust the array\nhoisting logic to also support structures.\n\nFixed: tint:702\nChange-Id: Ifdcafd98292715ae2482f72ec06c87842176d270\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/46875\nCommit-Queue: Ben Clayton \u003cbclayton@chromium.org\u003e\nReviewed-by: James Price \u003cjrprice@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "918d6e3ddb493e3cf97b3a78df712f79e5f179e5", "old_mode": 33188, "old_path": "src/transform/hlsl.cc", "new_id": "9db68e074583986e773c917d2c8c47fdd093ee9c", "new_mode": 33188, "new_path": "src/transform/hlsl.cc" }, { "type": "modify", "old_id": "df903a75dd8377a3663c0a32dbc6dc7e0a0d3ef4", "old_mode": 33188, "old_path": "src/transform/hlsl.h", "new_id": "ff7978f6f10ba353712786a6f336663f33d7c616", "new_mode": 33188, "new_path": "src/transform/hlsl.h" }, { "type": "modify", "old_id": "4ce2259350ef673b021044d978d67cb60e7d8c6c", "old_mode": 33188, "old_path": "src/transform/hlsl_test.cc", "new_id": "27779bde4233e0b94f200938aaa0b929564373cd", "new_mode": 33188, "new_path": "src/transform/hlsl_test.cc" }, { "type": "modify", "old_id": "90ffaf332dcdee2769f64470214a9e8ede24b156", "old_mode": 33188, "old_path": "src/writer/hlsl/generator_impl.cc", "new_id": "4f82f6c8204ca3e401a75860a03e4c3357e692ef", "new_mode": 33188, "new_path": "src/writer/hlsl/generator_impl.cc" }, { "type": "modify", "old_id": "2acbedbb68a35123d72835918c6cd38c15c48d45", "old_mode": 33188, "old_path": "src/writer/hlsl/generator_impl_constructor_test.cc", "new_id": "2bee83b1ccab05d86152ed189412fe3ee3b936bb", "new_mode": 33188, "new_path": "src/writer/hlsl/generator_impl_constructor_test.cc" }, { "type": "modify", "old_id": "f9b1d6adc94a813cd2121ca3ca836f6ef97ebf10", "old_mode": 33188, "old_path": "src/writer/hlsl/generator_impl_function_test.cc", "new_id": "7d702777a96d14a110881bb34c501f63e88811db", "new_mode": 33188, "new_path": "src/writer/hlsl/generator_impl_function_test.cc" }, { "type": "modify", "old_id": "53b7cd1d73e36b1dd2f356065a5d3ae2d22927f1", "old_mode": 33188, "old_path": "src/writer/hlsl/generator_impl_sanitizer_test.cc", "new_id": "8766b91181b5d66468b33470228836b0278cbde4", "new_mode": 33188, "new_path": "src/writer/hlsl/generator_impl_sanitizer_test.cc" } ] }