)]}' { "commit": "ae8c65620e9fd4be97676d61b0fd14d8b9641174", "tree": "3524a37de46c2cef2ac79a234d8568b5e5381402", "parents": [ "51e55b244edf67384d4d426892b146de4449ae68" ], "author": { "name": "James Price", "email": "jrprice@google.com", "time": "Wed Jan 19 15:55:56 2022 +0000" }, "committer": { "name": "James Price", "email": "jrprice@google.com", "time": "Wed Jan 19 15:55:56 2022 +0000" }, "message": "glsl: Wrap non-struct buffer types in structs\n\nUse the AddSpirvBlockDecoration transform to do this.\n\nAdd expected results for all of the new E2E tests. The arrayLength()\ntests all fail as this is not yet implemented for the GLSL\nbackend. The other tests all pass except two that assign whole structs\nto buffers, which is also a pre-existing issue.\n\nBug: tint:1372\nChange-Id: I230197b43a5561e619866419d642ffc1ed085aac\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/76164\nReviewed-by: Ben Clayton \u003cbclayton@google.com\u003e\nReviewed-by: Stephen White \u003csenorblanco@chromium.org\u003e\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "100023465d06c8ba1f4e6f139d127b64a806965e", "old_mode": 33188, "old_path": "src/transform/glsl.cc", "new_id": "4f056b8ed7d24cb2ecf33ffd893a54c2baa4fc97", "new_mode": 33188, "new_path": "src/transform/glsl.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "f1f3394e807a3c3edd1df35642b5dd09a583cd5c", "new_mode": 33188, "new_path": "test/buffer/storage/types/array.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "3f381913a808044e2fd35c4ee82a23b9b9748c67", "new_mode": 33188, "new_path": "test/buffer/storage/types/f32.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "c952e58daf035162b3908070a70032d1214d06ac", "new_mode": 33188, "new_path": "test/buffer/storage/types/i32.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "f0cab26b7355b331e3953df9dc05a1f9b0b97328", "new_mode": 33188, "new_path": "test/buffer/storage/types/mat2x2.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "51ebbdf9b923c7a32c5a77cff96853406f76386a", "new_mode": 33188, "new_path": "test/buffer/storage/types/mat2x3.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "3d2d78a07fb2ff078acc70cfc25465edcf5f3977", "new_mode": 33188, "new_path": "test/buffer/storage/types/mat3x2.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "c90a42ae76a44305364018358c267beed7b2aaaf", "new_mode": 33188, "new_path": "test/buffer/storage/types/mat4x4.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "bc7c8c6c792208dbf5ea803a6bf1351f272d7871", "new_mode": 33188, "new_path": "test/buffer/storage/types/runtime_array.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "9c7878ab3e886e3e1d75bbb4ea5c9021586f7678", "new_mode": 33188, "new_path": "test/buffer/storage/types/struct.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "f0d0db6cfd3c7d5ec32f6721be45cc7815b6b250", "new_mode": 33188, "new_path": "test/buffer/storage/types/u32.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "625604790919b200e8c2a8b07284533224e37ee5", "new_mode": 33188, "new_path": "test/buffer/storage/types/vec2.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "f00c6371d99a725124f205b5e364dbee5044969a", "new_mode": 33188, "new_path": "test/buffer/storage/types/vec3.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "95e5e9fb3765871cc0e36859d2092da78dc54abc", "new_mode": 33188, "new_path": "test/buffer/storage/types/vec4.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "11ff5ceca25545e3706dbb470eb4de860c0961c7", "new_mode": 33188, "new_path": "test/buffer/uniform/types/array.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "caa6a44e1338c105bf93530745468beb037fcb83", "new_mode": 33188, "new_path": "test/buffer/uniform/types/f32.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "719812bfb9982424ad7a3e67b34a5dda592e0f22", "new_mode": 33188, "new_path": "test/buffer/uniform/types/i32.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "1104d7dc9b8aa716cc91e1b00a95bbd5a3340796", "new_mode": 33188, "new_path": "test/buffer/uniform/types/mat2x2.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "b61c56ed6eb39863bf383d278206893c39fc8083", "new_mode": 33188, "new_path": "test/buffer/uniform/types/mat2x3.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "58d076b90dc54180e3de7b2ca34f3c3cf79009d9", "new_mode": 33188, "new_path": "test/buffer/uniform/types/mat3x2.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "3f5f108d39fdbfee554b1af2ac46457f84d93f68", "new_mode": 33188, "new_path": "test/buffer/uniform/types/mat4x4.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "ca402486a54b6af14c9c72096f0fc9e07105f960", "new_mode": 33188, "new_path": "test/buffer/uniform/types/struct.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "555ec426f83f31dd50c8c67cdc5b7b2b56de3143", "new_mode": 33188, "new_path": "test/buffer/uniform/types/u32.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "dd8b58dcbe42d245cdac94a84732cd281e053be3", "new_mode": 33188, "new_path": "test/buffer/uniform/types/vec2.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "3049309afec7ca435b6e8c157184c72adc17850b", "new_mode": 33188, "new_path": "test/buffer/uniform/types/vec3.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "077fe672e80dd285f6e4024fda3d9ae739f9878d", "new_mode": 33188, "new_path": "test/buffer/uniform/types/vec4.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "857791e6631a8dfd49ce476f21fbd6d21a6c6432", "new_mode": 33188, "new_path": "test/intrinsics/arrayLength/complex_via_let_no_struct.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "857791e6631a8dfd49ce476f21fbd6d21a6c6432", "new_mode": 33188, "new_path": "test/intrinsics/arrayLength/simple_no_struct.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "857791e6631a8dfd49ce476f21fbd6d21a6c6432", "new_mode": 33188, "new_path": "test/intrinsics/arrayLength/via_let_complex_no_struct.wgsl.expected.glsl" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "857791e6631a8dfd49ce476f21fbd6d21a6c6432", "new_mode": 33188, "new_path": "test/intrinsics/arrayLength/via_let_no_struct.wgsl.expected.glsl" } ] }