tree 20cf78b84ed2eb29f8f1c398a6efafbab137d14a
parent 2ec1393f31a492aa1ab7a73161c69c9c27d5b2fb
author Ben Clayton <bclayton@google.com> 1638553908 +0000
committer Ben Clayton <bclayton@google.com> 1638553908 +0000

writer/spirv: Fix trailing emission of OpReturn

writer::spirv::Function attempted to append a trailing OpReturn if the
function does not end with a terminating instruction. This wasn't
considering functions that have a non-void return type.

This has now been moved to spirv::Builder::GenerateFunction(),
where we can actually examine the function return type, and generate a
zero-expression to return if we need to.

Note: this was masked by WGSL validation that required all functions to
end with a return statement.

Bug: tint:1302
Change-Id: Iddfeda25a956622c318b8235dc6fc093a2a5c26d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71604
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: David Neto <dneto@google.com>