| commit | ca992196d255262099f534cac064a628b3aa0698 | [log] [tgz] |
|---|---|---|
| author | Antonio Maiorano <amaiorano@google.com> | Tue May 04 14:51:11 2021 +0000 |
| committer | Commit Bot service account <commit-bot@chromium.org> | Tue May 04 14:51:11 2021 +0000 |
| tree | 491a58920d40fc90dee1ec831b6aee75ecbecac3 | |
| parent | 1b898d56b4ab72c73f534fd52556f961f08c770c [diff] |
spirv reader: do not add duplicate constructed types My last CL (https://dawn-review.googlesource.com/c/tint/+/49542) made it so that AST nodes are re-created every type we resolve a spirv type id to a tint type. This creates duplicate nodes, most of which are cleaned up at the end of parsing. However, duplicates added as global constructed types are not handled, so this CL makes sure we do not add said duplicates. Bug: tint:769 Bug: tint:724 Change-Id: Ifab46aa3b843a841c4371659dbec64891fdabc9a Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/49760 Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Tint is a compiler for the WebGPU Shader Language (WGSL).
This is not an officially supported Google product.
TINT_BUILD_SPV_READER : enable the SPIR-V input reader (off by default)TINT_BUILD_WGSL_READER : enable the WGSL input reader (on by default)TINT_BUILD_SPV_WRITER : enable the SPIR-V output writer (on by default)TINT_BUILD_WGSL_WRITER : enable the WGSL output writer (on by default)TINT_BUILD_FUZZERS : enable building fuzzzers (off by default)Tint uses Chromium dependency management so you need to install depot_tools and add it to your PATH.
# Clone the repo as "tint" git clone https://dawn.googlesource.com/tint tint cd tint # Bootstrap the gclient configuration cp standalone.gclient .gclient # Fetch external dependencies and toolchains with gclient gclient sync
mkdir -p out/Debug cd out/Debug cmake -GNinja ../.. ninja # or autoninja
mkdir -p out/Debug cd out/Debug cmake ../.. make # -j N for N-way parallel build
mkdir -p out/Debug gn gen out/Debug autoninja -C out/Debug
If you are attempting fuzz, using TINT_BUILD_FUZZERS=ON, the version of llvm in the XCode SDK does not have the needed libfuzzer functionality included.
The build error that you will see from using the XCode SDK will look something like this:
ld: file not found:/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/11.0.0/lib/darwin/libclang_rt.fuzzer_osx.a
The solution to this problem is to use a full version llvm, like what you would get via homebrew, brew install llvm, and use something like CC=<path to full clang> cmake .. to setup a build using that toolchain.
The gn based work flow uses the Chromium toolchain for building in anticipation of integration of Tint into Chromium based projects. This toolchain has additional plugins for checking for style issues, which are marked with [chromium-style] in log messages. This means that this toolchain is more strict then the default clang toolchain.
In the future we will have a CQ that will build this work flow and flag issues automatically. Until that is in place, to avoid causing breakages you can run the [chromium-style] checks using the CMake based work flows. This requires setting CC to the version of clang checked out by gclient sync and setting the TINT_CHECK_CHROMIUM_STYLE to ON.
mkdir -p out/style cd out/style cmake ../.. CC=../../third_party/llvm-build/Release+Asserts/bin/clang cmake -DTINT_CHECK_CHROMIUM_STYLE=ON ../../ # add -GNinja for ninja builds
Please file any issues or feature requests at https://bugs.chromium.org/p/tint/issues/entry
Please see the CONTRIBUTING and CODE_OF_CONDUCT files on how to contribute to Tint.
Tint has a process for supporting experimental extensions.