commit d0f7381090ca569e62bc36f6a61cc0be6f22c940
author dan sinclair <dsinclair@chromium.org> Wed Jul 08 18:29:21 2020 +0000
committer David Neto <dneto@google.com> Wed Jul 08 18:29:21 2020 +0000
tree 1387204bb4e6d48c9823a48713ad2f56db9ea8e6
parent 723c5b4889c4e07e190297092a2683360d6b555b

[msl-writer] Better error message for missing statement and expression.

If the statement or expression being emitted is not implemented this
will now output the failed statement.

Bug: tint:7
Change-Id: I8a359abd369067540d503a1facbee018e91e8666
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/24523
Reviewed-by: David Neto <dneto@google.com>

src/writer/msl/generator_impl.cc

diff --git a/src/writer/msl/generator_impl.cc b/src/writer/msl/generator_impl.cc
index 0a2c72f..70b78fe 100644
--- a/src/writer/msl/generator_impl.cc
+++ b/src/writer/msl/generator_impl.cc
@@ -386,7 +386,7 @@
     return EmitUnaryOp(expr->AsUnaryOp());
   }
 
-  error_ = "unknown expression type";
+  error_ = "unknown expression type: " + expr->str();
   return false;
 }
 
@@ -648,7 +648,7 @@
     return EmitSwitch(stmt->AsSwitch());
   }
 
-  error_ = "unknown statement type";
+  error_ = "unknown statement type: " + stmt->str();
   return false;
 }