commit eb737c25db0c54fadac011162f50d4d4fa755368
author dan sinclair <dj2@everburning.com> Mon Jan 11 16:24:32 2021 +0000
committer dan sinclair <dsinclair@chromium.org> Mon Jan 11 16:24:32 2021 +0000
tree bba3c065cf874b64becb562848e48d0df0473928
parent e76a86a22c109aafbca69a50f1bc8ab9e4bed35a

Remove StructMember::name().

This CL removes the name accessor from the struct member. Usages have
been replaced with symbol usages.

Change-Id: Idd9c5b34f0b5503ffee84e0c82d69aa65b1df7ea
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/36820
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>

src/type_determiner.cc

diff --git a/src/type_determiner.cc b/src/type_determiner.cc
index 048120b..967f0e2 100644
--- a/src/type_determiner.cc
+++ b/src/type_determiner.cc
@@ -1048,17 +1048,18 @@
   ast::type::Type* ret = nullptr;
   if (auto* ty = data_type->As<ast::type::Struct>()) {
     auto* strct = ty->impl();
-    auto name = expr->member()->name();
+    auto symbol = expr->member()->symbol();
 
     for (auto* member : strct->members()) {
-      if (member->name() == name) {
+      if (member->symbol() == symbol) {
         ret = member->type();
         break;
       }
     }
 
     if (ret == nullptr) {
-      set_error(expr->source(), "struct member " + name + " not found");
+      set_error(expr->source(),
+                "struct member " + mod_->SymbolToName(symbol) + " not found");
       return false;
     }
 
@@ -1067,7 +1068,9 @@
       ret = mod_->create<ast::type::Pointer>(ret, ptr->storage_class());
     }
   } else if (auto* vec = data_type->As<ast::type::Vector>()) {
-    auto size = expr->member()->name().size();
+    // TODO(dsinclair): Swizzle, record into the identifier experesion
+
+    auto size = mod_->SymbolToName(expr->member()->symbol()).size();
     if (size == 1) {
       // A single element swizzle is just the type of the vector.
       ret = vec->type();