commit | 6fcefe4c256e9996fc37a034d14d6a18e9285436 | [log] [tgz] |
---|---|---|
author | Ben Clayton <bclayton@google.com> | Mon Apr 19 19:16:12 2021 +0000 |
committer | Commit Bot service account <commit-bot@chromium.org> | Mon Apr 19 19:16:12 2021 +0000 |
tree | 703f443c44cb79b76b919ff35f5a4d1daa09fad1 | |
parent | b8ea59149e26d0ffcf9e0834b9f9d71421ffbe83 [diff] |
Resolver: Check that every AST node is reached once AST nodes must not be shared. Diamonds in the AST will cause all sorts of exciting, non trivial bugs. All AST nodes must be reached by the Resolver. There are two common reasons why they may not be: (a) They were constructed and not attached to the AST. Several transforms scan the full list of constructed AST nodes to find nodes of a given type. Having detached nodes will likely cause bugs in these transforms. Detached nodes is also just a waste of memory. (b) They are attached to the AST, but the resolver did not traverse them. Having the resolver skip over parts of the AST will fail to catch validation issues, and will leave semantic gaps, likely breaking downstream logic. Bug: tint:469 Change-Id: I143b84fd830699f874d2936146f0e93197db610c Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/47778 Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@chromium.org> Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tint is a compiler for the WebGPU Shader Language (WGSL).
This is not an officially supported Google product.
TINT_BUILD_SPV_READER
: enable the SPIR-V input reader (off by default)TINT_BUILD_WGSL_READER
: enable the WGSL input reader (on by default)TINT_BUILD_SPV_WRITER
: enable the SPIR-V output writer (on by default)TINT_BUILD_WGSL_WRITER
: enable the WGSL output writer (on by default)TINT_BUILD_FUZZERS
: enable building fuzzzers (off by default)Tint uses Chromium dependency management so you need to install depot_tools and add it to your PATH.
# Clone the repo as "tint" git clone https://dawn.googlesource.com/tint tint cd tint # Bootstrap the gclient configuration cp standalone.gclient .gclient # Fetch external dependencies and toolchains with gclient gclient sync
mkdir -p out/Debug cd out/Debug cmake -GNinja ../.. ninja # or autoninja
mkdir -p out/Debug cd out/Debug cmake ../.. make # -j N for N-way parallel build
mkdir -p out/Debug gn gen out/Debug autoninja -C out/Debug
If you are attempting fuzz, using TINT_BUILD_FUZZERS=ON
, the version of llvm in the XCode SDK does not have the needed libfuzzer functionality included.
The build error that you will see from using the XCode SDK will look something like this:
ld: file not found:/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/11.0.0/lib/darwin/libclang_rt.fuzzer_osx.a
The solution to this problem is to use a full version llvm, like what you would get via homebrew, brew install llvm
, and use something like CC=<path to full clang> cmake ..
to setup a build using that toolchain.
The gn based work flow uses the Chromium toolchain for building in anticipation of integration of Tint into Chromium based projects. This toolchain has additional plugins for checking for style issues, which are marked with [chromium-style] in log messages. This means that this toolchain is more strict then the default clang toolchain.
In the future we will have a CQ that will build this work flow and flag issues automatically. Until that is in place, to avoid causing breakages you can run the [chromium-style] checks using the CMake based work flows. This requires setting CC
to the version of clang checked out by gclient sync
and setting the TINT_CHECK_CHROMIUM_STYLE
to ON
.
mkdir -p out/style cd out/style cmake ../.. CC=../../third_party/llvm-build/Release+Asserts/bin/clang cmake -DTINT_CHECK_CHROMIUM_STYLE=ON ../../ # add -GNinja for ninja builds
Please file any issues or feature requests at https://bugs.chromium.org/p/tint/issues/entry
Please see the CONTRIBUTING and CODE_OF_CONDUCT files on how to contribute to Tint.