)]}'
{
  "commit": "5c61d6d12ce3d7a330b543a2854aa2d7609b88f7",
  "tree": "5ee525411514852e709c2aa348bee794500ebf9c",
  "parents": [
    "98fbf241d80ad7ae912864af94712e9825e3e24a"
  ],
  "author": {
    "name": "James Price",
    "email": "jrprice@google.com",
    "time": "Wed Aug 04 19:18:38 2021 +0000"
  },
  "committer": {
    "name": "Tint LUCI CQ",
    "email": "tint-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Aug 04 19:18:38 2021 +0000"
  },
  "message": "msl: Fold \u0026* when converting module-scope vars\n\nThis transform was previously converting this code:\n```\nvar\u003cprivate\u003e v : f32;\nfn foo() {\n  bar(\u0026v);\n}\n```\n\ninto this:\n```\nfn foo(vp : ptr\u003cprivate, f32\u003e) {\n  bar(\u0026*vp); // Invalid, since ptr args must be \u0026ident\n}\n```\n\nFixed: tint:1086\nChange-Id: Ic9efafa219c89a11a4d6e1d11fc69b3c0b9a5464\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/60520\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nAuto-Submit: James Price \u003cjrprice@google.com\u003e\nReviewed-by: Ben Clayton \u003cbclayton@google.com\u003e\nCommit-Queue: Ben Clayton \u003cbclayton@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "5c86a03020c381e43d7bf5a8bb98382e93000a39",
      "old_mode": 33188,
      "old_path": "src/transform/msl.cc",
      "new_id": "54f20b2e0cfaaaaa9eb46d11b2005b3acbfd1500",
      "new_mode": 33188,
      "new_path": "src/transform/msl.cc"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "62731350ecac9f19798f6c9412ff654bd0ac03a6",
      "new_mode": 33188,
      "new_path": "test/bug/tint/1086.wgsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "c161767a7d6d451401c02003ea0540d86778b152",
      "new_mode": 33188,
      "new_path": "test/bug/tint/1086.wgsl.expected.hlsl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b75a05c9aebfb53d962ba85e107671936cb894d9",
      "new_mode": 33188,
      "new_path": "test/bug/tint/1086.wgsl.expected.msl"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "c2a13c600562e4c876f287c44bda9112a744f538",
      "new_mode": 33188,
      "new_path": "test/bug/tint/1086.wgsl.expected.spvasm"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "dbc74bec5b376d9146362ad09c7c77b27a21f539",
      "new_mode": 33188,
      "new_path": "test/bug/tint/1086.wgsl.expected.wgsl"
    },
    {
      "type": "modify",
      "old_id": "3ea62a4e23eb1540800fa5cca8d19d5a85a68f57",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicAdd/794055.wgsl.expected.msl",
      "new_id": "833e7a1cdd1a74067dcab150254bb6039d8b68e1",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicAdd/794055.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "4e6657e9f130eaf9b93b84d587c5a70f17366e51",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicAdd/d5db1d.wgsl.expected.msl",
      "new_id": "ed759ba035b498c1ff86e6956fd53ca6da4a21bd",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicAdd/d5db1d.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "a0c92bcac179b35674c26c4c0decc83b66829040",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicAnd/34edd3.wgsl.expected.msl",
      "new_id": "4d0eeda3715de970c6a973302c851d486f4e4d48",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicAnd/34edd3.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "61f15135a09ac05537390eae25126c47b9c6e1bd",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicAnd/45a819.wgsl.expected.msl",
      "new_id": "d861eae2a1f63994bd2dbfba0cf0f4fa5fa96eec",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicAnd/45a819.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "498a7955c0fe299f88a9d73fb5a8bc3a7a108af0",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicCompareExchangeWeak/89ea3b.wgsl.expected.msl",
      "new_id": "a9f790fa5fd2e7262bd4dbd08fa70913184daa64",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicCompareExchangeWeak/89ea3b.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "069071c5b42cd62091702916bc8529705b3c9c7c",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicCompareExchangeWeak/b2ab2c.wgsl.expected.msl",
      "new_id": "1f38df82861fc9d4d2427b3809bca9ade40b181a",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicCompareExchangeWeak/b2ab2c.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "b6b483b0db2b08edb457967345e73ed5fde85cce",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicExchange/0a5dca.wgsl.expected.msl",
      "new_id": "577ae12b823ba7b16fa53ecb23461bff416f68b8",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicExchange/0a5dca.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "806d8687087d1582cb9d39d5e9fce04aebe1b00f",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicExchange/e114ba.wgsl.expected.msl",
      "new_id": "ed4cb6fb661d0c70efdb4d87a861062508b85ffa",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicExchange/e114ba.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "144084f505ca922f0e2ad9973f8e7217333dd204",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicLoad/361bf1.wgsl.expected.msl",
      "new_id": "a3a6422c63d4bcda68b698a1a7b941e6a25ae0e4",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicLoad/361bf1.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "e2b1e2e5475eff2785e00349a6e764ba75db0659",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicLoad/afcc03.wgsl.expected.msl",
      "new_id": "2bb69957484819b14b8e3a1f8b59ef2da2dd1126",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicLoad/afcc03.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "32a298a1b3781ff0a10a5b380f7d8e2b149b8c28",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicMax/a89cc3.wgsl.expected.msl",
      "new_id": "7e7430e5ce4388f69ce1aeb135881de6b41e32cc",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicMax/a89cc3.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "c672d6dbbfda2cf0f935e09bd231b73aafa6a01d",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicMax/beccfc.wgsl.expected.msl",
      "new_id": "146b1efbb66f16d36ca6ecca3813d007fcdb3b51",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicMax/beccfc.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "077c2eb3f4ce6e42b2984409191c780e18cad769",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicMin/278235.wgsl.expected.msl",
      "new_id": "918868394cef6d7b8703c42e1ef61b48b1ae081e",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicMin/278235.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "920e3a993470768b65d06d2436bea65c39f8f906",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicMin/69d383.wgsl.expected.msl",
      "new_id": "6261ee3056a5dce18169b1296d25a003a0aaa600",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicMin/69d383.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "4a46d472937ec584a8808478686db0828c0c2410",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicOr/5e3d61.wgsl.expected.msl",
      "new_id": "7947b5709a54f59f4d81cb860d16cf258b6c5b24",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicOr/5e3d61.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "8795bb044f32d1fc10ae0c23d58c79d163557749",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicOr/d09248.wgsl.expected.msl",
      "new_id": "5669df106c13de8ece3d53aed3f720a29948c88a",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicOr/d09248.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "0404bec0dd783dce367a1df13327a2237c29f28b",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicStore/726882.wgsl.expected.msl",
      "new_id": "55d79c06e69649a54f2bd7c8f34163d79376460e",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicStore/726882.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "b4fc6b9a3de44e665edfa68ebd8316f96352f95e",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicStore/8bea94.wgsl.expected.msl",
      "new_id": "c8f7b5537ddb23b9860ca6bb7c296258c0d4aaa5",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicStore/8bea94.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "ec7c6b918aaef8f1a8408bc2e99a4883bdb4ef76",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicXor/75dc95.wgsl.expected.msl",
      "new_id": "b87b3d2441a6755c5fccb80332278d33f82fa78f",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicXor/75dc95.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "b4016cb550e34b781ad32fdf592b7911bb752302",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/atomicXor/c8e6be.wgsl.expected.msl",
      "new_id": "b7220c7020397262f06a98b4f3ca8981b78540ad",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/atomicXor/c8e6be.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "289d3c1c7e6fccb52d3c4e0a5523ce64a8458e28",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/frexp/0da285.wgsl.expected.msl",
      "new_id": "db21f1058622cbf9d096743c97f2e81497913a47",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/frexp/0da285.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "bc6a8ba2ab6bd26deb1ef7317dcd41740b1463e3",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/frexp/40fc9b.wgsl.expected.msl",
      "new_id": "ded1f19616930e59fec7807267847a9f43326f77",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/frexp/40fc9b.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "3911450c5d8c05823a9c8ff53603fe22b3935ec3",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/frexp/6efa09.wgsl.expected.msl",
      "new_id": "047a0eed61c168c5cce632713c1c318b4ebef2a3",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/frexp/6efa09.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "5ab05d4e3c4e83b63bd968cd8d95c427affaa47b",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/frexp/a2a617.wgsl.expected.msl",
      "new_id": "8ec28448e709796fdab3b4a9ae10771b7e103a92",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/frexp/a2a617.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "a5947cfb0afa18d060e24e307acc8afbc56984ea",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/frexp/a3f940.wgsl.expected.msl",
      "new_id": "fb24d37e7bfceb0d53720273552b334949e44ff2",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/frexp/a3f940.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "537576ad77e2557468235bc94d2d3a93f7dd05b9",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/frexp/b45525.wgsl.expected.msl",
      "new_id": "44aca0897cdf9b19007d25ca861bc46f939b9754",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/frexp/b45525.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "82dae4917fdcc040cd6efe6733cf0ba783038cb8",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/frexp/b87f4e.wgsl.expected.msl",
      "new_id": "1edfa88cc1ae70b0f569d5a6dcfdedc9a8236148",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/frexp/b87f4e.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "3bd387e671d985f2058498a1506f1fe288d2a957",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/frexp/c084e3.wgsl.expected.msl",
      "new_id": "407ee4545e23adc5d9fc709cb5e2d977922bbb40",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/frexp/c084e3.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "57eba738dc1287979cf2d7bf8de9de11f8c40905",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/modf/1d59e5.wgsl.expected.msl",
      "new_id": "9d2ffc90a4d17fa4e34348a125518241b49d98bc",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/modf/1d59e5.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "10b1b38af31395e62bc868ffe7fc736b6ae30cb1",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/modf/3d00e2.wgsl.expected.msl",
      "new_id": "6b31676236c2d287af50665b659c97c5050c4333",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/modf/3d00e2.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "531930ffb10d874d12f40c88870fb1cd246f7b11",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/modf/5e8476.wgsl.expected.msl",
      "new_id": "b8f60537b5dbc5da01602360a24b6010a2a2e0ba",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/modf/5e8476.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "b702b5c53c28a9d308296cbc3b44cd02cf126208",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/modf/9c6a91.wgsl.expected.msl",
      "new_id": "d3c48577c2088e3bfa8e0bd907447819c81cf409",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/modf/9c6a91.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "2a8186eac60c5d92d70f52cb7b0363d16076f155",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/modf/9cecfc.wgsl.expected.msl",
      "new_id": "f3325225ef51b23be211f30b10a226c6f87e412b",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/modf/9cecfc.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "ee30ac1e66dcabc3fdd28c67480f32dd1965e21a",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/modf/a128ab.wgsl.expected.msl",
      "new_id": "c475584172aa0a2f2a3b907ea3428c8ce9d1d9a3",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/modf/a128ab.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "2b5fa5aa798be16c0aefae1d451c4d87da0244b2",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/modf/bb9088.wgsl.expected.msl",
      "new_id": "10b3ff51f6977b3a38b790b9b97fc1a50bc1aa64",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/modf/bb9088.wgsl.expected.msl"
    },
    {
      "type": "modify",
      "old_id": "7c09c2475896c122c8b743ac92098785d9161e85",
      "old_mode": 33188,
      "old_path": "test/intrinsics/gen/modf/e38ae6.wgsl.expected.msl",
      "new_id": "bb6ccdf9dcabe016f55d15b24f8e56372f6f132b",
      "new_mode": 33188,
      "new_path": "test/intrinsics/gen/modf/e38ae6.wgsl.expected.msl"
    }
  ]
}