)]}' { "commit": "5914f7421c999c77ab780e6d6e22678a4cc89e7c", "tree": "73f84e556418b7aa2cda29563894f2cb0b85b3df", "parents": [ "f6ac1c3dfad618cfd518dfa0e208e8c1fbbc903b" ], "author": { "name": "Antonio Maiorano", "email": "amaiorano@google.com", "time": "Thu Sep 16 15:11:08 2021 +0000" }, "committer": { "name": "Tint LUCI CQ", "email": "tint-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 16 15:11:08 2021 +0000" }, "message": "spirv backend: do not generate a load for ignored expressions\n\nFixes spirv-val failing on loads of dynamic arrays.\n\nBug: chromium:1249602\nChange-Id: Ic15af9f9ef2beb45bc732e4e45f023651544a1c7\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/64400\nReviewed-by: Ben Clayton \u003cbclayton@google.com\u003e\nKokoro: Antonio Maiorano \u003camaiorano@google.com\u003e\nCommit-Queue: Antonio Maiorano \u003camaiorano@google.com\u003e\n(cherry picked from commit f018cedd92014d9eb18f05d638ec512bd98c2364)\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/64460\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "6532ffa81f3f6a1266dbee50b3eb900e46e56d3b", "old_mode": 33188, "old_path": "src/writer/spirv/builder.cc", "new_id": "1891652d038b7d805c95e3a877c4e5add2d3816c", "new_mode": 33188, "new_path": "src/writer/spirv/builder.cc" }, { "type": "modify", "old_id": "7d912789ad705942c59d12b4e29e605cf18c9d2d", "old_mode": 33188, "old_path": "test/bug/tint/1046.wgsl.expected.spvasm", "new_id": "be371f03f8ef0b53385213b488a8f73892d9f8c4", "new_mode": 33188, "new_path": "test/bug/tint/1046.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "f47b35214e49e4c470fed2b3b37ad19a48b38225", "old_mode": 33188, "old_path": "test/bug/tint/959.wgsl.expected.spvasm", "new_id": "de2df146b5b4f9314a311cb10634a143642a3957", "new_mode": 33188, "new_path": "test/bug/tint/959.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "72ffad92299921d2361b4c03c98983cdae16dda0", "old_mode": 33188, "old_path": "test/intrinsics/gen/ignore/2a6ac2.wgsl.expected.spvasm", "new_id": "6a6003d7542eb533ef4dfe9094802661c3fe526e", "new_mode": 33188, "new_path": "test/intrinsics/gen/ignore/2a6ac2.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "22615395b6db5b55b42a2d81657a5e11cc6c3c68", "old_mode": 33188, "old_path": "test/intrinsics/gen/ignore/5016e5.wgsl.expected.spvasm", "new_id": "bb23bc6e4bd4519453f4a9b1216b3dfaec013d6b", "new_mode": 33188, "new_path": "test/intrinsics/gen/ignore/5016e5.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "9b62c2f76b020f6c474ebe05e2d4f343992df053", "old_mode": 33188, "old_path": "test/intrinsics/gen/ignore/509355.wgsl.expected.spvasm", "new_id": "2a6d176ace92ca51e5b306c5e5b2207a94abb9b8", "new_mode": 33188, "new_path": "test/intrinsics/gen/ignore/509355.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "5472bfb00828b47e6a3a405c1c5582b203d25979", "old_mode": 33188, "old_path": "test/intrinsics/gen/ignore/5c9edf.wgsl.expected.spvasm", "new_id": "fcfbbb3a3568318fd4b1c93a60ac88b4852c3920", "new_mode": 33188, "new_path": "test/intrinsics/gen/ignore/5c9edf.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "5f0e9b88d4b96823b2d19f45c6dfa7bb95f49b7c", "old_mode": 33188, "old_path": "test/intrinsics/gen/ignore/ad88be.wgsl.expected.spvasm", "new_id": "a706caa4d04cfec8e78cc85258847bb84c157386", "new_mode": 33188, "new_path": "test/intrinsics/gen/ignore/ad88be.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "6d20fc2cd7529fa07db4c83983a90b6348ff9cff", "old_mode": 33188, "old_path": "test/intrinsics/gen/ignore/b469af.wgsl.expected.spvasm", "new_id": "f8886eb86cad840e7f8cceb7d3a83858d3270270", "new_mode": 33188, "new_path": "test/intrinsics/gen/ignore/b469af.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "e864cdb064b8880d9ec9d69c2a8a10a02c4bd43b", "old_mode": 33188, "old_path": "test/intrinsics/gen/ignore/c8a0ee.wgsl.expected.spvasm", "new_id": "766ca58618e0962e6b2254ba75ae3864ea50e45e", "new_mode": 33188, "new_path": "test/intrinsics/gen/ignore/c8a0ee.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "7d0b8e67b24c5a356ef6f7eda0b1c0b3739d3607", "old_mode": 33188, "old_path": "test/intrinsics/gen/ignore/e0187b.wgsl.expected.spvasm", "new_id": "aa1955645f6812c6fa00237231f1c547e4e1445c", "new_mode": 33188, "new_path": "test/intrinsics/gen/ignore/e0187b.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "4539b594315fd6d528b04bc0735daf55924ecf22", "old_mode": 33188, "old_path": "test/intrinsics/ignore/runtime_array.wgsl.expected.spvasm", "new_id": "8a335943f5e02971e224890d3c3e816a6552f69e", "new_mode": 33188, "new_path": "test/intrinsics/ignore/runtime_array.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "bd5b51fa97e3d730dd2ed2b30bf94110608b68e1", "old_mode": 33188, "old_path": "test/intrinsics/ignore/storage_buffer.wgsl.expected.spvasm", "new_id": "18661fef640cc41799a42c88f78a714b7389a93d", "new_mode": 33188, "new_path": "test/intrinsics/ignore/storage_buffer.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "3b232a3da9513df91f0bcf4b266ca1dae2bfb1ba", "old_mode": 33188, "old_path": "test/intrinsics/ignore/uniform_buffer.wgsl.expected.spvasm", "new_id": "e18af14b8d37e78c91f08d1df5e50780a43497b0", "new_mode": 33188, "new_path": "test/intrinsics/ignore/uniform_buffer.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "c96735e272cecb5788144b9972ebf5bf8357d0e4", "old_mode": 33188, "old_path": "test/types/sampler.wgsl.expected.spvasm", "new_id": "01e71332fadf20206f41dbe563f9efa7dbbd0e59", "new_mode": 33188, "new_path": "test/types/sampler.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "20772bcbb23168e871b3a5172e70ae3ae1074f44", "old_mode": 33188, "old_path": "test/types/texture/depth/2d.wgsl.expected.spvasm", "new_id": "7465d70d7e68c3ae14f1f5cd6b5532d41e36b4f7", "new_mode": 33188, "new_path": "test/types/texture/depth/2d.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "ef06878a41c53a30a889babd3a6b46dd384d3305", "old_mode": 33188, "old_path": "test/types/texture/depth/2d_array.wgsl.expected.spvasm", "new_id": "8e872a551bfc322868ee36c3eed7d10ea3b0ebf1", "new_mode": 33188, "new_path": "test/types/texture/depth/2d_array.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "980a03635f37a42c167d8e022ed9620a7d609cbc", "old_mode": 33188, "old_path": "test/types/texture/depth/cube.wgsl.expected.spvasm", "new_id": "8af16135fae7e3a7f56a7ea7a5f3a357a855fbf6", "new_mode": 33188, "new_path": "test/types/texture/depth/cube.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "7e8feb767f3553ca527f7749671bf693333b6ed6", "old_mode": 33188, "old_path": "test/types/texture/depth/cube_array.wgsl.expected.spvasm", "new_id": "fd96dbf76bfe63d36ba6571798004bba46ab3202", "new_mode": 33188, "new_path": "test/types/texture/depth/cube_array.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "fb8eb65a724b5225c6f24946bed21ba453eec9e5", "old_mode": 33188, "old_path": "test/types/texture/multisampled/2d.wgsl.expected.spvasm", "new_id": "4dcb22d3a7c4e9db3742ed6257509b91391d1a25", "new_mode": 33188, "new_path": "test/types/texture/multisampled/2d.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "d6de88cb4943147d0c41474b3c664320660bfa59", "old_mode": 33188, "old_path": "test/types/texture/sampled/1d.wgsl.expected.spvasm", "new_id": "61a74ac8d701019846a310a26eb6e2730d1a2e46", "new_mode": 33188, "new_path": "test/types/texture/sampled/1d.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "750d32ed11312d608513f74fd831c4d3820a6b4d", "old_mode": 33188, "old_path": "test/types/texture/sampled/2d.wgsl.expected.spvasm", "new_id": "c890825ad98567b4e3896ed7904ba0a277ef0131", "new_mode": 33188, "new_path": "test/types/texture/sampled/2d.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "d9e9dd23dd4563f72389521ba2286d3f046b9044", "old_mode": 33188, "old_path": "test/types/texture/sampled/2d_array.wgsl.expected.spvasm", "new_id": "fa4f943b172d5f1066d461cf0535adfe7573c127", "new_mode": 33188, "new_path": "test/types/texture/sampled/2d_array.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "3a2253e05999d17270289aae30bef7164ee2e136", "old_mode": 33188, "old_path": "test/types/texture/sampled/3d.wgsl.expected.spvasm", "new_id": "1a4b9a44aea2cbed4e93d828b73f5e6ec087bc61", "new_mode": 33188, "new_path": "test/types/texture/sampled/3d.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "b260e7d6fcdbac193092a55edf24946343f86941", "old_mode": 33188, "old_path": "test/types/texture/sampled/cube.wgsl.expected.spvasm", "new_id": "ab121490ac4d07c15cbd43e96eeafa2688aa15f6", "new_mode": 33188, "new_path": "test/types/texture/sampled/cube.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "9df0e15c9e3cebd8d4033d205cced3eb467e76d5", "old_mode": 33188, "old_path": "test/types/texture/sampled/cube_array.wgsl.expected.spvasm", "new_id": "1c066108e5e9c20b777e96ebc6755d65384cafbf", "new_mode": 33188, "new_path": "test/types/texture/sampled/cube_array.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "5cfe1470c1d3a2c9b11d6538bb0d780887be307d", "old_mode": 33188, "old_path": "test/types/texture/storage/1d.wgsl.expected.spvasm", "new_id": "8304a15b786d0d29a821a35a5f47c91484ca9ba3", "new_mode": 33188, "new_path": "test/types/texture/storage/1d.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "c41c90cd37ec31ea98279235c7fddf3139d885aa", "old_mode": 33188, "old_path": "test/types/texture/storage/2d.wgsl.expected.spvasm", "new_id": "0a7060b9fb60c232d18721167718e1c52bc74646", "new_mode": 33188, "new_path": "test/types/texture/storage/2d.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "998c280c4a41a4d466589d945ef7482d1784826b", "old_mode": 33188, "old_path": "test/types/texture/storage/2d_array.wgsl.expected.spvasm", "new_id": "bc8c3fe774030774c3ebf2116fb944ec1fdde4ba", "new_mode": 33188, "new_path": "test/types/texture/storage/2d_array.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "feeabd0427a052bd46d39550ee916670ce487293", "old_mode": 33188, "old_path": "test/types/texture/storage/3d.wgsl.expected.spvasm", "new_id": "2d03bbdce0af115dc8e6043679600bc88d8c7f95", "new_mode": 33188, "new_path": "test/types/texture/storage/3d.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "ced29ed95fba5f089f051af455f4477a8d766b9b", "old_mode": 33188, "old_path": "test/var/initialization/function/array.wgsl.expected.spvasm", "new_id": "dcbe83e9f1cdb6c4986db28b8dec8407a88a5758", "new_mode": 33188, "new_path": "test/var/initialization/function/array.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "5b2ef08c7ac13d7a1d2654010639e1de2c88ec32", "old_mode": 33188, "old_path": "test/var/initialization/function/matrix.wgsl.expected.spvasm", "new_id": "0f87cffd12668db0c7845a048c1b3183a5124a88", "new_mode": 33188, "new_path": "test/var/initialization/function/matrix.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "c67d83d5e104fb92ee724686a94b65067df6bed6", "old_mode": 33188, "old_path": "test/var/initialization/function/scalar.wgsl.expected.spvasm", "new_id": "2c7cf867a7681a4b7b11c3dfa77553c47e95f451", "new_mode": 33188, "new_path": "test/var/initialization/function/scalar.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "9c865a6c7d55c8f6609a1921afb8511c573131eb", "old_mode": 33188, "old_path": "test/var/initialization/function/struct.wgsl.expected.spvasm", "new_id": "f29f7fc234a5c4118336fcbf77fa81a43b321d3d", "new_mode": 33188, "new_path": "test/var/initialization/function/struct.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "aa8b4794c865057c99fb9afa133435ed397697ec", "old_mode": 33188, "old_path": "test/var/initialization/function/vector.wgsl.expected.spvasm", "new_id": "ce9e523f7abab6f3e0403dccad0db1587f4dcf43", "new_mode": 33188, "new_path": "test/var/initialization/function/vector.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "19965209845f2f418821ff788bee17c446f259de", "old_mode": 33188, "old_path": "test/var/initialization/private/array.wgsl.expected.spvasm", "new_id": "4a35a3a6ab26f5d2c8e5077a22a221b8d61c80b5", "new_mode": 33188, "new_path": "test/var/initialization/private/array.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "04a8f59985d50c60e0333a8e053487d9ab1a53b8", "old_mode": 33188, "old_path": "test/var/initialization/private/matrix.wgsl.expected.spvasm", "new_id": "e4c4739d90b1af88efb810f1ff79d6d449f8d253", "new_mode": 33188, "new_path": "test/var/initialization/private/matrix.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "3deea8cf2b92fa8ba5226d6c4f993aab10a7c56b", "old_mode": 33188, "old_path": "test/var/initialization/private/scalar.wgsl.expected.spvasm", "new_id": "6cdfba2f2f495263a78e2d60131133428d567712", "new_mode": 33188, "new_path": "test/var/initialization/private/scalar.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "ff2048adf6e3a1349afd2dec78bc7964c492d1f7", "old_mode": 33188, "old_path": "test/var/initialization/private/struct.wgsl.expected.spvasm", "new_id": "fcab0f5dbb0540c5ff5d6d6583cddb1679d94d49", "new_mode": 33188, "new_path": "test/var/initialization/private/struct.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "f5086e945982fb9e2c379a41006433446392f944", "old_mode": 33188, "old_path": "test/var/initialization/private/vector.wgsl.expected.spvasm", "new_id": "fdb0aa5761805f9cdf11e85be3857be696330d63", "new_mode": 33188, "new_path": "test/var/initialization/private/vector.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "287835b8202f2ee8ec9e96d32ea6044005ed9232", "old_mode": 33188, "old_path": "test/var/initialization/workgroup/array.wgsl.expected.spvasm", "new_id": "584939ee4619117ed97bafa6cf01a0bef4858c0c", "new_mode": 33188, "new_path": "test/var/initialization/workgroup/array.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "f4f4ed4da218dffdde6915e84042f828f6111ae1", "old_mode": 33188, "old_path": "test/var/initialization/workgroup/matrix.wgsl.expected.spvasm", "new_id": "6d2312d98f717b4cdf1ae633cf7eee7c4a05eb7a", "new_mode": 33188, "new_path": "test/var/initialization/workgroup/matrix.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "5d373793b18992c21e1604022f3af3f37c40d2fa", "old_mode": 33188, "old_path": "test/var/initialization/workgroup/scalar.wgsl.expected.spvasm", "new_id": "1cbc3ea8a37eafb2dc18463962ab96daa70db21e", "new_mode": 33188, "new_path": "test/var/initialization/workgroup/scalar.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "5ff4989a1331697095ae42d18600ef36d6dcb968", "old_mode": 33188, "old_path": "test/var/initialization/workgroup/struct.wgsl.expected.spvasm", "new_id": "1ef4fc9979ece93bb23ebe3dd35d2bb87885909b", "new_mode": 33188, "new_path": "test/var/initialization/workgroup/struct.wgsl.expected.spvasm" }, { "type": "modify", "old_id": "d4c554643f2078af0b0e430b86319cd2919dcd1b", "old_mode": 33188, "old_path": "test/var/initialization/workgroup/vector.wgsl.expected.spvasm", "new_id": "9efd8ebfd55f54d13ff711b43d1fa1b6cc6ebe4d", "new_mode": 33188, "new_path": "test/var/initialization/workgroup/vector.wgsl.expected.spvasm" } ] }