)]}' { "commit": "1fa6f5ce9ba83c84c9b2c015c6a63bf756497acc", "tree": "5617a84d5454a5d3f2d3f1ab431dd5adabf60f77", "parents": [ "f6a49d69b4bf9c62c57c7770791e323d3074ba08" ], "author": { "name": "Ben Clayton", "email": "bclayton@google.com", "time": "Sat Aug 21 08:50:40 2021 +0000" }, "committer": { "name": "Tint LUCI CQ", "email": "tint-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Aug 21 08:50:40 2021 +0000" }, "message": "resolver: Validate calls to void callables\n\nCalls to functions and intrinsics that do not return a value must only be used by a call statement.\n\nFixed: chromium:1241460\nChange-Id: I0f940c942b55a5212367dbf9e261083beb4560ec\nReviewed-on: https://dawn-review.googlesource.com/c/tint/+/62440\nKokoro: Kokoro \u003cnoreply+kokoro@google.com\u003e\nReviewed-by: James Price \u003cjrprice@google.com\u003e\nCommit-Queue: Ben Clayton \u003cbclayton@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "43305266c4f4a383c18c024304052f067ab19859", "old_mode": 33188, "old_path": "src/ast/intrinsic_texture_helper_test.cc", "new_id": "1d298a5af12a439c07c70a9c4314ba7515f45d49", "new_mode": 33188, "new_path": "src/ast/intrinsic_texture_helper_test.cc" }, { "type": "modify", "old_id": "92c698608a13da73870fa8a3385a5b0b4e93f010", "old_mode": 33188, "old_path": "src/ast/intrinsic_texture_helper_test.h", "new_id": "446090890a35a7561708cb239882bc89e173f9e1", "new_mode": 33188, "new_path": "src/ast/intrinsic_texture_helper_test.h" }, { "type": "modify", "old_id": "3c96d1062938eda934e50df7d567209f1964932a", "old_mode": 33188, "old_path": "src/resolver/call_test.cc", "new_id": "585099af278272d7d132ed6f7774764efccb6db4", "new_mode": 33188, "new_path": "src/resolver/call_test.cc" }, { "type": "modify", "old_id": "d0c7556f5e66059109c8af73a23a4a355f10506d", "old_mode": 33188, "old_path": "src/resolver/function_validation_test.cc", "new_id": "5aa7bac5e63c60e78e13ac11a1fd13a7fb600c65", "new_mode": 33188, "new_path": "src/resolver/function_validation_test.cc" }, { "type": "modify", "old_id": "e899bab19dd8fdd47f6aba2f7051e9f365e34676", "old_mode": 33188, "old_path": "src/resolver/intrinsic_test.cc", "new_id": "9270e0ad907d06ccb77f3771c7166cf04b07b65c", "new_mode": 33188, "new_path": "src/resolver/intrinsic_test.cc" }, { "type": "modify", "old_id": "6313ccca7028191d1f8d595407247c55713ee30a", "old_mode": 33188, "old_path": "src/resolver/intrinsic_validation_test.cc", "new_id": "77b7e94f2be890abaae064d60b01f83960854310", "new_mode": 33188, "new_path": "src/resolver/intrinsic_validation_test.cc" }, { "type": "modify", "old_id": "3eb96299640428cfa115775d9f57c8abdf09d871", "old_mode": 33188, "old_path": "src/resolver/resolver.cc", "new_id": "8f3206b54f815c83549cf70130deb431837644a5", "new_mode": 33188, "new_path": "src/resolver/resolver.cc" }, { "type": "modify", "old_id": "37de09090060724d053d4dadf45aae6e7c2e0b8f", "old_mode": 33188, "old_path": "src/resolver/resolver.h", "new_id": "90f305cb93f74c3e787a68e24af9b0dc2b450556", "new_mode": 33188, "new_path": "src/resolver/resolver.h" }, { "type": "modify", "old_id": "58abd7385f9dee8263557372d42754a5362e939a", "old_mode": 33188, "old_path": "src/resolver/validation_test.cc", "new_id": "07396a79b7d4a1cd991f6f292c855336fdff9911", "new_mode": 33188, "new_path": "src/resolver/validation_test.cc" }, { "type": "modify", "old_id": "a0391e557c073cdfa69c412273d8fed84bc6d3b3", "old_mode": 33188, "old_path": "src/writer/hlsl/generator_impl_call_test.cc", "new_id": "7d6e51c720596fecec9e7bee69c6633c6ed2de22", "new_mode": 33188, "new_path": "src/writer/hlsl/generator_impl_call_test.cc" }, { "type": "modify", "old_id": "1572cbfe7d2e2119723f8ccd71c8fab70023124a", "old_mode": 33188, "old_path": "src/writer/hlsl/generator_impl_intrinsic_texture_test.cc", "new_id": "279209ea1fc953424d721bdd1776d5ff738a2df8", "new_mode": 33188, "new_path": "src/writer/hlsl/generator_impl_intrinsic_texture_test.cc" }, { "type": "modify", "old_id": "3f2b2cb11fc2621be6489b62368552537a462d1a", "old_mode": 33188, "old_path": "src/writer/msl/generator_impl_call_test.cc", "new_id": "3b6379c2b98b7a498e7991486fbad4b3c8ac4038", "new_mode": 33188, "new_path": "src/writer/msl/generator_impl_call_test.cc" }, { "type": "modify", "old_id": "b2b718bf52a728f4cfeadd8fbc4006cd2ed7c5ac", "old_mode": 33188, "old_path": "src/writer/msl/generator_impl_intrinsic_test.cc", "new_id": "eba80cc25520e9297f481fb5ab7c8f1a9e0bcdf2", "new_mode": 33188, "new_path": "src/writer/msl/generator_impl_intrinsic_test.cc" }, { "type": "modify", "old_id": "c1f07875a0a18ccbc940021665043bb6be2ea8e0", "old_mode": 33188, "old_path": "src/writer/msl/generator_impl_intrinsic_texture_test.cc", "new_id": "f8ebd4df2c806909d719899248d4119c5f53de8a", "new_mode": 33188, "new_path": "src/writer/msl/generator_impl_intrinsic_texture_test.cc" }, { "type": "modify", "old_id": "2f19989145fb501b5b2f30ddcdaf47c6806c5f7b", "old_mode": 33188, "old_path": "src/writer/spirv/builder_intrinsic_texture_test.cc", "new_id": "78146dc277602018e9e769de63a017cc5d4bb815", "new_mode": 33188, "new_path": "src/writer/spirv/builder_intrinsic_texture_test.cc" }, { "type": "modify", "old_id": "42c360d36548d7a4973b853c3ac21c0426f63bed", "old_mode": 33188, "old_path": "src/writer/wgsl/generator_impl_call_test.cc", "new_id": "514f4a63df165c46b826753b42bf5f13b7451fad", "new_mode": 33188, "new_path": "src/writer/wgsl/generator_impl_call_test.cc" } ] }