commit | bc5d8f6bcf683af1a7968491e94bb6bfc445ac35 | [log] [tgz] |
---|---|---|
author | Antonio Maiorano <amaiorano@google.com> | Mon Nov 22 19:31:56 2021 +0000 |
committer | Tint LUCI CQ <tint-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 22 19:31:56 2021 +0000 |
tree | 463c6e7fa4cb9935f74c7f43838592c6079d5f56 | |
parent | 7368e287dc1b09ac83dd1e2113d1f4613f614a4c [diff] |
Revert "HLSL: force FXC to never unroll loops" This reverts commit 11d09f2fe7c006b78f7319e876e4ced43f0c1a60. Reason for revert: Failing roll of Tint to Dawn: https://dawn-review.googlesource.com/c/dawn/+/70100 Original change's description: > HLSL: force FXC to never unroll loops > > Emit the "[loop]" attribute on "for" and "while" so that FXC does not > attempt to unroll them. This is to work around an FXC bug where it fails > to unroll loops with gradient operations. > > FXC ostensibly unrolls such loops because gradient operations require > uniform control flow, and loops that have varying iterations may > possibly not be uniform. Tint will eventually validate that control flow > is indeed uniform, so forcing FXC to avoid unrolling in these cases > should be fine. > > Bug: tint:1112 > Change-Id: I10077f8b62fbbb230a0003f3864c75a8fe0e1d18 > Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/69880 > Kokoro: Kokoro <noreply+kokoro@google.com> > Reviewed-by: Ben Clayton <bclayton@google.com> > Commit-Queue: Antonio Maiorano <amaiorano@google.com> # Not skipping CQ checks because original CL landed > 1 day ago. Bug: tint:1112 Change-Id: I8e8f3c0abfa6e6bc5d0e67af9428a46ef867d5c1 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/70540 Reviewed-by: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Tint is a compiler for the WebGPU Shader Language (WGSL).
This is not an officially supported Google product.
TINT_BUILD_SPV_READER
: enable the SPIR-V input reader (off by default)TINT_BUILD_WGSL_READER
: enable the WGSL input reader (on by default)TINT_BUILD_SPV_WRITER
: enable the SPIR-V output writer (on by default)TINT_BUILD_WGSL_WRITER
: enable the WGSL output writer (on by default)TINT_BUILD_FUZZERS
: enable building fuzzzers (off by default)Tint uses Chromium dependency management so you need to install depot_tools and add it to your PATH.
# Clone the repo as "tint" git clone https://dawn.googlesource.com/tint tint cd tint # Bootstrap the gclient configuration cp standalone.gclient .gclient # Fetch external dependencies and toolchains with gclient gclient sync
mkdir -p out/Debug cd out/Debug cmake -GNinja ../.. ninja # or autoninja
mkdir -p out/Debug cd out/Debug cmake ../.. make # -j N for N-way parallel build
mkdir -p out/Debug gn gen out/Debug autoninja -C out/Debug
If you are attempting fuzz, using TINT_BUILD_FUZZERS=ON
, the version of llvm in the XCode SDK does not have the needed libfuzzer functionality included.
The build error that you will see from using the XCode SDK will look something like this:
ld: file not found:/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/11.0.0/lib/darwin/libclang_rt.fuzzer_osx.a
The solution to this problem is to use a full version llvm, like what you would get via homebrew, brew install llvm
, and use something like CC=<path to full clang> cmake ..
to setup a build using that toolchain.
The gn based work flow uses the Chromium toolchain for building in anticipation of integration of Tint into Chromium based projects. This toolchain has additional plugins for checking for style issues, which are marked with [chromium-style] in log messages. This means that this toolchain is more strict then the default clang toolchain.
In the future we will have a CQ that will build this work flow and flag issues automatically. Until that is in place, to avoid causing breakages you can run the [chromium-style] checks using the CMake based work flows. This requires setting CC
to the version of clang checked out by gclient sync
and setting the TINT_CHECK_CHROMIUM_STYLE
to ON
.
mkdir -p out/style cd out/style cmake ../.. CC=../../third_party/llvm-build/Release+Asserts/bin/clang cmake -DTINT_CHECK_CHROMIUM_STYLE=ON ../../ # add -GNinja for ninja builds
Please file any issues or feature requests at https://bugs.chromium.org/p/tint/issues/entry
Please see the CONTRIBUTING and CODE_OF_CONDUCT files on how to contribute to Tint.
Tint has a process for supporting experimental extensions.