remove dawn_analysis builder
dawn_analysis builder currently has 2 checks: inclusive language
check and spell checker.
inclusive language check is already covered in PRESUBMIT.py:
https://dawn.googlesource.com/dawn/+/main/PRESUBMIT.py
and Spellchecker is now replaced by the AyeAye version:
http://shortn/_fTT5nPhRvJ
Therefore, it should be safe to retire dawn_analysis builder.
Bug: 382140966
Change-Id: Ie82ad7ea011859d34b99bf839db822f4340da716
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/222194
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
diff --git a/infra/config/global/generated/commit-queue.cfg b/infra/config/global/generated/commit-queue.cfg
index 7c6be54..ed4bb36 100644
--- a/infra/config/global/generated/commit-queue.cfg
+++ b/infra/config/global/generated/commit-queue.cfg
@@ -460,11 +460,6 @@
}
}
builders {
- name: "dawn/try/dawn_analysis"
- owner_whitelist_group: "project-dawn-tryjob-access"
- mode_allowlist: "ANALYZER_RUN"
- }
- builders {
name: "dawn/try/linux-clang-dbg-x64"
location_filters {
gerrit_host_regexp: ".*"
diff --git a/infra/config/global/generated/cr-buildbucket.cfg b/infra/config/global/generated/cr-buildbucket.cfg
index 9f2fcfd..12fc40b 100644
--- a/infra/config/global/generated/cr-buildbucket.cfg
+++ b/infra/config/global/generated/cr-buildbucket.cfg
@@ -816,21 +816,6 @@
service_account: "dawn-try-builder@chops-service-accounts.iam.gserviceaccount.com"
}
builders {
- name: "dawn_analysis"
- swarming_host: "chromium-swarm.appspot.com"
- dimensions: "cores:8"
- dimensions: "cpu:x86-64"
- dimensions: "os:Ubuntu-20.04"
- dimensions: "pool:luci.flex.try"
- recipe {
- name: "dawn/analysis"
- cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
- cipd_version: "refs/heads/main"
- properties_j: "builder_group:\"tryserver.client.dawn\""
- }
- service_account: "dawn-try-builder@chops-service-accounts.iam.gserviceaccount.com"
- }
- builders {
name: "linux-clang-dbg-x64"
swarming_host: "chromium-swarm.appspot.com"
dimensions: "cpu:x86-64"
diff --git a/infra/config/global/generated/luci-milo.cfg b/infra/config/global/generated/luci-milo.cfg
index 812c36e..e817c33 100644
--- a/infra/config/global/generated/luci-milo.cfg
+++ b/infra/config/global/generated/luci-milo.cfg
@@ -203,9 +203,6 @@
builders {
name: "buildbucket/luci.dawn.try/cmake-win-msvc-rel-x64"
}
- builders {
- name: "buildbucket/luci.dawn.try/dawn_analysis"
- }
builder_view_only: true
}
logo_url: "https://storage.googleapis.com/chrome-infra-public/logo/dawn-logo.png"
diff --git a/infra/config/global/generated/tricium-prod.cfg b/infra/config/global/generated/tricium-prod.cfg
index 5e9098d..3acc667 100644
--- a/infra/config/global/generated/tricium-prod.cfg
+++ b/infra/config/global/generated/tricium-prod.cfg
@@ -20,29 +20,10 @@
}
}
}
-functions {
- type: ANALYZER
- name: "DawnTryDawnAnalysis"
- needs: GIT_FILE_DETAILS
- provides: RESULTS
- impls {
- provides_for_platform: LINUX
- runtime_platform: LINUX
- recipe {
- project: "dawn"
- bucket: "try"
- builder: "dawn_analysis"
- }
- }
-}
selections {
function: "ChromiumTryTriciumClangTidy"
platform: LINUX
}
-selections {
- function: "DawnTryDawnAnalysis"
- platform: LINUX
-}
repos {
gerrit_project {
host: "dawn-review.googlesource.com"
diff --git a/infra/config/global/main.star b/infra/config/global/main.star
index 57f1dc0..41df996 100755
--- a/infra/config/global/main.star
+++ b/infra/config/global/main.star
@@ -465,24 +465,6 @@
service_account = "dawn-try-builder@chops-service-accounts.iam.gserviceaccount.com",
)
-def add_tricium_builder():
- """Add a Try builder
- """
- luci.builder(
- name = "dawn_analysis",
- bucket = "try",
- executable = get_tricium_executable(),
- properties = {
- "builder_group": "tryserver.client.dawn",
- },
- dimensions = {
- "cores": "8",
- "cpu": "x86-64",
- "os": "Ubuntu-20.04",
- "pool": "luci.flex.try",
- },
- service_account = "dawn-try-builder@chops-service-accounts.iam.gserviceaccount.com",
- )
def dawn_standalone_builder(name, clang, debug, cpu, fuzzer):
"""Adds both the CI and Try standalone builders as appropriate
@@ -738,16 +720,6 @@
os: string for the OS, should be one or linux|mac|win
arch: string for the arch, or None
"""
-
- add_tricium_builder()
-
- luci.cq_tryjob_verifier(
- cq_group = "Dawn-CQ",
- builder = "dawn:try/dawn_analysis",
- owner_whitelist = ["project-dawn-tryjob-access"],
- mode_allowlist = [cq.MODE_ANALYZER_RUN],
- )
-
luci.cq_tryjob_verifier(
cq_group = "Dawn-CQ",
builder = "chromium:try/tricium-clang-tidy",
@@ -761,11 +733,6 @@
],
)
- luci.list_view_entry(
- list_view = "try",
- builder = "try/dawn_analysis",
- )
-
luci.gitiles_poller(
name = "primary-poller",
bucket = "ci",
