Remove ASSERT that encoding only produces validation errors
This is not true as resources are allocated for a variety of reasons
during command allocation. This is something we eventually want to get
rid of so replace the ASSERT with a TODO.
Bug: 42240579, 339614493
Change-Id: Ia880ceb5207ad8851ee0f1bce980bb0fd565295c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/187688
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
diff --git a/src/dawn/native/EncodingContext.cpp b/src/dawn/native/EncodingContext.cpp
index b1e1287..e70bd2f 100644
--- a/src/dawn/native/EncodingContext.cpp
+++ b/src/dawn/native/EncodingContext.cpp
@@ -92,8 +92,8 @@
}
if (!IsFinished() && !mDevice->IsImmediateErrorHandlingEnabled()) {
- // Encoding should only generate validation errors.
- DAWN_ASSERT(error->GetType() == InternalErrorType::Validation);
+ // TODO(crbug.com/42240579): ASSERT that encoding only generates validation errors.
+
// If the encoding context is not finished, errors are deferred until
// Finish() is called.
if (mError == nullptr) {
