commit 041385e9ebafb4bc1abe5522c8a0fab0b19ac9c9
author Jiawei Shao <jiawei.shao@intel.com> Wed Sep 06 01:05:56 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 06 01:05:56 2023 +0000
tree 497db84350c938d12c20163d983a0c7fdcf613de
parent 8a15bb12b0be03d9850cb59a2d16ec5deb066189

Enable ReadOnlyStorageTextureInFragmentShader on ANGLE

This patch enables ReadOnlyStorageTextureInFragmentShader on ANGLE
after all the related fixes are rolled into ANGLE.

Note that we need to implement read-only storage texture as sampled
texture in vertex shader to get ReadOnlyStorageTextureInVertexShader
pass on ANGLE.

Bug: dawn:1972
Test: dawn_end2end_tests
Change-Id: I952f2bc2700b764596c7c6ac185b0e9f0998a8a1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/149307
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>

src/dawn/tests/end2end/StorageTextureTests.cpp

diff --git a/src/dawn/tests/end2end/StorageTextureTests.cpp b/src/dawn/tests/end2end/StorageTextureTests.cpp
index 2b60725..54098c9 100644
--- a/src/dawn/tests/end2end/StorageTextureTests.cpp
+++ b/src/dawn/tests/end2end/StorageTextureTests.cpp
@@ -1211,8 +1211,7 @@
 TEST_P(ReadWriteStorageTextureTests, ReadOnlyStorageTextureInVertexShader) {
     DAWN_TEST_UNSUPPORTED_IF(!IsReadWriteStorageTextureSupported());
 
-    // TODO(dawn:1972): Investigate why ANGLE produces wrong HLSL code for read-only storage
-    // textures in vertex shader.
+    // TODO(dawn:1972): Implement read-only storage texture as sampled texture in vertex shader.
     DAWN_SUPPRESS_TEST_IF(IsOpenGLES());
 
     constexpr wgpu::TextureFormat kStorageTextureFormat = wgpu::TextureFormat::R32Uint;
@@ -1264,9 +1263,6 @@
 TEST_P(ReadWriteStorageTextureTests, ReadOnlyStorageTextureInFragmentShader) {
     DAWN_TEST_UNSUPPORTED_IF(!IsReadWriteStorageTextureSupported());
 
-    // TODO(dawn:1972): Investigate why the test fails on ANGLE.
-    DAWN_SUPPRESS_TEST_IF(IsOpenGLES());
-
     constexpr wgpu::TextureFormat kStorageTextureFormat = wgpu::TextureFormat::R32Uint;
     const std::vector<uint8_t> kInitialTextureData = GetExpectedData(kStorageTextureFormat);
     wgpu::Texture readonlyStorageTexture = CreateTextureWithTestData(