commit 047ee6b9f11e6ef966b87c74b89c2483d94e140c
author Gregg Tavares <gman@chromium.org> Mon Aug 25 18:06:19 2025 -0700
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Aug 25 18:06:19 2025 -0700
tree 5f399022c59aecf0046b134f60efe38173d88341
parent f07c28c7e7e7ee7740df74dd753933c9a7d41087

Capture: Encode BeginRenderPass

Bug: 440123094
Change-Id: I6a6a6964f3bc6b7285cdf0c39a747fa2520d5222
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/258754
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Gregg Tavares <gman@chromium.org>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Auto-Submit: Gregg Tavares <gman@chromium.org>

src/dawn/native/webgpu/CommandBufferWGPU.cpp

diff --git a/src/dawn/native/webgpu/CommandBufferWGPU.cpp b/src/dawn/native/webgpu/CommandBufferWGPU.cpp
index 2dc7ea8..32d38b6 100644
--- a/src/dawn/native/webgpu/CommandBufferWGPU.cpp
+++ b/src/dawn/native/webgpu/CommandBufferWGPU.cpp
@@ -27,6 +27,9 @@
 
 #include "dawn/native/webgpu/CommandBufferWGPU.h"
 
+#include <vector>
+
+#include "dawn/common/Assert.h"
 #include "dawn/common/StringViewUtils.h"
 #include "dawn/native/webgpu/BufferWGPU.h"
 #include "dawn/native/webgpu/DeviceWGPU.h"
@@ -61,6 +64,15 @@
     };
 }
 
+WGPUColor ToWGPU(const dawn::native::Color& color) {
+    return {
+        .r = color.r,
+        .g = color.g,
+        .b = color.b,
+        .a = color.a,
+    };
+}
+
 WGPUTexelCopyBufferInfo ToWGPU(const BufferCopy& copy) {
     return {
         .layout =
@@ -90,6 +102,31 @@
     }
 }
 
+WGPULoadOp ToWGPU(const wgpu::LoadOp op) {
+    switch (op) {
+        case wgpu::LoadOp::Load:
+            return WGPULoadOp_Load;
+        case wgpu::LoadOp::Clear:
+            return WGPULoadOp_Clear;
+        case wgpu::LoadOp::ExpandResolveTexture:
+            DAWN_UNREACHABLE();  // TODO(crbug.com/440123094): Fix when test that uses this is
+                                 // enabled.
+        default:
+            return WGPULoadOp_Undefined;
+    }
+}
+
+WGPUStoreOp ToWGPU(const wgpu::StoreOp op) {
+    switch (op) {
+        case wgpu::StoreOp::Store:
+            return WGPUStoreOp_Store;
+        case wgpu::StoreOp::Discard:
+            return WGPUStoreOp_Discard;
+        default:
+            return WGPUStoreOp_Undefined;
+    }
+}
+
 WGPUPassTimestampWrites ToWGPU(const TimestampWrites& writes) {
     return {
         .nextInChain = nullptr,
@@ -109,6 +146,36 @@
     };
 }
 
+WGPURenderPassColorAttachment ToWGPU(const RenderPassColorAttachmentInfo& info) {
+    return {
+        .nextInChain = nullptr,
+        // TODO(crbug.com/440123094): Do this when GetInnerHandle is implemented for TextureViewWGPU
+        .view = nullptr /* ToBackend(info.view)->GetInnerHandle()*/,
+        .depthSlice = info.depthSlice,
+        // TODO(crbug.com/440123094): Do this when GetInnerHandle is implemented for TextureViewWGPU
+        .resolveTarget = nullptr /* ToBackend(info.resolveTarget)->GetInnerHandle()*/,
+        .loadOp = ToWGPU(info.loadOp),
+        .storeOp = ToWGPU(info.storeOp),
+        .clearValue = ToWGPU(info.clearColor),
+    };
+}
+
+WGPURenderPassDepthStencilAttachment ToWGPU(const RenderPassDepthStencilAttachmentInfo& info) {
+    return {
+        .nextInChain = nullptr,
+        // TODO(crbug.com/440123094): Do this when GetInnerHandle is implemented for TextureViewWGPU
+        .view = nullptr /* ToBackend(info.view)->GetInnerHandle()*/,
+        .depthLoadOp = ToWGPU(info.depthLoadOp),
+        .depthStoreOp = ToWGPU(info.depthStoreOp),
+        .depthClearValue = info.clearDepth,
+        .depthReadOnly = info.depthReadOnly,
+        .stencilLoadOp = ToWGPU(info.stencilLoadOp),
+        .stencilStoreOp = ToWGPU(info.stencilStoreOp),
+        .stencilClearValue = info.clearStencil,
+        .stencilReadOnly = info.stencilReadOnly,
+    };
+}
+
 void EncodeComputePass(const DawnProcTable& wgpu,
                        WGPUCommandEncoder innerEncoder,
                        CommandIterator& commands,
@@ -218,6 +285,55 @@
     DAWN_UNREACHABLE();
 }
 
+void EncodeRenderPass(const DawnProcTable& wgpu,
+                      WGPUCommandEncoder innerEncoder,
+                      CommandIterator& commands,
+                      BeginRenderPassCmd* renderPassCmd) {
+    std::vector<WGPURenderPassColorAttachment> colorAttachments;
+
+    for (auto i : renderPassCmd->attachmentState->GetColorAttachmentsMask()) {
+        colorAttachments.push_back(ToWGPU(renderPassCmd->colorAttachments[i]));
+    }
+
+    colorAttachments.reserve(colorAttachments.size());
+    WGPURenderPassDepthStencilAttachment depthStencilAttachment =
+        ToWGPU(renderPassCmd->depthStencilAttachment);
+    WGPUPassTimestampWrites timestampWrites = ToWGPU(renderPassCmd->timestampWrites);
+
+    WGPURenderPassDescriptor passDescriptor{
+        .nextInChain = nullptr,
+        .label = ToOutputStringView(renderPassCmd->label),
+        .colorAttachmentCount = colorAttachments.size(),
+        .colorAttachments = colorAttachments.data(),
+        .depthStencilAttachment = &depthStencilAttachment,
+        // TODO(crbug.com/440123094): remove nullptr when GetInnerHandle is implemented for
+        // QuerySetWGPU
+        .occlusionQuerySet = nullptr /*ToBackend(cmd->occlusionQuerySet)->GetInnerHandle()*/,
+        .timestampWrites = &timestampWrites,
+    };
+    WGPURenderPassEncoder passEncoder =
+        wgpu.commandEncoderBeginRenderPass(innerEncoder, &passDescriptor);
+
+    Command type;
+    while (commands.NextCommandId(&type)) {
+        switch (type) {
+            case Command::EndRenderPass: {
+                commands.NextCommand<EndRenderPassCmd>();
+                wgpu.renderPassEncoderEnd(passEncoder);
+                return;
+            }
+
+            default: {
+                DAWN_UNREACHABLE();
+                break;
+            }
+        }
+    }
+
+    // EndRenderPass should have been called
+    DAWN_UNREACHABLE();
+}
+
 }  // anonymous namespace
 
 WGPUCommandBuffer CommandBuffer::Encode() {
@@ -235,6 +351,11 @@
                 EncodeComputePass(wgpu, innerEncoder, mCommands, cmd);
                 break;
             }
+            case Command::BeginRenderPass: {
+                auto cmd = mCommands.NextCommand<BeginRenderPassCmd>();
+                EncodeRenderPass(wgpu, innerEncoder, mCommands, cmd);
+                break;
+            }
             case Command::CopyBufferToBuffer: {
                 auto copy = mCommands.NextCommand<CopyBufferToBufferCmd>();
                 wgpu.commandEncoderCopyBufferToBuffer(