Enable DXC_CODEGEN_EXCEPTIONS_TRAP
When the DXC code generator traps, there is no valid recovery.
So it should generate a trap, which will generate a crash report,
instead of trying to continue processing.
Roll DirectX Shader Compiler from ffee5dcbe956 to b18fe87633ee (2 revisions)
https://chromium.googlesource.com/external/github.com/microsoft/DirectXShaderCompiler.git/+log/ffee5dcbe956..b18fe87633ee
2024-07-12 dneto@google.com Add CMake option DXC_CODEGEN_EXCEPTIONS_TRAP (#6764)
2024-07-11 grroth@microsoft.com Enable Living Release Notes (#6772)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/directx-shader-compiler-dawn
Please CC kainino@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in DirectX Shader Compiler: https://github.com/microsoft/DirectXShaderCompiler/issues/new/choose
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: 346618785
Change-Id: Iad156351282d315def1356d8e1b10b8d50abc7e9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/198274
Commit-Queue: David Neto <dneto@google.com>
Auto-Submit: David Neto <dneto@google.com>
Reviewed-by: Natalie Chouinard <chouinard@google.com>
diff --git a/DEPS b/DEPS
index f1e549d..6f118c4 100644
--- a/DEPS
+++ b/DEPS
@@ -332,7 +332,7 @@
},
'third_party/dxc': {
- 'url': '{chromium_git}/external/github.com/microsoft/DirectXShaderCompiler@ffee5dcbe9565d7dbd149d78256071cb7873e375',
+ 'url': '{chromium_git}/external/github.com/microsoft/DirectXShaderCompiler@b18fe87633ee1ff332557787969c11fb0317169b',
},
'third_party/dxheaders': {
diff --git a/third_party/dxc b/third_party/dxc
index ffee5dc..b18fe87 160000
--- a/third_party/dxc
+++ b/third_party/dxc
@@ -1 +1 @@
-Subproject commit ffee5dcbe9565d7dbd149d78256071cb7873e375
+Subproject commit b18fe87633ee1ff332557787969c11fb0317169b
diff --git a/third_party/gn/dxc/BUILD.gn b/third_party/gn/dxc/BUILD.gn
index aadb64e..0060484 100644
--- a/third_party/gn/dxc/BUILD.gn
+++ b/third_party/gn/dxc/BUILD.gn
@@ -453,7 +453,10 @@
cmake_configure_file("dxc-config-h") {
input = "$dawn_dxc_dir/include/dxc/config.h.cmake"
output = "$target_gen_dir/include/dxc/config.h"
- values = [ "DXC_DISABLE_ALLOCATOR_OVERRIDES=1" ]
+ values = [
+ "DXC_DISABLE_ALLOCATOR_OVERRIDES=1",
+ "DXC_CODEGEN_EXCEPTIONS_TRAP=1",
+ ]
}
#######################################################################
