commit 082e40192ceb805963ddd5d6ce47041357465224
author David Neto <dneto@google.com> Tue Mar 05 15:39:23 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Mar 05 15:39:23 2024 +0000
tree 94487a845dc218e1dcaa3b09c915d6855e3bf3e7
parent f81037d7fe941f26f3e2a5810be66a7b34d9ab3f

Fix clang-tidy warnings

- directly include headers for used symbols
  (misc-include-cleaner)
- ensure parameter names match between declaration and definition.
  (readability-inconsistent-declaration-parameter-name)

Change-Id: I1f4fc5b7340eb5bbf7db90502e0dc67c6a4592d0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/177701
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: David Neto <dneto@google.com>

src/dawn/native/ShaderModule.cpp

diff --git a/src/dawn/native/ShaderModule.cpp b/src/dawn/native/ShaderModule.cpp
index d0857a5..29b2878 100644
--- a/src/dawn/native/ShaderModule.cpp
+++ b/src/dawn/native/ShaderModule.cpp
@@ -29,6 +29,7 @@
 
 #include <algorithm>
 #include <sstream>
+#include <utility>
 
 #include "dawn/common/BitSetIterator.h"
 #include "dawn/common/Constants.h"

src/dawn/native/opengl/DeviceGL.cpp

diff --git a/src/dawn/native/opengl/DeviceGL.cpp b/src/dawn/native/opengl/DeviceGL.cpp
index 77a8a42..7c5b95f 100644
--- a/src/dawn/native/opengl/DeviceGL.cpp
+++ b/src/dawn/native/opengl/DeviceGL.cpp
@@ -47,6 +47,7 @@
 #include "dawn/native/opengl/ShaderModuleGL.h"
 #include "dawn/native/opengl/TextureGL.h"
 #include "dawn/native/opengl/UtilsGL.h"
+#include "dawn/native/opengl/opengl_platform.h"
 
 namespace {
 

src/dawn/native/opengl/SamplerGL.cpp

diff --git a/src/dawn/native/opengl/SamplerGL.cpp b/src/dawn/native/opengl/SamplerGL.cpp
index 31ea263..9f24a6e 100644
--- a/src/dawn/native/opengl/SamplerGL.cpp
+++ b/src/dawn/native/opengl/SamplerGL.cpp
@@ -28,6 +28,7 @@
 #include "dawn/native/opengl/SamplerGL.h"
 
 #include <algorithm>
+#include <cstdint>
 
 #include "dawn/common/Assert.h"
 #include "dawn/native/opengl/DeviceGL.h"

src/dawn/tests/end2end/EventTests.cpp

diff --git a/src/dawn/tests/end2end/EventTests.cpp b/src/dawn/tests/end2end/EventTests.cpp
index 2162fb4..e1a6371 100644
--- a/src/dawn/tests/end2end/EventTests.cpp
+++ b/src/dawn/tests/end2end/EventTests.cpp
@@ -33,6 +33,7 @@
 #include "dawn/common/FutureUtils.h"
 #include "dawn/tests/DawnTest.h"
 #include "dawn/webgpu.h"
+#include "gmock/gmock.h"
 
 namespace dawn {
 namespace {

src/dawn/tests/unittests/wire/WireErrorCallbackTests.cpp

diff --git a/src/dawn/tests/unittests/wire/WireErrorCallbackTests.cpp b/src/dawn/tests/unittests/wire/WireErrorCallbackTests.cpp
index 0ee6996..a1f52c2 100644
--- a/src/dawn/tests/unittests/wire/WireErrorCallbackTests.cpp
+++ b/src/dawn/tests/unittests/wire/WireErrorCallbackTests.cpp
@@ -28,6 +28,7 @@
 #include <memory>
 #include <utility>
 
+#include "dawn/common/FutureUtils.h"
 #include "dawn/tests/unittests/wire/WireFutureTest.h"
 #include "dawn/tests/unittests/wire/WireTest.h"
 #include "dawn/wire/WireClient.h"

src/dawn/tests/unittests/wire/WireQueueTests.cpp

diff --git a/src/dawn/tests/unittests/wire/WireQueueTests.cpp b/src/dawn/tests/unittests/wire/WireQueueTests.cpp
index 45d375e..87e2603 100644
--- a/src/dawn/tests/unittests/wire/WireQueueTests.cpp
+++ b/src/dawn/tests/unittests/wire/WireQueueTests.cpp
@@ -30,6 +30,7 @@
 #include "dawn/tests/unittests/wire/WireFutureTest.h"
 #include "dawn/tests/unittests/wire/WireTest.h"
 #include "dawn/wire/WireClient.h"
+#include "gmock/gmock.h"
 
 namespace dawn::wire {
 namespace {

src/tint/cmd/tint/main.cc

diff --git a/src/tint/cmd/tint/main.cc b/src/tint/cmd/tint/main.cc
index 5a11673..06f2ef0 100644
--- a/src/tint/cmd/tint/main.cc
+++ b/src/tint/cmd/tint/main.cc
@@ -63,6 +63,7 @@
 #include "src/tint/utils/text/string_stream.h"
 #include "src/tint/utils/text/styled_text.h"
 #include "src/tint/utils/text/styled_text_printer.h"
+#include "src/tint/utils/text/styled_text_theme.h"
 
 #if TINT_BUILD_WGSL_READER
 #include "src/tint/lang/wgsl/reader/program_to_ir/program_to_ir.h"

src/tint/lang/wgsl/ast/transform/array_length_from_uniform.cc

diff --git a/src/tint/lang/wgsl/ast/transform/array_length_from_uniform.cc b/src/tint/lang/wgsl/ast/transform/array_length_from_uniform.cc
index e307e25..1cb8c08 100644
--- a/src/tint/lang/wgsl/ast/transform/array_length_from_uniform.cc
+++ b/src/tint/lang/wgsl/ast/transform/array_length_from_uniform.cc
@@ -27,6 +27,7 @@
 
 #include "src/tint/lang/wgsl/ast/transform/array_length_from_uniform.h"
 
+#include <cstdint>
 #include <memory>
 #include <string>
 #include <string_view>

src/tint/utils/system/terminal_posix.cc

diff --git a/src/tint/utils/system/terminal_posix.cc b/src/tint/utils/system/terminal_posix.cc
index 699966d..a1b617d 100644
--- a/src/tint/utils/system/terminal_posix.cc
+++ b/src/tint/utils/system/terminal_posix.cc
@@ -44,8 +44,8 @@
 
 namespace tint {
 
-bool TerminalSupportsColors(FILE* f) {
-    if (!isatty(fileno(f))) {
+bool TerminalSupportsColors(FILE* out) {
+    if (!isatty(fileno(out))) {
         return false;
     }