Add Compat test: different aspects, same texture.
In Compatibility mode, test that two different views of
the same texture with different TextureAspect may not be used in
the same draw.
(We were doing the right thing, just in verifying *how* we were
doing the right thing, I discovered we had no coverage.)
Change-Id: Ifd1b4ec9e1ef99ce1676fd1ce64c30bf37e85e4e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/248296
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Reviewed-by: Gregg Tavares <gman@google.com>
diff --git a/src/dawn/tests/unittests/validation/CompatValidationTests.cpp b/src/dawn/tests/unittests/validation/CompatValidationTests.cpp
index b78a1ef9..ea74a2a 100644
--- a/src/dawn/tests/unittests/validation/CompatValidationTests.cpp
+++ b/src/dawn/tests/unittests/validation/CompatValidationTests.cpp
@@ -772,6 +772,27 @@
}
)";
+constexpr const char* kSampleDepthSampleStencilOneBindgroupWGSL = R"(
+ @vertex
+ fn vs(@builtin(vertex_index) VertexIndex : u32) -> @builtin(position) vec4f {
+ var pos = array(
+ vec4f(-1, 3, 0, 1),
+ vec4f( 3, -1, 0, 1),
+ vec4f(-1, -1, 0, 1));
+ return pos[VertexIndex];
+ }
+
+ @group(0) @binding(0) var depth : texture_2d<f32>;
+ @group(0) @binding(1) var stencil : texture_2d<u32>;
+
+ @fragment
+ fn fs(@builtin(position) pos: vec4f) -> @location(0) vec4f {
+ _ = depth;
+ _ = stencil;
+ return vec4f(0);
+ }
+)";
+
constexpr const char* kRenderTwoTexturesTwoBindgroupsWGSL = R"(
@vertex
fn vs(@builtin(vertex_index) VertexIndex : u32) -> @builtin(position) vec4f {
@@ -795,6 +816,7 @@
void TestMultipleTextureViewValidationInRenderPass(
wgpu::Device device,
+ wgpu::TextureFormat format,
const char* wgsl,
std::function<void(wgpu::Device device,
wgpu::Texture texture,
@@ -804,7 +826,7 @@
descriptor.size = {2, 1, 1};
descriptor.mipLevelCount = 2;
descriptor.dimension = wgpu::TextureDimension::e2D;
- descriptor.format = wgpu::TextureFormat::RGBA8Unorm;
+ descriptor.format = format;
descriptor.usage = wgpu::TextureUsage::TextureBinding;
wgpu::Texture texture = device.CreateTexture(&descriptor);
@@ -881,7 +903,7 @@
// in the same bind group. Unless FlexibleTextureViews is enabled.
TEST_P(CompatTextureViewValidationTests, CanNotDrawDifferentMipsSameTextureSameBindGroup) {
TestMultipleTextureViewValidationInRenderPass(
- device, kRenderTwoTexturesOneBindgroupWGSL,
+ device, wgpu::TextureFormat::RGBA8Unorm, kRenderTwoTexturesOneBindgroupWGSL,
[this](wgpu::Device device, wgpu::Texture texture, wgpu::RenderPipeline pipeline,
std::function<void(wgpu::RenderPassEncoder pass)> drawFn) {
wgpu::TextureViewDescriptor mip0ViewDesc;
@@ -916,7 +938,7 @@
// different bind groups. Unless FlexibleTextureViews is enabled.
TEST_P(CompatTextureViewValidationTests, CanNotDrawDifferentMipsSameTextureDifferentBindGroups) {
TestMultipleTextureViewValidationInRenderPass(
- device, kRenderTwoTexturesTwoBindgroupsWGSL,
+ device, wgpu::TextureFormat::RGBA8Unorm, kRenderTwoTexturesTwoBindgroupsWGSL,
[this](wgpu::Device device, wgpu::Texture texture, wgpu::RenderPipeline pipeline,
std::function<void(wgpu::RenderPassEncoder pass)> drawFn) {
wgpu::TextureViewDescriptor mip0ViewDesc;
@@ -957,7 +979,7 @@
TEST_P(CompatTextureViewValidationTests,
CanBindDifferentMipsSameTextureSameBindGroupAndFixWithoutError) {
TestMultipleTextureViewValidationInRenderPass(
- device, kRenderTwoTexturesOneBindgroupWGSL,
+ device, wgpu::TextureFormat::RGBA8Unorm, kRenderTwoTexturesOneBindgroupWGSL,
[](wgpu::Device device, wgpu::Texture texture, wgpu::RenderPipeline pipeline,
std::function<void(wgpu::RenderPassEncoder pass)> drawFn) {
wgpu::TextureViewDescriptor mip0ViewDesc;
@@ -999,7 +1021,7 @@
// bindgroups, does not generate a validation error.
TEST_P(CompatTextureViewValidationTests, CanBindSameViewIn2BindGroups) {
TestMultipleTextureViewValidationInRenderPass(
- device, kRenderTwoTexturesTwoBindgroupsWGSL,
+ device, wgpu::TextureFormat::RGBA8Unorm, kRenderTwoTexturesTwoBindgroupsWGSL,
[](wgpu::Device device, wgpu::Texture texture, wgpu::RenderPipeline pipeline,
std::function<void(wgpu::RenderPassEncoder pass)> drawFn) {
wgpu::TextureViewDescriptor mip0ViewDesc;
@@ -1034,7 +1056,7 @@
// but don't draw.
TEST_P(CompatTextureViewValidationTests, NoErrorIfMultipleDifferentViewsOfTextureAreNotUsed) {
TestMultipleTextureViewValidationInRenderPass(
- device, kRenderTwoTexturesTwoBindgroupsWGSL,
+ device, wgpu::TextureFormat::RGBA8Unorm, kRenderTwoTexturesTwoBindgroupsWGSL,
[](wgpu::Device device, wgpu::Texture texture, wgpu::RenderPipeline pipeline,
std::function<void(wgpu::RenderPassEncoder pass)> drawFn) {
wgpu::TextureViewDescriptor mip0ViewDesc;
@@ -1775,6 +1797,37 @@
HasFlexibleTextureViews());
}
+TEST_P(CompatTextureViewValidationTests, CanNotDrawDifferentAspectSameTextureSameBindGroup) {
+ TestMultipleTextureViewValidationInRenderPass(
+ device, wgpu::TextureFormat::Depth24PlusStencil8, kSampleDepthSampleStencilOneBindgroupWGSL,
+ [this](wgpu::Device device, wgpu::Texture texture, wgpu::RenderPipeline pipeline,
+ std::function<void(wgpu::RenderPassEncoder pass)> drawFn) {
+ wgpu::TextureViewDescriptor viewDesc1;
+ viewDesc1.dimension = wgpu::TextureViewDimension::e2D;
+ viewDesc1.aspect = wgpu::TextureAspect::DepthOnly;
+
+ wgpu::TextureViewDescriptor viewDesc2;
+ viewDesc2.dimension = wgpu::TextureViewDimension::e2D;
+ viewDesc2.aspect = wgpu::TextureAspect::StencilOnly;
+
+ wgpu::BindGroup bindGroup = utils::MakeBindGroup(
+ device, pipeline.GetBindGroupLayout(0),
+ {{0, texture.CreateView(&viewDesc1)}, {1, texture.CreateView(&viewDesc2)}});
+
+ wgpu::CommandEncoder encoder = device.CreateCommandEncoder();
+
+ utils::BasicRenderPass rp = utils::CreateBasicRenderPass(device, 4, 1);
+ wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&rp.renderPassInfo);
+ pass.SetPipeline(pipeline);
+ pass.SetBindGroup(0, bindGroup);
+ drawFn(pass);
+ pass.End();
+
+ ASSERT_TEXTURE_VIEW_ERROR_IF_NO_FLEXIBLE_FEATURE(encoder.Finish(),
+ testing::HasSubstr("different views"));
+ });
+}
+
// Test 2Darray != 2d
// Test cube !== 2d
// Test cube !== 2d-array
