Print the specific bind group in the error message of `APISetBindGroup`
Now we can print the label of the bind group in the error message of
`APISetBindGroup()` as the issue about the error message formatting has
gone.
Fixed: 42240188
Change-Id: I5bb28d11bd7b6639a972d6c003d38c095a027fb4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/206434
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
diff --git a/src/dawn/native/RenderEncoderBase.cpp b/src/dawn/native/RenderEncoderBase.cpp
index dd5570c..de0359f 100644
--- a/src/dawn/native/RenderEncoderBase.cpp
+++ b/src/dawn/native/RenderEncoderBase.cpp
@@ -719,11 +719,7 @@
return {};
},
- // TODO(dawn:1190): For unknown reasons formatting this message fails if `group` is used
- // as a string value in the message. This despite the exact same code working as
- // intended in ComputePassEncoder::APISetBindGroup. Replacing with a static [BindGroup]
- // until the reason for the failure can be determined.
- "encoding %s.SetBindGroup(%u, [BindGroup], %u, ...).", this, groupIndexIn,
+ "encoding %s.SetBindGroup(%u, %s, %u, ...).", this, groupIndexIn, group,
dynamicOffsetCount);
}
