commit 0c44f2650310379490adaa8f6d886f546b12c0a7
author Gregg Tavares <gman@chromium.org> Thu Feb 06 11:44:01 2025 -0800
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Feb 06 11:44:01 2025 -0800
tree 819bab640b00b79b0981f289f1fc798186531070
parent aa754b80e3c831ff89c4af46b64d24f0f73487ec

Disable multi-draw-indirect on Metal

Bug: 393183837
Change-Id: I1b5e140467824a56360018797438ee07714525d0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/224634
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Gregg Tavares <gman@chromium.org>
Commit-Queue: Gregg Tavares <gman@chromium.org>

src/dawn/native/metal/PhysicalDeviceMTL.mm

diff --git a/src/dawn/native/metal/PhysicalDeviceMTL.mm b/src/dawn/native/metal/PhysicalDeviceMTL.mm
index a797d6e..af0d5e1 100644
--- a/src/dawn/native/metal/PhysicalDeviceMTL.mm
+++ b/src/dawn/native/metal/PhysicalDeviceMTL.mm
@@ -641,9 +641,11 @@
     // argument buffer features which are required for multi draw. However, multi draw end2end tests
     // fail on non-Apple GPUs. Disable the feature for non-Apple GPUs. Apple3 family is the minimum
     // requirement and only includes Apple GPUs.
-    if ([*mDevice supportsFamily:MTLGPUFamilyApple3]) {
-        EnableFeature(Feature::MultiDrawIndirect);
-    }
+
+    // TODO(crbug.com/393183837) - Re-enable this feature when we use argument buffers.
+    // if ([*mDevice supportsFamily:MTLGPUFamilyApple3]) {
+    //     EnableFeature(Feature::MultiDrawIndirect);
+    // }
 
     EnableFeature(Feature::IndirectFirstInstance);
     EnableFeature(Feature::ShaderF16);