[spirv-reader][ir] Remove stale TODOs
Cleanup some TODOs which are no longer relevant as either being handled
or obsolete.
Bug: 42250952
Change-Id: Iecb1e0a5d099ede4d383ddbd05050ea1c66a1e22
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/256434
Auto-Submit: dan sinclair <dsinclair@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Commit-Queue: James Price <jrprice@google.com>
diff --git a/src/tint/lang/spirv/reader/lower/texture.cc b/src/tint/lang/spirv/reader/lower/texture.cc
index 1166a51..480dffe 100644
--- a/src/tint/lang/spirv/reader/lower/texture.cc
+++ b/src/tint/lang/spirv/reader/lower/texture.cc
@@ -926,7 +926,6 @@
img->GetTexelFormat(), img->GetAccess());
}
- // TODO(dsinclair): Handle determining depth texture by usage
if (img->GetDepth() == spirv::type::Depth::kDepth) {
if (img->GetMultisampled() == spirv::type::Multisampled::kMultisampled) {
return ty.depth_multisampled_texture(ConvertDim(img->GetDim(), img->GetArrayed()));
diff --git a/src/tint/lang/spirv/reader/parser/parser.cc b/src/tint/lang/spirv/reader/parser/parser.cc
index 9f6a7bd..0961dfd 100644
--- a/src/tint/lang/spirv/reader/parser/parser.cc
+++ b/src/tint/lang/spirv/reader/parser/parser.cc
@@ -134,7 +134,6 @@
for (const auto& import : spirv_context_->ext_inst_imports()) {
auto name = import.GetInOperand(0).AsString();
- // TODO(dneto): Handle other extended instruction sets when needed.
if (name == "GLSL.std.450") {
glsl_std_450_imports_.insert(import.result_id());
} else if (name.find("NonSemantic.") == 0) {
@@ -156,8 +155,6 @@
EmitFunctions();
EmitEntryPointAttributes();
- // TODO(crbug.com/tint/1907): Handle annotation instructions.
-
RemapSamplers();
RemapBufferBlockAddressSpace();
AddRefToOutputsIfNeeded();
@@ -653,7 +650,6 @@
}
return types_.GetOrAdd(TypeKey{type, key_mode}, [&]() -> const core::type::Type* {
- // TODO(crbug.com/1907): Handle decorations that affect the type
uint32_t array_stride = 0;
bool set_as_storage_buffer = false;
for (auto& deco : type->decorations()) {
