Factor wire client handlers into proper command handlers and doers
Bug: dawn:88
Change-Id: I3ab28efad7edc7d06f11aa5abae07a1bb3d7e59e
Reviewed-on: https://dawn-review.googlesource.com/c/4003
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
diff --git a/src/dawn_wire/client/ClientDoers.cpp b/src/dawn_wire/client/ClientDoers.cpp
new file mode 100644
index 0000000..ea542e5
--- /dev/null
+++ b/src/dawn_wire/client/ClientDoers.cpp
@@ -0,0 +1,140 @@
+// Copyright 2019 The Dawn Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "common/Assert.h"
+#include "dawn_wire/client/Client.h"
+#include "dawn_wire/client/Device.h"
+
+namespace dawn_wire { namespace client {
+
+ bool Client::DoDeviceErrorCallback(const char* message) {
+ DAWN_ASSERT(message != nullptr);
+ mDevice->HandleError(message);
+ return true;
+ }
+
+ bool Client::DoBufferMapReadAsyncCallback(Buffer* buffer,
+ uint32_t requestSerial,
+ uint32_t status,
+ uint32_t count,
+ const uint8_t* data) {
+ // The buffer might have been deleted or recreated so this isn't an error.
+ if (buffer == nullptr) {
+ return true;
+ }
+
+ // The requests can have been deleted via an Unmap so this isn't an error.
+ auto requestIt = buffer->requests.find(requestSerial);
+ if (requestIt == buffer->requests.end()) {
+ return true;
+ }
+
+ // It is an error for the server to call the read callback when we asked for a map write
+ if (requestIt->second.isWrite) {
+ return false;
+ }
+
+ auto request = requestIt->second;
+ // Delete the request before calling the callback otherwise the callback could be fired a
+ // second time. If, for example, buffer.Unmap() is called inside the callback.
+ buffer->requests.erase(requestIt);
+
+ // On success, we copy the data locally because the IPC buffer isn't valid outside of this
+ // function
+ if (status == DAWN_BUFFER_MAP_ASYNC_STATUS_SUCCESS) {
+ // The server didn't send the right amount of data, this is an error and could cause
+ // the application to crash if we did call the callback.
+ if (request.size != count) {
+ return false;
+ }
+
+ ASSERT(data != nullptr);
+
+ if (buffer->mappedData != nullptr) {
+ return false;
+ }
+
+ buffer->isWriteMapped = false;
+ buffer->mappedDataSize = request.size;
+ buffer->mappedData = malloc(request.size);
+ memcpy(buffer->mappedData, data, request.size);
+
+ request.readCallback(static_cast<dawnBufferMapAsyncStatus>(status), buffer->mappedData,
+ request.userdata);
+ } else {
+ request.readCallback(static_cast<dawnBufferMapAsyncStatus>(status), nullptr,
+ request.userdata);
+ }
+
+ return true;
+ }
+
+ bool Client::DoBufferMapWriteAsyncCallback(Buffer* buffer,
+ uint32_t requestSerial,
+ uint32_t status) {
+ // The buffer might have been deleted or recreated so this isn't an error.
+ if (buffer == nullptr) {
+ return true;
+ }
+
+ // The requests can have been deleted via an Unmap so this isn't an error.
+ auto requestIt = buffer->requests.find(requestSerial);
+ if (requestIt == buffer->requests.end()) {
+ return true;
+ }
+
+ // It is an error for the server to call the write callback when we asked for a map read
+ if (!requestIt->second.isWrite) {
+ return false;
+ }
+
+ auto request = requestIt->second;
+ // Delete the request before calling the callback otherwise the callback could be fired a
+ // second time. If, for example, buffer.Unmap() is called inside the callback.
+ buffer->requests.erase(requestIt);
+
+ // On success, we copy the data locally because the IPC buffer isn't valid outside of this
+ // function
+ if (status == DAWN_BUFFER_MAP_ASYNC_STATUS_SUCCESS) {
+ if (buffer->mappedData != nullptr) {
+ return false;
+ }
+
+ buffer->isWriteMapped = true;
+ buffer->mappedDataSize = request.size;
+ buffer->mappedData = malloc(request.size);
+ memset(buffer->mappedData, 0, request.size);
+
+ request.writeCallback(static_cast<dawnBufferMapAsyncStatus>(status), buffer->mappedData,
+ request.userdata);
+ } else {
+ request.writeCallback(static_cast<dawnBufferMapAsyncStatus>(status), nullptr,
+ request.userdata);
+ }
+
+ return true;
+ }
+
+ bool Client::DoFenceUpdateCompletedValue(Fence* fence, uint64_t value) {
+ // The fence might have been deleted or recreated so this isn't an error.
+ if (fence == nullptr) {
+ return true;
+ }
+
+ fence->completedValue = value;
+ fence->CheckPassedFences();
+ return true;
+ }
+
+}} // namespace dawn_wire::client
