commit 1c85976abe4e059684375915f955fc36049c8380
author Idan Raiter <idanr@google.com> Wed May 22 17:18:52 2019 +0000
committer Commit Bot service account <commit-bot@chromium.org> Wed May 22 17:18:52 2019 +0000
tree ca7df2a213291a27454cfd7eba5536ac28e1607a
parent 18672ef9941cb98d4818743085d6e5df82655ae9

dawn_native: handle NaN lod values in samplers

For samplers with NaN mLodMinClamp or mLodMaxClamp, the equality
operator returned false.
Adds checks for finite values, and also early returns if two pointers
are equal.

Bug: dawn:143, chromium:965633
Change-Id: Id5998d6eec275af0fbe30e3b4fcb3eed4fe64c6a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7401
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Idan Raiter <idanr@google.com>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 14e7cbb..0110ac5 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -13,10 +13,10 @@
 # limitations under the License.
 
 import("//build_overrides/build.gni")
+import("generator/dawn_generator.gni")
 import("scripts/dawn_component.gni")
 import("scripts/dawn_features.gni")
 import("scripts/dawn_overrides_with_defaults.gni")
-import("generator/dawn_generator.gni")
 
 import("//testing/test.gni")
 
@@ -579,6 +579,7 @@
     "src/tests/unittests/validation/RenderPassDescriptorValidationTests.cpp",
     "src/tests/unittests/validation/RenderPassValidationTests.cpp",
     "src/tests/unittests/validation/RenderPipelineValidationTests.cpp",
+    "src/tests/unittests/validation/SamplerValidationTests.cpp",
     "src/tests/unittests/validation/ShaderModuleValidationTests.cpp",
     "src/tests/unittests/validation/TextureValidationTests.cpp",
     "src/tests/unittests/validation/TextureViewValidationTests.cpp",