commit 1ce61695a59791c570d2d8cb116ce2e3d1a52f2a
author Arthur Sonzogni <arthursonzogni@chromium.org> Wed Jan 17 14:12:18 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jan 17 14:12:18 2024 +0000
tree b663742c9d53c348de9fb07793f9b1abd0434c46
parent 2dc9c25ea0da4d66312f494e64b5412ebbb5aed7

Annotate dangling pointer found with --wire-trace-dir={}

Outside of the CQ, one test is failing:
https://ci.chromium.org/ui/p/dawn/builders/ci/cron-linux-clang-rel-x64

Reproducer:
```
dawn_unittests \
  --use-wire \
  --wire-trace-dir={} \
  --gtest_filter=CountUTF16CodeUnitsFromUTF8StringTest.ValidUnicodeString
```

This patches annotates the pointer to ignore the error for now.

Bug: chromium:1464560, dawn:2345
Change-Id: Ie8e3130867384c2d5202e2c33802a097ffdbd153
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/170201
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>

src/dawn/utils/WireHelper.cpp

diff --git a/src/dawn/utils/WireHelper.cpp b/src/dawn/utils/WireHelper.cpp
index bd1e2f1..39608fc 100644
--- a/src/dawn/utils/WireHelper.cpp
+++ b/src/dawn/utils/WireHelper.cpp
@@ -86,7 +86,10 @@
 
   private:
     std::string mDir;
-    raw_ptr<dawn::wire::CommandHandler> mHandler;
+    // TODO(https://crbug.com/2345): Investigate `DanglingUntriaged` in DawnWire. To reproduce:
+    // dawn_unittests --use-wire --wire-trace-dir={} \
+    //   --gtest_filter=CountUTF16CodeUnitsFromUTF8StringTest.ValidUnicodeString
+    raw_ptr<dawn::wire::CommandHandler, DanglingUntriaged> mHandler;
     std::ofstream mFile;
 };