commit 1ddb39c14b3aff8d9099e75bebb1ed3efa75a46b
author Kyle Charbonneau <kylechar@google.com> Fri Nov 15 20:44:10 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Nov 15 20:44:10 2024 +0000
tree 07847f0ce9fd78c845d50153315a9f5921267082
parent d96255d193db7d2ed8c77d7d6785ccc7ca4fd17c

Destroy mMonolithicPipelineCache before VkDevice

PipelineCache needs to use the VkDevice to destroy the VkPipelineCache.

Bug: 370343334
Change-Id: Ia987b741ca390f84ae2f079e5551f1a7bcf6bbaf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/215194
Reviewed-by: Loko Kung <lokokung@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@google.com>

src/dawn/native/vulkan/DeviceVk.cpp

diff --git a/src/dawn/native/vulkan/DeviceVk.cpp b/src/dawn/native/vulkan/DeviceVk.cpp
index c88d294..6fc69c7 100644
--- a/src/dawn/native/vulkan/DeviceVk.cpp
+++ b/src/dawn/native/vulkan/DeviceVk.cpp
@@ -927,6 +927,9 @@
     // to them are guaranteed to be finished executing.
     mRenderPassCache = nullptr;
 
+    // Destroy the VkPipelineCache before VkDevice.
+    mMonolithicPipelineCache = nullptr;
+
     // Delete all the remaining VkDevice child objects immediately since the GPU timeline is
     // finished.
     GetFencedDeleter()->Tick(kMaxExecutionSerial);