commit 22e7815e4e7c3110e6ff4597aac5a29f5f6740c1
author Jaswant Panchumarti <jaswant.panchumarti@kitware.com> Fri Jun 21 15:44:23 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 21 15:44:23 2024 +0000
tree 43be142f9862553a92f4367d03ace9a338cd793a
parent 1cf515c77ebac3a1dc512c1a7f6ad05c86a8131c

Remove redundant assignment for SPIRV_SKIP_TESTS

- already done above

Change-Id: I4cfd71cb23b8ff23bdf01ecbb7b0346b90cf05dc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/194903
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Jaswant Panchumarti <jaswant.panchumarti@kitware.com>
Auto-Submit: Jaswant Panchumarti <jaswant.panchumarti@kitware.com>

third_party/CMakeLists.txt

diff --git a/third_party/CMakeLists.txt b/third_party/CMakeLists.txt
index 9d433b4..98e2898 100644
--- a/third_party/CMakeLists.txt
+++ b/third_party/CMakeLists.txt
@@ -61,14 +61,10 @@
         OR TINT_BUILD_SPV_READER
         OR TINT_BUILD_SPV_WRITER
         OR DAWN_USE_BUILT_DXC))
-    set(SPIRV_SKIP_TESTS ON CACHE BOOL "" FORCE)
+    set(SPIRV_SKIP_TESTS ON CACHE BOOL "Controls whether SPIR-V tests are run" FORCE)
     set(SPIRV_SKIP_EXECUTABLES ON CACHE BOOL "" FORCE)
     set(SKIP_SPIRV_TOOLS_INSTALL ON CACHE BOOL "" FORCE)
-
-    if(TINT_BUILD_SPV_READER OR TINT_BUILD_SPV_WRITER)
-        set(SPIRV_SKIP_TESTS ON CACHE BOOL "Controls whether SPIR-V tests are run" FORCE)
-        set(SPIRV_WERROR OFF CACHE BOOL OFF FORCE)
-    endif()
+    set(SPIRV_WERROR OFF CACHE BOOL OFF FORCE)
 
     message(STATUS "Dawn: using SPIRV-Tools at ${DAWN_SPIRV_TOOLS_DIR}")
     add_subdirectory(${DAWN_SPIRV_TOOLS_DIR} "${CMAKE_CURRENT_BINARY_DIR}/spirv-tools" EXCLUDE_FROM_ALL)