commit 232abaefc35def37fd6d2dae7a0086c9b3d70610
author Takahiro <hogehoge@gachapin.jp> Thu Jun 02 03:23:00 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jun 02 03:23:00 2022 +0000
tree c08ccebe14409be2c4f46e1b3a2d040349028e51
parent 2d74e1cf718b330b26a3954d6f6092c610730406

Delint for "use after move"

Some unittests break the clang-tidy rule
"bugprone-use-after-move". Moved-from variables after move
shouldn't be accessed even in the tests. No one should care
the behavior of moved-from objects. There is no pointing
testing something that shouldn't be observable with good code
practice ensured by clang-tidy.

This commit fixes the problem by removing the lines accessing
moved-from variables after move.

Bug: dawn:1436, dawn:1437, dawn:1438, dawn:1440
Change-Id: I5a6ccaa6fa74e607f818b5296a1715196bfd0f25
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/92204
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Takahiro <hogehoge@gachapin.jp>
Reviewed-by: Ben Clayton <bclayton@google.com>

src/dawn/tests/unittests/ITypVectorTests.cpp

diff --git a/src/dawn/tests/unittests/ITypVectorTests.cpp b/src/dawn/tests/unittests/ITypVectorTests.cpp
index 1aa82f1..3c3af49 100644
--- a/src/dawn/tests/unittests/ITypVectorTests.cpp
+++ b/src/dawn/tests/unittests/ITypVectorTests.cpp
@@ -110,8 +110,6 @@
         ASSERT_EQ(vec[Key(0)], Val(2));
         ASSERT_EQ(vec[Key(1)], Val(8));
         ASSERT_EQ(vec[Key(2)], Val(1));
-
-        ASSERT_EQ(rhs.size(), Key(0));
     }
 
     // Test the move assignment
@@ -123,8 +121,6 @@
         ASSERT_EQ(vec[Key(0)], Val(2));
         ASSERT_EQ(vec[Key(1)], Val(8));
         ASSERT_EQ(vec[Key(2)], Val(1));
-
-        ASSERT_EQ(rhs.size(), Key(0));
     }
 }
 

src/dawn/tests/unittests/LinkedListTests.cpp

diff --git a/src/dawn/tests/unittests/LinkedListTests.cpp b/src/dawn/tests/unittests/LinkedListTests.cpp
index 1832159..8737bab 100644
--- a/src/dawn/tests/unittests/LinkedListTests.cpp
+++ b/src/dawn/tests/unittests/LinkedListTests.cpp
@@ -337,9 +337,6 @@
 
     MovableNode n2_new(std::move(n2));
 
-    EXPECT_EQ(nullptr, n2.next());
-    EXPECT_EQ(nullptr, n2.previous());
-
     EXPECT_EQ(&n1, n2_new.previous());
     EXPECT_EQ(&n2_new, n1.next());
     EXPECT_EQ(&n3, n2_new.next());

src/dawn/tests/unittests/ObjectBaseTests.cpp

diff --git a/src/dawn/tests/unittests/ObjectBaseTests.cpp b/src/dawn/tests/unittests/ObjectBaseTests.cpp
index 0580275..56abe74 100644
--- a/src/dawn/tests/unittests/ObjectBaseTests.cpp
+++ b/src/dawn/tests/unittests/ObjectBaseTests.cpp
@@ -159,7 +159,6 @@
     Object source(&refcount);
     Object destination(std::move(source));
 
-    ASSERT_EQ(source.Get(), nullptr);
     ASSERT_EQ(destination.Get(), &refcount);
     ASSERT_EQ(2, refcount);
 
@@ -175,7 +174,6 @@
     Object destination;
     destination = std::move(source);
 
-    ASSERT_EQ(source.Get(), nullptr);
     ASSERT_EQ(destination.Get(), &refcount);
     ASSERT_EQ(2, refcount);
 

src/dawn/tests/unittests/RefCountedTests.cpp

diff --git a/src/dawn/tests/unittests/RefCountedTests.cpp b/src/dawn/tests/unittests/RefCountedTests.cpp
index d8a37a5..5f2312e 100644
--- a/src/dawn/tests/unittests/RefCountedTests.cpp
+++ b/src/dawn/tests/unittests/RefCountedTests.cpp
@@ -186,7 +186,6 @@
     original->Release();
     EXPECT_EQ(original->GetRefCountForTesting(), 1u);
 
-    EXPECT_EQ(source.Get(), nullptr);
     EXPECT_EQ(destination.Get(), original);
     EXPECT_FALSE(deleted);
 
@@ -209,7 +208,6 @@
     destination = std::move(source);
     EXPECT_EQ(original->GetRefCountForTesting(), 1u);
 
-    EXPECT_EQ(source.Get(), nullptr);
     EXPECT_EQ(destination.Get(), original);
     EXPECT_FALSE(deleted);
 
@@ -234,7 +232,6 @@
 
     referenceToSource = std::move(source);
 
-    EXPECT_EQ(source.Get(), original);
     EXPECT_EQ(original->GetRefCountForTesting(), 1u);
     EXPECT_FALSE(deleted);
 
@@ -356,7 +353,6 @@
     original->Release();
     EXPECT_EQ(original->GetRefCountForTesting(), 1u);
 
-    EXPECT_EQ(source.Get(), nullptr);
     EXPECT_EQ(destination.Get(), original);
     EXPECT_FALSE(deleted);
 
@@ -380,7 +376,6 @@
 
     EXPECT_EQ(original->GetRefCountForTesting(), 1u);
 
-    EXPECT_EQ(source.Get(), nullptr);
     EXPECT_EQ(destination.Get(), original);
     EXPECT_FALSE(deleted);