commit 2c4f822f9e78d491e3fa32dfee1add5b93c8be65
author Colin Blundell <blundell@chromium.org> Mon Nov 04 09:10:59 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Nov 04 09:10:59 2024 +0000
tree b46e06568ff98f3489e7c993e02b0d3deff501a7
parent b1a84c72f6c628b5773ba926375b1404c4b8ebaf

[Vulkan] Allow internal errors when calling GetAHardwareBufferProperties

This method makes a Vulkan API call that will return an error if
`handle` is invalid. This is not cause to lose the Dawn device, as it is
a client-side error and not a true internal Dawn error (see [1] for
fuller analysis).

[1] https://issues.chromium.org/u/1/issues/346282342#comment20

Change-Id: Id0abb3f44e4abc369c59bc8a330c425b8317c4ea
Bug: 346282342
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/213274
Commit-Queue: Colin Blundell <blundell@chromium.org>
Auto-Submit: Colin Blundell <blundell@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/dawn/native/Device.cpp

diff --git a/src/dawn/native/Device.cpp b/src/dawn/native/Device.cpp
index 7fa685d..6a9c7d3 100644
--- a/src/dawn/native/Device.cpp
+++ b/src/dawn/native/Device.cpp
@@ -1948,7 +1948,11 @@
         return wgpu::Status::Error;
     }
 
-    if (ConsumedError(GetAHardwareBufferPropertiesImpl(handle, properties))) {
+    // This method makes a Vulkan API call that will return an error if `handle` is invalid. This
+    // is not cause to lose the Dawn device, as it is a client-side error and not a true internal
+    // Dawn error.
+    if (ConsumedError(GetAHardwareBufferPropertiesImpl(handle, properties),
+                      InternalErrorType::Internal)) {
         return wgpu::Status::Error;
     }