commit 2d1136281e6ac9d08d1fadb06f5351559467f1e6
author Jiawei Shao <jiawei.shao@intel.com> Fri Apr 21 00:29:43 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Apr 21 00:29:43 2023 +0000
tree 38c1c142d2b179d3908e1f43bbe7d7826a1b035d
parent cf5aa73f812782376bdad5494008624e7fa431a1

Add missing default return values to slience Wreturn-type

This patch adds two missing default return values to slience the
compilation warning "Wreturn-type" when building dawn.node.

Bug: dawn:1761
Change-Id: I87c8566cabba4c2e14174bf9f38f53ed3c0fdb74
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/128103
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>

src/dawn/native/Buffer.cpp

diff --git a/src/dawn/native/Buffer.cpp b/src/dawn/native/Buffer.cpp
index 83f56e7..6cbcb40 100644
--- a/src/dawn/native/Buffer.cpp
+++ b/src/dawn/native/Buffer.cpp
@@ -251,6 +251,9 @@
         case BufferState::Unmapped:
         case BufferState::Destroyed:
             return wgpu::BufferMapState::Unmapped;
+        default:
+            UNREACHABLE();
+            return wgpu::BufferMapState::Unmapped;
     }
 }
 

src/dawn/native/Pipeline.cpp

diff --git a/src/dawn/native/Pipeline.cpp b/src/dawn/native/Pipeline.cpp
index 3e2dada..7a217a5 100644
--- a/src/dawn/native/Pipeline.cpp
+++ b/src/dawn/native/Pipeline.cpp
@@ -164,6 +164,9 @@
         case InternalErrorType::Internal:
         case InternalErrorType::OutOfMemory:
             return WGPUCreatePipelineAsyncStatus_InternalError;
+        default:
+            UNREACHABLE();
+            return WGPUCreatePipelineAsyncStatus_Unknown;
     }
 }