commit 33fd97846b33cf6be3e342cdc67ac40996c15fac
author Brandon Jones <bajones@chromium.org> Wed Sep 06 17:45:56 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 06 17:45:56 2023 +0000
tree a172e8a5bb28114a5876aab0cb8fde8666376ca6
parent 7a5f54eafc202b9c51cefae379f9e63fcbd14dcd

Remove VertexFormatTest suppressions for Android

Recent work done by dneto@ has caused these tests to start passing.

Bug: dawn:1566
Change-Id: I5f373b78fb3d6841ea4e46400e65b1dfce2cf84f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/149520
Auto-Submit: Brandon Jones <bajones@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: David Neto <dneto@google.com>

src/dawn/tests/end2end/VertexFormatTests.cpp

diff --git a/src/dawn/tests/end2end/VertexFormatTests.cpp b/src/dawn/tests/end2end/VertexFormatTests.cpp
index f9a419d..f4f6429 100644
--- a/src/dawn/tests/end2end/VertexFormatTests.cpp
+++ b/src/dawn/tests/end2end/VertexFormatTests.cpp
@@ -741,18 +741,12 @@
     DoVertexFormatTest(wgpu::VertexFormat::Float16x4, vertexData, vertexData);
 }
 TEST_P(VertexFormatTest, Float32_Zeros) {
-    // TODO(dawn:1566) Fails on Qualcomm-based Android devices. When using -0.0.
-    // This might pass now that we use rectify_f32?
-    DAWN_SUPPRESS_TEST_IF(IsAndroid() && IsQualcomm());
-
     std::vector<float> vertexData = {1.3f, +0.0f, -0.0f};
 
     DoVertexFormatTest(wgpu::VertexFormat::Float32, vertexData, vertexData);
 }
 
 TEST_P(VertexFormatTest, Float32_Plain) {
-    DAWN_SUPPRESS_TEST_IF(IsAndroid() && IsQualcomm());
-
     std::vector<float> vertexData = {+1.0f, -1.0f, 18.23f};
 
     DoVertexFormatTest(wgpu::VertexFormat::Float32, vertexData, vertexData);
@@ -763,9 +757,6 @@
     // TODO(dawn:1566) This might pass now that we use rectify_f32?
     DAWN_SUPPRESS_TEST_IF(IsVulkan() && IsNvidia());
 
-    // TODO(dawn:1566) Fails on Qualcomm-based Android devices.
-    DAWN_SUPPRESS_TEST_IF(IsAndroid() && IsQualcomm());
-
     std::vector<float> vertexData = {18.23f, -0.0f, +0.0f, +1.0f, 1.3f, -1.0f};
 
     DoVertexFormatTest(wgpu::VertexFormat::Float32x2, vertexData, vertexData);