commit 357cf13bc4dbbfa0231d5519ca8e1805025f84c4
author Ben Clayton <bclayton@google.com> Tue Jul 04 00:11:36 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jul 04 00:11:36 2023 +0000
tree e2a770b42bf0f33cc894b6985f567c818b292b80
parent e7f81173dedb07bc12ed7d139ced698000fe7ec1

[tint][fuzzers] Check program is valid

ApplySubstituteOverrides() will replace all `override` variables with `const` values.
The const value may be used by constant expressions, which have a large number of complex validation rules, the resulting program may not pass validation. Don't error in this case.

Bug: chromium:1458674
Change-Id: Icbca8e6a460d3dac7629f995e6662bce01658af0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/140121
Commit-Queue: James Price <jrprice@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>

src/tint/fuzzers/tint_common_fuzzer.cc

diff --git a/src/tint/fuzzers/tint_common_fuzzer.cc b/src/tint/fuzzers/tint_common_fuzzer.cc
index 02d2d4d..dad9e5f 100644
--- a/src/tint/fuzzers/tint_common_fuzzer.cc
+++ b/src/tint/fuzzers/tint_common_fuzzer.cc
@@ -236,7 +236,7 @@
     {
         // Run SubstituteOverride if required
         auto out = ApplySubstituteOverrides(std::move(program));
-        if (!validate_program(out)) {
+        if (!out.IsValid()) {
             return 0;
         }
     }

src/tint/fuzzers/tint_concurrency_fuzzer.cc

diff --git a/src/tint/fuzzers/tint_concurrency_fuzzer.cc b/src/tint/fuzzers/tint_concurrency_fuzzer.cc
index f2341a7..8c708ec 100644
--- a/src/tint/fuzzers/tint_concurrency_fuzzer.cc
+++ b/src/tint/fuzzers/tint_concurrency_fuzzer.cc
@@ -49,6 +49,9 @@
     }
 
     program = tint::fuzzers::ApplySubstituteOverrides(std::move(program));
+    if (!program.IsValid()) {
+        return 0;
+    }
 
     tint::inspector::Inspector inspector(&program);
     auto entry_points = inspector.GetEntryPoints();