Stop setting the bot_update apply_patch_on_gclient property.
This has not done anything in a couple of years.
Bug: chromium:353636548
Change-Id: I5a34bd6ea73578ececfbb5ebaacea323b2efc093
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/199014
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Brian Ryner <bryner@google.com>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
diff --git a/infra/config/global/generated/cr-buildbucket.cfg b/infra/config/global/generated/cr-buildbucket.cfg
index cba8483..098f9b6 100644
--- a/infra/config/global/generated/cr-buildbucket.cfg
+++ b/infra/config/global/generated/cr-buildbucket.cfg
@@ -541,7 +541,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "asan:false"
properties_j: "clang:true"
properties_j: "debug:true"
@@ -561,7 +560,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "asan:true"
properties_j: "clang:true"
properties_j: "debug:true"
@@ -581,7 +579,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "asan:false"
properties_j: "clang:true"
properties_j: "debug:true"
@@ -601,7 +598,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "asan:false"
properties_j: "clang:true"
properties_j: "debug:false"
@@ -621,7 +617,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "asan:true"
properties_j: "clang:true"
properties_j: "debug:false"
@@ -641,7 +636,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "asan:false"
properties_j: "clang:true"
properties_j: "debug:false"
@@ -661,7 +655,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "asan:false"
properties_j: "clang:true"
properties_j: "debug:true"
@@ -685,7 +678,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "asan:false"
properties_j: "clang:true"
properties_j: "debug:false"
@@ -708,7 +700,6 @@
name: "dawn/cmake"
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "asan:false"
properties_j: "clang:false"
properties_j: "debug:true"
@@ -731,7 +722,6 @@
name: "dawn/cmake"
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "asan:false"
properties_j: "clang:false"
properties_j: "debug:false"
@@ -770,7 +760,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "clang:true"
properties_j: "debug:true"
properties_j: "gen_fuzz_corpus:false"
@@ -789,7 +778,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "clang:true"
properties_j: "debug:true"
properties_j: "gen_fuzz_corpus:false"
@@ -808,7 +796,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "clang:true"
properties_j: "debug:false"
properties_j: "gen_fuzz_corpus:false"
@@ -827,7 +814,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "clang:true"
properties_j: "debug:false"
properties_j: "gen_fuzz_corpus:false"
@@ -846,7 +832,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "clang:true"
properties_j: "debug:true"
properties_j: "gen_fuzz_corpus:false"
@@ -869,7 +854,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "clang:true"
properties_j: "debug:false"
properties_j: "gen_fuzz_corpus:false"
@@ -891,7 +875,6 @@
name: "run_presubmit"
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "repo_name:\"dawn\""
properties_j: "runhooks:true"
}
@@ -908,7 +891,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "clang:true"
properties_j: "debug:true"
properties_j: "gen_fuzz_corpus:false"
@@ -931,7 +913,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "clang:true"
properties_j: "debug:true"
properties_j: "gen_fuzz_corpus:false"
@@ -954,7 +935,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "clang:true"
properties_j: "debug:false"
properties_j: "gen_fuzz_corpus:false"
@@ -977,7 +957,6 @@
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
properties_j: "$build/reclient:{\"instance\":\"rbe-chromium-untrusted\",\"jobs\":150,\"metrics_project\":\"chromium-reclient-metrics\",\"scandeps_server\":true}"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "clang:true"
properties_j: "debug:false"
properties_j: "gen_fuzz_corpus:false"
@@ -999,7 +978,6 @@
name: "dawn/gn"
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "clang:false"
properties_j: "debug:true"
properties_j: "gen_fuzz_corpus:false"
@@ -1021,7 +999,6 @@
name: "dawn/gn"
cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
cipd_version: "refs/heads/main"
- properties_j: "$depot_tools/bot_update:{\"apply_patch_on_gclient\":true}"
properties_j: "clang:false"
properties_j: "debug:false"
properties_j: "gen_fuzz_corpus:false"
diff --git a/infra/config/global/main.star b/infra/config/global/main.star
index 202233a..06dd00c 100755
--- a/infra/config/global/main.star
+++ b/infra/config/global/main.star
@@ -377,9 +377,6 @@
reclient.jobs.LOW_JOBS_FOR_CQ,
)
properties_try.update(properties)
- properties_try["$depot_tools/bot_update"] = {
- "apply_patch_on_gclient": True,
- }
luci.builder(
name = name,
bucket = "try",
@@ -716,9 +713,6 @@
properties = {
"repo_name": "dawn",
"runhooks": True,
- "$depot_tools/bot_update": {
- "apply_patch_on_gclient": True,
- },
},
service_account = "dawn-try-builder@chops-service-accounts.iam.gserviceaccount.com",
)
