commit 3dd0c8fabe5cdc7d7d8d8b2abfa63b1a344f067e
author Shrek Shao <shrekshao@google.com> Thu May 16 03:57:43 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 16 03:57:43 2024 +0000
tree 3af90644b885feca225ad5334f4d74240de7fb1f
parent 254a9bdbe62a075da94c297df2e49f8ee79332ba

Remove GL hang suppressions after using EGL fences

Bug: 42241420
Change-Id: Ic5abc3e147f6a100e3a81fb60ea0d1cf294224c7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/188481
Commit-Queue: Shrek Shao <shrekshao@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
Auto-Submit: Shrek Shao <shrekshao@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>

src/dawn/tests/end2end/CreatePipelineAsyncTests.cpp

diff --git a/src/dawn/tests/end2end/CreatePipelineAsyncTests.cpp b/src/dawn/tests/end2end/CreatePipelineAsyncTests.cpp
index ef4c26c..5ad3a5d 100644
--- a/src/dawn/tests/end2end/CreatePipelineAsyncTests.cpp
+++ b/src/dawn/tests/end2end/CreatePipelineAsyncTests.cpp
@@ -177,8 +177,6 @@
 // Verify that callback can be nullptr.
 TEST_P(CreatePipelineAsyncTest, CreateComputePipelineAsyncNullCallback) {
     DAWN_TEST_UNSUPPORTED_IF(UsesWire());
-    // TODO(crbug.com/dawn/2471): QueueGL hangs
-    DAWN_SUPPRESS_TEST_IF(IsOpenGL() || IsOpenGLES());
 
     wgpu::ComputePipelineDescriptor csDesc;
     csDesc.compute.module = utils::CreateShaderModule(device, R"(
@@ -204,8 +202,6 @@
 // Stress test that asynchronously creates many compute pipelines.
 TEST_P(CreatePipelineAsyncTest, CreateComputePipelineAsyncStress) {
     DAWN_TEST_UNSUPPORTED_IF(UsesWire());
-    // TODO(crbug.com/dawn/2471): QueueGL hangs
-    DAWN_SUPPRESS_TEST_IF(IsOpenGL() || IsOpenGLES());
 
     wgpu::CreateComputePipelineAsyncCallbackInfo callbackInfo;
     callbackInfo.mode = wgpu::CallbackMode::AllowProcessEvents;
@@ -240,8 +236,8 @@
 // Stress test that asynchronously creates many compute pipelines in different threads.
 TEST_P(CreatePipelineAsyncTest, CreateComputePipelineAsyncStressManyThreads) {
     DAWN_TEST_UNSUPPORTED_IF(UsesWire());
-    // TODO(crbug.com/dawn/2471): QueueGL hangs
-    DAWN_SUPPRESS_TEST_IF(IsOpenGL() || IsOpenGLES());
+    // eglMakeCurrent: Context can only be current on one thread
+    DAWN_TEST_UNSUPPORTED_IF(IsOpenGL() || IsOpenGLES());
 
     auto f = [&](size_t t) {
         wgpu::ComputePipelineDescriptor csDesc;
@@ -384,8 +380,6 @@
 // Verify that callback can be nullptr.
 TEST_P(CreatePipelineAsyncTest, CreateRenderPipelineAsyncNullCallback) {
     DAWN_TEST_UNSUPPORTED_IF(UsesWire());
-    // TODO(crbug.com/dawn/2471): QueueGL hangs
-    DAWN_SUPPRESS_TEST_IF(IsOpenGL() || IsOpenGLES());
 
     utils::ComboRenderPipelineDescriptor renderPipelineDescriptor;
     renderPipelineDescriptor.vertex.module = utils::CreateShaderModule(device, R"(
@@ -407,8 +401,6 @@
 // Stress test that asynchronously creates many render pipelines.
 TEST_P(CreatePipelineAsyncTest, CreateRenderPipelineAsyncStress) {
     DAWN_TEST_UNSUPPORTED_IF(UsesWire());
-    // TODO(crbug.com/dawn/2471): QueueGL hangs
-    DAWN_SUPPRESS_TEST_IF(IsOpenGL() || IsOpenGLES());
 
     wgpu::CreateRenderPipelineAsyncCallbackInfo callbackInfo;
     callbackInfo.mode = wgpu::CallbackMode::AllowProcessEvents;
@@ -439,8 +431,8 @@
 // Stress test that asynchronously creates many render pipelines in different threads.
 TEST_P(CreatePipelineAsyncTest, CreateRenderPipelineAsyncStressManyThreads) {
     DAWN_TEST_UNSUPPORTED_IF(UsesWire());
-    // TODO(crbug.com/dawn/2471): QueueGL hangs
-    DAWN_SUPPRESS_TEST_IF(IsOpenGL() || IsOpenGLES());
+    // eglMakeCurrent: Context can only be current on one thread
+    DAWN_TEST_UNSUPPORTED_IF(IsOpenGL() || IsOpenGLES());
 
     auto f = [&](size_t t) {
         utils::ComboRenderPipelineDescriptor desc;