commit 3f689a4c5ac6ba2717ddc2d50ecf19f6c3803caa
author François Beaufort <beaufort.francois@gmail.com> Mon Oct 04 11:30:02 2021 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Oct 04 11:30:02 2021 +0000
tree d2a1173bb941b9c38d1d73c5d18f0202201b717f
parent bf8c40b4f1c108d62744ab6a62864400cb7ee1cd

Rename "extension" to "feature"

This CL renames "extension" to "feature" to follow WebGPU. It still
supports both. A future Chromium CL will pick this change, then all
"extension" occurrences will be removed.

Change-Id: I070e32d7ae042f9b846df01f200b39f6741a0a14
Bug: dawn:1149
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/65664
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>

src/tests/DawnTest.cpp

diff --git a/src/tests/DawnTest.cpp b/src/tests/DawnTest.cpp
index 9f0c502..56e8279 100644
--- a/src/tests/DawnTest.cpp
+++ b/src/tests/DawnTest.cpp
@@ -854,7 +854,7 @@
     return mBackendAdapter;
 }
 
-std::vector<const char*> DawnTestBase::GetRequiredExtensions() {
+std::vector<const char*> DawnTestBase::GetRequiredFeatures() {
     return {};
 }
 
@@ -862,15 +862,15 @@
     return mParam.adapterProperties;
 }
 
-bool DawnTestBase::SupportsExtensions(const std::vector<const char*>& extensions) {
+bool DawnTestBase::SupportsFeatures(const std::vector<const char*>& features) {
     ASSERT(mBackendAdapter);
-    std::set<std::string> supportedExtensionsSet;
-    for (const char* supportedExtensionName : mBackendAdapter.GetSupportedExtensions()) {
-        supportedExtensionsSet.insert(supportedExtensionName);
+    std::set<std::string> supportedFeaturesSet;
+    for (const char* supportedFeatureName : mBackendAdapter.GetSupportedFeatures()) {
+        supportedFeaturesSet.insert(supportedFeatureName);
     }
 
-    for (const char* extensionName : extensions) {
-        if (supportedExtensionsSet.find(extensionName) == supportedExtensionsSet.end()) {
+    for (const char* featureName : features) {
+        if (supportedFeaturesSet.find(featureName) == supportedFeaturesSet.end()) {
             return false;
         }
     }
@@ -912,7 +912,7 @@
     dawn_native::DeviceDescriptor deviceDescriptor = {};
     deviceDescriptor.forceEnabledToggles = mParam.forceEnabledWorkarounds;
     deviceDescriptor.forceDisabledToggles = mParam.forceDisabledWorkarounds;
-    deviceDescriptor.requiredExtensions = GetRequiredExtensions();
+    deviceDescriptor.requiredFeatures = GetRequiredFeatures();
 
     // Disabled disallowing unsafe APIs so we can test them.
     deviceDescriptor.forceDisabledToggles.push_back("disallow_unsafe_apis");