commit 4111d9e10b6a885cebd55c1a0e48b2f10a8158b1
author Shrek Shao <shrekshao@google.com> Tue Feb 11 18:18:33 2025 -0800
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Feb 11 18:18:33 2025 -0800
tree 6b197a58f944aa6fb431d94c6d54922ca7b10132
parent 226438f934b6564f33321c94f5dd30cd203fd676

[Compat] Remove gles min31 end2end suppressions

Bug: 388318201
Change-Id: I02af722e4811aea20ff16ca84b4402a46f5389b3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/225640
Commit-Queue: Gregg Tavares <gman@chromium.org>
Reviewed-by: Gregg Tavares <gman@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Auto-Submit: Shrek Shao <shrekshao@google.com>

src/dawn/tests/end2end/SamplerFilterAnisotropicTests.cpp

diff --git a/src/dawn/tests/end2end/SamplerFilterAnisotropicTests.cpp b/src/dawn/tests/end2end/SamplerFilterAnisotropicTests.cpp
index 29b9a83..9d6fb8e 100644
--- a/src/dawn/tests/end2end/SamplerFilterAnisotropicTests.cpp
+++ b/src/dawn/tests/end2end/SamplerFilterAnisotropicTests.cpp
@@ -291,7 +291,7 @@
 };
 
 TEST_P(SamplerFilterAnisotropicTest, SlantedPlaneMipmap) {
-    // TODO(crbug.com/388318201): investigate
+    // requires EXT_texture_filter_anisotropic
     DAWN_SUPPRESS_TEST_IF(IsCompatibilityMode() &&
                           HasToggleEnabled("gl_force_es_31_and_no_extensions"));
     const uint16_t maxAnisotropyLists[] = {1, 2, 16, 128};

src/dawn/tests/end2end/StorageTextureTests.cpp

diff --git a/src/dawn/tests/end2end/StorageTextureTests.cpp b/src/dawn/tests/end2end/StorageTextureTests.cpp
index 056cc7b..5e54ed8 100644
--- a/src/dawn/tests/end2end/StorageTextureTests.cpp
+++ b/src/dawn/tests/end2end/StorageTextureTests.cpp
@@ -717,9 +717,6 @@
 
 // Test that write-only storage textures are supported in compute shader.
 TEST_P(StorageTextureTests, WriteonlyStorageTextureInComputeShader) {
-    // TODO(crbug.com/388318201): investigate
-    DAWN_SUPPRESS_TEST_IF(IsCompatibilityMode() &&
-                          HasToggleEnabled("gl_force_es_31_and_no_extensions"));
     for (wgpu::TextureFormat format : utils::kAllTextureFormats) {
         if (!utils::TextureFormatSupportsStorageTexture(format, device, IsCompatibilityMode())) {
             continue;
@@ -746,10 +743,6 @@
 
 // Test that write-only storage textures are supported in fragment shader.
 TEST_P(StorageTextureTests, WriteonlyStorageTextureInFragmentShader) {
-    // TODO(crbug.com/388318201): investigate
-    DAWN_SUPPRESS_TEST_IF(IsCompatibilityMode() &&
-                          HasToggleEnabled("gl_force_es_31_and_no_extensions"));
-
     // TODO(crbug.com/dawn/2295): diagnose this failure on Pixel 4 OpenGLES
     DAWN_SUPPRESS_TEST_IF(IsOpenGLES() && IsAndroid() && IsQualcomm());
 

src/dawn/tests/end2end/TextureFormatTests.cpp

diff --git a/src/dawn/tests/end2end/TextureFormatTests.cpp b/src/dawn/tests/end2end/TextureFormatTests.cpp
index 0e04dc4..4010889 100644
--- a/src/dawn/tests/end2end/TextureFormatTests.cpp
+++ b/src/dawn/tests/end2end/TextureFormatTests.cpp
@@ -902,7 +902,7 @@
 
 // Test the RG11B10Ufloat format
 TEST_P(TextureFormatTest, RG11B10Ufloat) {
-    // TODO(crbug.com/388318201): sampling test also requires format to be color-renderable
+    // sampling test also requires format to be color-renderable
     DAWN_SUPPRESS_TEST_IF(!IsRG11B10UfloatRenderableSupported());
     // TODO(crbug.com/388318201): expected: 0xf87e0000, actual: 0xfffff800
     DAWN_SUPPRESS_TEST_IF(IsD3D11());

src/dawn/tests/white_box/EGLImageWrappingTests.cpp

diff --git a/src/dawn/tests/white_box/EGLImageWrappingTests.cpp b/src/dawn/tests/white_box/EGLImageWrappingTests.cpp
index ba250c5..2631e14 100644
--- a/src/dawn/tests/white_box/EGLImageWrappingTests.cpp
+++ b/src/dawn/tests/white_box/EGLImageWrappingTests.cpp
@@ -140,7 +140,7 @@
         DawnTest::SetUp();
         // TODO(crbug.com/dawn/2206): remove this check if possible.
         DAWN_TEST_UNSUPPORTED_IF(!HasExtension("KHR_gl_texture_2D_image"));
-        // TODO(crbug.com/388318201): EGL extension not available
+        // EGL extension not available
         DAWN_TEST_UNSUPPORTED_IF(IsCompatibilityMode() &&
                                  HasToggleEnabled("gl_force_es_31_and_no_extensions"));
     }